From patchwork Thu Apr 2 08:37:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= X-Patchwork-Id: 1265488 X-Patchwork-Delegate: daniel.schwierzeck@googlemail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Rckt6XrU; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48tGfv1BbMz9sRR for ; Thu, 2 Apr 2020 19:38:11 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A6261800A9; Thu, 2 Apr 2020 10:38:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Rckt6XrU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AE3688006F; Thu, 2 Apr 2020 10:37:59 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 04ACB8006F for ; Thu, 2 Apr 2020 10:37:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=noltari@gmail.com Received: by mail-wr1-x442.google.com with SMTP id h9so3116142wrc.8 for ; Thu, 02 Apr 2020 01:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FrUMB0wDU4vSbR8jJO5uFmyWrmJsacr2oQZcdbcbpic=; b=Rckt6XrUQAyzvWY7s+4YG5X1HzO+WiUeuxqmxT0Wvh1Ozm1WbjtG0eWZK+2rr0OE9C URFiB603H2ILWYc2IZYeJvR0AX+L3b5NeDZhH90Eey7O8Tm6Qpn16YcZcyzoEOx3Cql9 duXGM8+yg4QKyTHNwH69CxaiYx7eoJ3KAvcksblWZklVsTDKHg53Qpbv8L9fTtJCjy/+ Lm+cFkdi7UVjG4ZbjcrXrukryyRCrCC2DY8wvaaoVNDtylXvOS/vy1hjfg7+nq2xw00L EnHyhPjrEBMo8Pw3F/J50nA0YFMHv/Kn9O/8LgNb2xVUCQbLFwZk6UMX4eAI7qTqBlwO cHLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FrUMB0wDU4vSbR8jJO5uFmyWrmJsacr2oQZcdbcbpic=; b=rrKIGisMqzYKnqbnDAGoHxOIvmaVMBiVezfiRbiBkTwm+fh0Uan+/gGhDGE81kQYqS y9NucWlhvYc5FSbQfM2f/w7BUH4BYcXUH8JpwdA2YO2yv18W9/0tcIkL0e3SOd9Z1n4Y PqXnlFqyMDIzuF9W6uGH9d1wF2/3X5Wr2Q19SBzbC99wvSwfhW3GT2tE1KBqqpj2DZkd R4MSwLHTUE9leUDwu2XDp6txeRbaWtvJSkdy+LCm/jiqbUmdiC59d9oz69SKUP+zr1SL E3Lus48fC1eu/tIHrhrNa8YUls0WM6RW4Rnabu9ljOXD5oMonUkFzLVwmkDWb7hhu0Tt vwXA== X-Gm-Message-State: AGi0PuZ81eOjJBNaXlECtIpGBnwvJUW/P5J24mcgu71+xFaPdrB/zGD4 ixDjhD8A8ZcsSpUj/xgClz78yfEkXic= X-Google-Smtp-Source: APiQypKNSsCbVdUBkI42w31WRkghdvz94NhHw4agO8kOZ1mG99LyCH+ZUqlgaqX0YXqvVIHzGbeRaA== X-Received: by 2002:adf:fe4b:: with SMTP id m11mr2304409wrs.20.1585816676135; Thu, 02 Apr 2020 01:37:56 -0700 (PDT) Received: from skynet.lan (13.red-83-47-35.dynamicip.rima-tde.net. [83.47.35.13]) by smtp.gmail.com with ESMTPSA id q9sm6952256wrp.84.2020.04.02.01.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2020 01:37:55 -0700 (PDT) From: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= To: u-boot@lists.denx.de, daniel.schwierzeck@gmail.com, philippe.reynes@softathome.com, trini@konsulko.com Cc: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= Subject: [PATCH] nand: brcmnand: return without disabling clock Date: Thu, 2 Apr 2020 10:37:52 +0200 Message-Id: <20200402083752.14077-1-noltari@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean Linux Broadcom NAND driver only disabled clock if no childs are initialized. This section of the code seems to have been accidentally dropped when it was imported in U-Boot. Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Daniel Schwierzeck --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c index 5232328e1e..7bdebf5869 100644 --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c @@ -2714,6 +2714,14 @@ int brcmnand_probe(struct udevice *dev, struct brcmnand_soc *soc) } #endif /* __UBOOT__ */ + /* No chip-selects could initialize properly */ + if (list_empty(&ctrl->host_list)) { + ret = -ENODEV; + goto err; + } + + return 0; + err: #ifndef __UBOOT__ clk_disable_unprepare(ctrl->clk); @@ -2722,7 +2730,6 @@ err: clk_disable(ctrl->clk); #endif /* __UBOOT__ */ return ret; - } EXPORT_SYMBOL_GPL(brcmnand_probe);