diff mbox series

[07/16] board: stm32mp1: Keep error led ON in case of low power detection

Message ID 20200331180330.7.I5954842931a3f46d943b91004a060d6fb5072109@changeid
State Superseded
Delegated to: Patrick Delaunay
Headers show
Series [01/16] arm: stm32mp: update dependency for STM32_ETZPC | expand

Commit Message

Patrick Delaunay March 31, 2020, 4:04 p.m. UTC
From: Patrice Chotard <patrice.chotard@st.com>

Since commit commit dd2810851eb1 ("stm32mp1: board: support of
error led on ed1/ev1 board") the attended behavior was no more
respected in case of low power source detection on DK2.

The expected behavior is either the error LED keeps blinking for ever,
or blinks 2 or 3 times and must stay ON.

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---

 board/st/stm32mp1/stm32mp1.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Patrice CHOTARD April 1, 2020, 7:44 a.m. UTC | #1
HI Patrick

On 3/31/20 6:04 PM, Patrick Delaunay wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> Since commit commit dd2810851eb1 ("stm32mp1: board: support of
> error led on ed1/ev1 board") the attended behavior was no more
> respected in case of low power source detection on DK2.
>
> The expected behavior is either the error LED keeps blinking for ever,
> or blinks 2 or 3 times and must stay ON.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
>
>  board/st/stm32mp1/stm32mp1.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
> index 07f5344ec9..8ed09ae24a 100644
> --- a/board/st/stm32mp1/stm32mp1.c
> +++ b/board/st/stm32mp1/stm32mp1.c
> @@ -316,6 +316,7 @@ static void __maybe_unused led_error_blink(u32 nb_blink)
>  			mdelay(125);
>  			WATCHDOG_RESET();
>  		}
> +		led_set_state(led, LEDST_ON);
>  	}
>  #endif
>  

Reviewed-by: Patrice Chotard <patrice.chotard@st.com>

Thanks
diff mbox series

Patch

diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
index 07f5344ec9..8ed09ae24a 100644
--- a/board/st/stm32mp1/stm32mp1.c
+++ b/board/st/stm32mp1/stm32mp1.c
@@ -316,6 +316,7 @@  static void __maybe_unused led_error_blink(u32 nb_blink)
 			mdelay(125);
 			WATCHDOG_RESET();
 		}
+		led_set_state(led, LEDST_ON);
 	}
 #endif