diff mbox series

[1/5] arm: dts: rockchip: rk3399: add and enable rng node

Message ID 20200331094001.13441-1-troy.lin@rock-chips.com
State Accepted
Delegated to: Kever Yang
Headers show
Series [1/5] arm: dts: rockchip: rk3399: add and enable rng node | expand

Commit Message

Lin Jinhan March 31, 2020, 9:39 a.m. UTC
Add rng node in rk3399-u-boot.dtsi and enable it in
rk3399-evb-u-boot.dtsi.

Signed-off-by: Lin Jinhan <troy.lin@rock-chips.com>
---
 arch/arm/dts/rk3399-evb-u-boot.dtsi | 5 +++++
 arch/arm/dts/rk3399-u-boot.dtsi     | 6 ++++++
 2 files changed, 11 insertions(+)

Comments

Peter Robinson April 1, 2020, 9:42 p.m. UTC | #1
On Tue, Mar 31, 2020 at 12:35 PM Lin Jinhan <troy.lin@rock-chips.com> wrote:
>
> Add rng node in rk3399-u-boot.dtsi and enable it in
> rk3399-evb-u-boot.dtsi.
>
> Signed-off-by: Lin Jinhan <troy.lin@rock-chips.com>
Tested-by: Peter Robinson <pbrobinson@gmail.com>

Tested with UEFI RNG providing a seed for KASLR.

> ---
>  arch/arm/dts/rk3399-evb-u-boot.dtsi | 5 +++++
>  arch/arm/dts/rk3399-u-boot.dtsi     | 6 ++++++
>  2 files changed, 11 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-evb-u-boot.dtsi b/arch/arm/dts/rk3399-evb-u-boot.dtsi
> index ccb33d34d1..5b50c5ba30 100644
> --- a/arch/arm/dts/rk3399-evb-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-evb-u-boot.dtsi
> @@ -11,3 +11,8 @@
>                 u-boot,spl-boot-order = &sdhci, &sdmmc;
>         };
>  };
> +
> +&rng {
> +       status = "okay";
> +};
> +
> diff --git a/arch/arm/dts/rk3399-u-boot.dtsi b/arch/arm/dts/rk3399-u-boot.dtsi
> index 8b857ccfc7..757b8c10a2 100644
> --- a/arch/arm/dts/rk3399-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-u-boot.dtsi
> @@ -25,6 +25,12 @@
>                 clock-names = "pclk_ddr_mon";
>         };
>
> +       rng: rng@ff8b8000 {
> +               compatible = "rockchip,cryptov1-rng";
> +               reg = <0x0 0xff8b8000 0x0 0x1000>;
> +               status = "disabled";
> +       };
> +
>         dmc: dmc {
>                 u-boot,dm-pre-reloc;
>                 compatible = "rockchip,rk3399-dmc";
> --
> 2.17.1
>
>
>
Sughosh Ganu April 4, 2020, 7:24 p.m. UTC | #2
On Tue, 31 Mar 2020 at 15:10, Lin Jinhan <troy.lin@rock-chips.com> wrote:

> Add rng node in rk3399-u-boot.dtsi and enable it in
> rk3399-evb-u-boot.dtsi.
>
> Signed-off-by: Lin Jinhan <troy.lin@rock-chips.com>
>

For the series

Reviewed-by: Sughosh Ganu <sughosh.ganu@linaro.org>

I guess Kever can pick it up directly in the rockchip tree. Thanks.

-sughosh



> ---
>  arch/arm/dts/rk3399-evb-u-boot.dtsi | 5 +++++
>  arch/arm/dts/rk3399-u-boot.dtsi     | 6 ++++++
>  2 files changed, 11 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-evb-u-boot.dtsi
> b/arch/arm/dts/rk3399-evb-u-boot.dtsi
> index ccb33d34d1..5b50c5ba30 100644
> --- a/arch/arm/dts/rk3399-evb-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-evb-u-boot.dtsi
> @@ -11,3 +11,8 @@
>                 u-boot,spl-boot-order = &sdhci, &sdmmc;
>         };
>  };
> +
> +&rng {
> +       status = "okay";
> +};
> +
> diff --git a/arch/arm/dts/rk3399-u-boot.dtsi
> b/arch/arm/dts/rk3399-u-boot.dtsi
> index 8b857ccfc7..757b8c10a2 100644
> --- a/arch/arm/dts/rk3399-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-u-boot.dtsi
> @@ -25,6 +25,12 @@
>                 clock-names = "pclk_ddr_mon";
>         };
>
> +       rng: rng@ff8b8000 {
> +               compatible = "rockchip,cryptov1-rng";
> +               reg = <0x0 0xff8b8000 0x0 0x1000>;
> +               status = "disabled";
> +       };
> +
>         dmc: dmc {
>                 u-boot,dm-pre-reloc;
>                 compatible = "rockchip,rk3399-dmc";
> --
> 2.17.1
>
>
>
>
Kever Yang April 14, 2020, 10:06 a.m. UTC | #3
On 2020/3/31 下午5:39, Lin Jinhan wrote:
> Add rng node in rk3399-u-boot.dtsi and enable it in
> rk3399-evb-u-boot.dtsi.
>
> Signed-off-by: Lin Jinhan <troy.lin@rock-chips.com>


Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/dts/rk3399-evb-u-boot.dtsi | 5 +++++
>   arch/arm/dts/rk3399-u-boot.dtsi     | 6 ++++++
>   2 files changed, 11 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-evb-u-boot.dtsi b/arch/arm/dts/rk3399-evb-u-boot.dtsi
> index ccb33d34d1..5b50c5ba30 100644
> --- a/arch/arm/dts/rk3399-evb-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-evb-u-boot.dtsi
> @@ -11,3 +11,8 @@
>   		u-boot,spl-boot-order = &sdhci, &sdmmc;
>   	};
>   };
> +
> +&rng {
> +	status = "okay";
> +};
> +
> diff --git a/arch/arm/dts/rk3399-u-boot.dtsi b/arch/arm/dts/rk3399-u-boot.dtsi
> index 8b857ccfc7..757b8c10a2 100644
> --- a/arch/arm/dts/rk3399-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-u-boot.dtsi
> @@ -25,6 +25,12 @@
>   		clock-names = "pclk_ddr_mon";
>   	};
>   
> +	rng: rng@ff8b8000 {
> +		compatible = "rockchip,cryptov1-rng";
> +		reg = <0x0 0xff8b8000 0x0 0x1000>;
> +		status = "disabled";
> +	};
> +
>   	dmc: dmc {
>   		u-boot,dm-pre-reloc;
>   		compatible = "rockchip,rk3399-dmc";
diff mbox series

Patch

diff --git a/arch/arm/dts/rk3399-evb-u-boot.dtsi b/arch/arm/dts/rk3399-evb-u-boot.dtsi
index ccb33d34d1..5b50c5ba30 100644
--- a/arch/arm/dts/rk3399-evb-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-evb-u-boot.dtsi
@@ -11,3 +11,8 @@ 
 		u-boot,spl-boot-order = &sdhci, &sdmmc;
 	};
 };
+
+&rng {
+	status = "okay";
+};
+
diff --git a/arch/arm/dts/rk3399-u-boot.dtsi b/arch/arm/dts/rk3399-u-boot.dtsi
index 8b857ccfc7..757b8c10a2 100644
--- a/arch/arm/dts/rk3399-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-u-boot.dtsi
@@ -25,6 +25,12 @@ 
 		clock-names = "pclk_ddr_mon";
 	};
 
+	rng: rng@ff8b8000 {
+		compatible = "rockchip,cryptov1-rng";
+		reg = <0x0 0xff8b8000 0x0 0x1000>;
+		status = "disabled";
+	};
+
 	dmc: dmc {
 		u-boot,dm-pre-reloc;
 		compatible = "rockchip,rk3399-dmc";