| Message ID | 20200326233749.633623-1-marex@denx.de |
|---|---|
| State | Superseded |
| Delegated to: | Patrick Delaunay |
| Headers | show |
| Series | ARM: dts: stm32: Repair PMIC configuration on AV96 | expand |
Hi Marek On 3/27/20 12:37 AM, Marek Vasut wrote: > The core and vdd PMIC buck regulators were misconfigured, which caused > instability of the board and malfunction of high-speed interfaces, like > the RGMII. Furthermore, the vtt_ddr was also wrong. Configure the PMIC > correctly to repair these problems. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Patrick Delaunay <patrick.delaunay@st.com> > Cc: Patrice Chotard <patrice.chotard@st.com> > --- > arch/arm/dts/stm32mp157a-avenger96.dts | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/dts/stm32mp157a-avenger96.dts b/arch/arm/dts/stm32mp157a-avenger96.dts > index b6c984171a..8e36df8787 100644 > --- a/arch/arm/dts/stm32mp157a-avenger96.dts > +++ b/arch/arm/dts/stm32mp157a-avenger96.dts > @@ -153,7 +153,7 @@ > > vddcore: buck1 { > regulator-name = "vddcore"; > - regulator-min-microvolt = <1200000>; > + regulator-min-microvolt = <800000>; > regulator-max-microvolt = <1350000>; > regulator-always-on; > regulator-initial-mode = <0>; > @@ -171,8 +171,8 @@ > > vdd: buck3 { > regulator-name = "vdd"; > - regulator-min-microvolt = <3300000>; > - regulator-max-microvolt = <3300000>; > + regulator-min-microvolt = <2500000>; > + regulator-max-microvolt = <2500000>; > regulator-always-on; > st,mask_reset; > regulator-initial-mode = <0>; > @@ -206,8 +206,8 @@ > > vtt_ddr: ldo3 { > regulator-name = "vtt_ddr"; > - regulator-min-microvolt = <500000>; > - regulator-max-microvolt = <750000>; > + regulator-min-microvolt = <0>; > + regulator-max-microvolt = <1000000>; > regulator-always-on; > regulator-over-current-protection; > }; > @@ -254,6 +254,7 @@ > regulator-name = "vbus_otg"; > interrupts = <IT_OCP_OTG 0>; > interrupt-parent = <&pmic>; > + regulator-active-discharge = <1>; > }; > > vbus_sw: pwr_sw2 { Reviewed-by: Patrice Chotard <patrice.chotard@st.com> Thanks
diff --git a/arch/arm/dts/stm32mp157a-avenger96.dts b/arch/arm/dts/stm32mp157a-avenger96.dts index b6c984171a..8e36df8787 100644 --- a/arch/arm/dts/stm32mp157a-avenger96.dts +++ b/arch/arm/dts/stm32mp157a-avenger96.dts @@ -153,7 +153,7 @@ vddcore: buck1 { regulator-name = "vddcore"; - regulator-min-microvolt = <1200000>; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <1350000>; regulator-always-on; regulator-initial-mode = <0>; @@ -171,8 +171,8 @@ vdd: buck3 { regulator-name = "vdd"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <2500000>; regulator-always-on; st,mask_reset; regulator-initial-mode = <0>; @@ -206,8 +206,8 @@ vtt_ddr: ldo3 { regulator-name = "vtt_ddr"; - regulator-min-microvolt = <500000>; - regulator-max-microvolt = <750000>; + regulator-min-microvolt = <0>; + regulator-max-microvolt = <1000000>; regulator-always-on; regulator-over-current-protection; }; @@ -254,6 +254,7 @@ regulator-name = "vbus_otg"; interrupts = <IT_OCP_OTG 0>; interrupt-parent = <&pmic>; + regulator-active-discharge = <1>; }; vbus_sw: pwr_sw2 {
The core and vdd PMIC buck regulators were misconfigured, which caused instability of the board and malfunction of high-speed interfaces, like the RGMII. Furthermore, the vtt_ddr was also wrong. Configure the PMIC correctly to repair these problems. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Patrick Delaunay <patrick.delaunay@st.com> Cc: Patrice Chotard <patrice.chotard@st.com> --- arch/arm/dts/stm32mp157a-avenger96.dts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)