From patchwork Wed Mar 25 15:36:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 1261506 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=GL5FYCoK; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48nXMg1pZKz9sRR for ; Thu, 26 Mar 2020 02:38:39 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8F08E81813; Wed, 25 Mar 2020 16:38:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GL5FYCoK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B171281854; Wed, 25 Mar 2020 16:37:19 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A824581813 for ; Wed, 25 Mar 2020 16:37:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.vasut@gmail.com Received: by mail-wm1-x343.google.com with SMTP id m3so3249777wmi.0 for ; Wed, 25 Mar 2020 08:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qeyPBxz5MG90M2mxQw6lW/RldbrIxNtNez4UTsr0gro=; b=GL5FYCoKivIxycDLuJ6RITn72h0xh0U05UF3HtTCqwZKQzAvN5RvsDSKnLVA9qMrS9 XHtitzdCsLAEvVnbBsV44IE/lqQFDfFWb6BuDkq+MgMz9RM+QaCBjflIaeUZ2LUfAkdj SAmC+RgYTqUJJCbI+LtcFB7qS/m0tsPUqzI4+OOJdhvSe11o2Kd0q+xcdzcbWmbWfzqg OW8roeIXfGy7r5+qBk+HY0dAuwsBRuC94e64dPwHt2b1L/jRh4g1wmFNAHceS6O2nabJ kRcFvVoTGqM/maSUeOdqqAjTG1KTywcXipzRHeDfCGn+0atGXIF8ru09tgie7vXkoQUh j9TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qeyPBxz5MG90M2mxQw6lW/RldbrIxNtNez4UTsr0gro=; b=rEE13isyt3e3LtfhsCiacEjXngzqbNzCRePK2bRJGFBItLW+sx0yEO2nXzrKnpB0Ty HM+36rZGfu7WDebY8ikVmreNeReousC3qs66oFoSo9k/vuw35SgnhY7K4IS+NSuKxLdq P02ePWTJfn4EfEuEIWrQ4T6L3+/JwJqVHWaBByCrbZ9j5mom8TrAzW+eIHXYXxgchRqN BY1W9m+hXDs3kgwASCIrpf3PtTqLQpOsSwDjHwNJdFa1YyDUeOpxKNZ6kjHr7BKQarXA b0XrJmpJYwjdU6kQsgrQ1ENPMgxxO9WY24vrf5HnNIPnL633s8ZhfLNzCh6603xnAapV vgtg== X-Gm-Message-State: ANhLgQ2nAxMfBN9O/8OAVDM8p63JFnVblugjo7YpDI92DKEoB739ipeb idqMK1kKkSgp1Kbfl8wktrbTWgi8 X-Google-Smtp-Source: ADFU+vvbCQD0GsyhFlpZ1+/LOFgPBPa/rZ0Uov9QZjJFMuHzxejqQHmAYS8ZXwJq840KguApD0j7Pg== X-Received: by 2002:a05:600c:204:: with SMTP id 4mr3794117wmi.112.1585150624441; Wed, 25 Mar 2020 08:37:04 -0700 (PDT) Received: from desktop.lan (ip-86-49-35-8.net.upcbroadband.cz. [86.49.35.8]) by smtp.gmail.com with ESMTPSA id w11sm34396823wrv.86.2020.03.25.08.37.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2020 08:37:02 -0700 (PDT) From: Marek Vasut X-Google-Original-From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Joe Hershberger , Masahiro Yamada Subject: [PATCH V3 04/13] net: smc911x: Invert the logic in smc911x_miiphy_{read, write}() Date: Wed, 25 Mar 2020 16:36:39 +0100 Message-Id: <20200325153648.99993-5-marek.vasut+renesas@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200325153648.99993-1-marek.vasut+renesas@gmail.com> References: <20200325153648.99993-1-marek.vasut+renesas@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean Invert the logic in the aforementioned functions to reduce indent, no functional change. Signed-off-by: Marek Vasut Cc: Joe Hershberger Cc: Masahiro Yamada --- V2: No change V3: No change --- drivers/net/smc911x.c | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index 6da6c89546..ceb4f81215 100644 --- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c @@ -216,24 +216,29 @@ static int smc911x_recv(struct eth_device *dev) static int smc911x_miiphy_read(struct mii_dev *bus, int phy, int devad, int reg) { - u16 val = 0; struct eth_device *dev = eth_get_dev_by_name(bus->name); - if (dev) { - int retval = smc911x_eth_phy_read(dev, phy, reg, &val); - if (retval < 0) - return retval; - return val; - } - return -ENODEV; + u16 val = 0; + int ret; + + if (!dev) + return -ENODEV; + + ret = smc911x_eth_phy_read(dev, phy, reg, &val); + if (ret < 0) + return ret; + + return val; } /* wrapper for smc911x_eth_phy_write */ static int smc911x_miiphy_write(struct mii_dev *bus, int phy, int devad, int reg, u16 val) { struct eth_device *dev = eth_get_dev_by_name(bus->name); - if (dev) - return smc911x_eth_phy_write(dev, phy, reg, val); - return -ENODEV; + + if (!dev) + return -ENODEV; + + return smc911x_eth_phy_write(dev, phy, reg, val); } #endif