From patchwork Wed Mar 25 13:42:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 1261395 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=mth0IAsY; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48nTnj5qssz9sSW for ; Thu, 26 Mar 2020 00:42:30 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7F36B81776; Wed, 25 Mar 2020 14:42:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="mth0IAsY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 709C5817D0; Wed, 25 Mar 2020 14:42:19 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 34D1280111 for ; Wed, 25 Mar 2020 14:42:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=m.szyprowski@samsung.com Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200325134211euoutp010764d751043cceb0f2f3ab50c22aa1c1~-j9NfdSKd2049520495euoutp01g for ; Wed, 25 Mar 2020 13:42:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200325134211euoutp010764d751043cceb0f2f3ab50c22aa1c1~-j9NfdSKd2049520495euoutp01g DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1585143731; bh=rlLfC5QWvvaimWc14u8e2jFgqHqyHaRIQiMl4Wziwuc=; h=From:To:Cc:Subject:Date:References:From; b=mth0IAsY0LdX458vsFkthCO3Pm106Hw7wTtGWRbXVft4ROn+EZYTEpx6C+5c0GNv5 zrI0HFIEJo/S2YjVcqZ0Pda+UDrlbBw/+MyiwxCZdONKVZw4Os24neaivn5AFVj0C2 eD837xYmA1p1ybp8TP7rB7JLp/GZk9vbckeqMp3U= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200325134211eucas1p15ad3d26cd06c5208a305cb3ad476ecc9~-j9NF9Itw2491524915eucas1p13; Wed, 25 Mar 2020 13:42:11 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 2D.67.60679.3BF5B7E5; Wed, 25 Mar 2020 13:42:11 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200325134211eucas1p25efcdbfaf6cd1a1088d6eb104e75db19~-j9M08hU-1937219372eucas1p2s; Wed, 25 Mar 2020 13:42:11 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200325134211eusmtrp19192e9b882a66144873f2b310b4650fa~-j9M0ZXdK0947409474eusmtrp1X; Wed, 25 Mar 2020 13:42:11 +0000 (GMT) X-AuditID: cbfec7f4-0cbff7000001ed07-ce-5e7b5fb3275c Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 64.CE.07950.3BF5B7E5; Wed, 25 Mar 2020 13:42:11 +0000 (GMT) Received: from AMDC2765.digital.local (unknown [106.120.51.73]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200325134210eusmtip23992fc5a59fd6b62f1c8fa0632bdc89d~-j9Mj_BUy0743107431eusmtip2g; Wed, 25 Mar 2020 13:42:10 +0000 (GMT) From: Marek Szyprowski To: u-boot@lists.denx.de Cc: Marek Szyprowski , Joe Hershberger Subject: [PATCH] net: ping: reset stored IP once the command finishes Date: Wed, 25 Mar 2020 14:42:00 +0100 Message-Id: <20200325134200.18959-1-m.szyprowski@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIIsWRmVeSWpSXmKPExsWy7djPc7qb46vjDJ49ELf4tPMxq8XaI3fZ Ld7u7WR3YPY4e2cHo8f1M9uZPPq2rGIMYI7isklJzcksSy3St0vgytiw6T5bwUuOirmrX7I1 MM5g72Lk5JAQMJFo6tgNZHNxCAmsYJTY0fqHBcL5wiix4dd1JgjnM6PErU3nmWBavu6exQqR WM4ocenfHia4liNP5jCDVLEJGEp0ve1iA7FFBCQkfvVfZQSxmQWiJZ4c+csKYgsLuEqcmf4C yObgYBFQlVg2VwfE5BWwlfizPxNil7zE6g0HmEHGSwisYJPY//wZC0TCReLtzqdQtrDEq+Nb oP6RkTg9uYcFoqGZUeLhubXsEE4Po8TlphmMEFXWEnfO/WID2cYsoCmxfpc+RNhR4tnl7WD3 SAjwSdx4KwhxMp/EpG3TmSHCvBIdbUIQ1WoSs46vg1t78MIlZgjbQ+L3+kVgcSGBWIkd65cw T2CUm4WwawEj4ypG8dTS4tz01GKjvNRyveLE3OLSvHS95PzcTYzAiD797/iXHYy7/iQdYhTg YFTi4d1gWR0nxJpYVlyZe4hRgoNZSYR3c2pFnBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXFe40Uv Y4UE0hNLUrNTUwtSi2CyTBycUg2MCvWSsZ/LGJgTr186cCZt0tnDF4tWM6vGT1E/oJkSmvFV ZjpTjo/l8e8zth7qTT9e8U1titoWr6XV7pk8AZLBVrprwy3Mt+XsyM7+YZ1ivM6MpSAv55Vq y/a3rIIHoxmOeqV+310mbBlzWo//1PbQ6VuYJS7y7u7wz9R3COA6vcnPfNp3zxYlluKMREMt 5qLiRACd2Yr55AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGLMWRmVeSWpSXmKPExsVy+t/xe7qb46vjDObcYbP4tPMxq8XaI3fZ Ld7u7WR3YPY4e2cHo8f1M9uZPPq2rGIMYI7SsynKLy1JVcjILy6xVYo2tDDSM7S00DMysdQz NDaPtTIyVdK3s0lJzcksSy3St0vQy9iw6T5bwUuOirmrX7I1MM5g72Lk5JAQMJH4unsWaxcj F4eQwFJGiZ+vlrFCJGQkTk5rgLKFJf5c62KDKPrEKHHn3QsmkASbgKFE11uQBCeHiICExK/+ q4wgNrNAtMT0tr1gcWEBV4kz018ADeLgYBFQlVg2VwfE5BWwlfizPxNivLzE6g0HmCcw8ixg ZFjFKJJaWpybnltspFecmFtcmpeul5yfu4kRGEbbjv3csoOx613wIUYBDkYlHt4NltVxQqyJ ZcWVuYcYJTiYlUR4N6dWxAnxpiRWVqUW5ccXleakFh9iNAVaPZFZSjQ5HxjieSXxhqaG5haW hubG5sZmFkrivB0CB2OEBNITS1KzU1MLUotg+pg4OKUaGB2vXXduCv320z/N7kGT0DdthQN1 ZlK7xe2qAzgeiZ+oN5px5NSzh0LFH1J3lmQuMH7X/CO58WV0gIu2j8df0xvzgtYcErlV0Txv psSeh5GJ+kyLxW4fafzSdqeAu3tSZZtWlcS1a5e4tBmNn9Sel5e06fJOMH1T+jeRTU/waEJT hVjRznxnJZbijERDLeai4kQAialSlzkCAAA= X-CMS-MailID: 20200325134211eucas1p25efcdbfaf6cd1a1088d6eb104e75db19 X-Msg-Generator: CA X-RootMTR: 20200325134211eucas1p25efcdbfaf6cd1a1088d6eb104e75db19 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200325134211eucas1p25efcdbfaf6cd1a1088d6eb104e75db19 References: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean Reset stored ping IP address before leaving the netloop to ensure that the subsequent calls to the netloop, especially for the other protocols, won't be interrupted by the received ICMP_ECHO_REPLY packet. Signed-off-by: Marek Szyprowski --- net/ping.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/ping.c b/net/ping.c index 633c942..d912e3d 100644 --- a/net/ping.c +++ b/net/ping.c @@ -63,6 +63,7 @@ static int ping_send(void) static void ping_timeout_handler(void) { eth_halt(); + net_ping_ip.s_addr = 0; net_set_state(NETLOOP_FAIL); /* we did not get the reply */ } @@ -84,8 +85,10 @@ void ping_receive(struct ethernet_hdr *et, struct ip_udp_hdr *ip, int len) switch (icmph->type) { case ICMP_ECHO_REPLY: src_ip = net_read_ip((void *)&ip->ip_src); - if (src_ip.s_addr == net_ping_ip.s_addr) + if (src_ip.s_addr == net_ping_ip.s_addr) { + net_ping_ip.s_addr = 0; net_set_state(NETLOOP_SUCCESS); + } return; case ICMP_ECHO_REQUEST: eth_hdr_size = net_update_ether(et, et->et_src, PROT_IP);