| Message ID | 20200303023251.30208-1-yangbo.lu@nxp.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Priyanka Jain |
| Headers | show |
| Series | configs: disable eMMC HS200 support on layerscape platforms | expand |
Any comments? Thanks! Best regards, Yangbo Lu > -----Original Message----- > From: Yangbo Lu <yangbo.lu@nxp.com> > Sent: Tuesday, March 3, 2020 10:33 AM > To: u-boot@lists.denx.de; Priyanka Jain <priyanka.jain@nxp.com> > Cc: Y.b. Lu <yangbo.lu@nxp.com> > Subject: [PATCH] configs: disable eMMC HS200 support on layerscape > platforms > > The eMMC HS200 speed mode on Layerscape platforms has not been > supported properly. The eSDHC clock tuning has not been implemented > by now. So disable it until it is supported properly in case of > any potential issues. > > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> > --- > configs/ls1012ardb_tfa_defconfig | 1 - > configs/ls1028ardb_tfa_defconfig | 1 - > configs/lx2160ardb_tfa_defconfig | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/configs/ls1012ardb_tfa_defconfig > b/configs/ls1012ardb_tfa_defconfig > index b47a47d..0e994f5 100644 > --- a/configs/ls1012ardb_tfa_defconfig > +++ b/configs/ls1012ardb_tfa_defconfig > @@ -38,7 +38,6 @@ CONFIG_NET_RANDOM_ETHADDR=y > CONFIG_DM=y > CONFIG_SATA_CEVA=y > CONFIG_DM_MMC=y > -CONFIG_MMC_HS200_SUPPORT=y > CONFIG_FSL_ESDHC=y > CONFIG_MTD=y > CONFIG_DM_SPI_FLASH=y > diff --git a/configs/ls1028ardb_tfa_defconfig > b/configs/ls1028ardb_tfa_defconfig > index 3ef5520..7ffd1c3 100644 > --- a/configs/ls1028ardb_tfa_defconfig > +++ b/configs/ls1028ardb_tfa_defconfig > @@ -45,7 +45,6 @@ CONFIG_I2C_DEFAULT_BUS_NUMBER=0 > CONFIG_I2C_MUX=y > CONFIG_I2C_MUX_PCA954x=y > CONFIG_DM_MMC=y > -CONFIG_MMC_HS200_SUPPORT=y > CONFIG_FSL_ESDHC=y > CONFIG_MTD=y > CONFIG_DM_SPI_FLASH=y > diff --git a/configs/lx2160ardb_tfa_defconfig > b/configs/lx2160ardb_tfa_defconfig > index b998cb6..0799cd4 100644 > --- a/configs/lx2160ardb_tfa_defconfig > +++ b/configs/lx2160ardb_tfa_defconfig > @@ -41,7 +41,6 @@ CONFIG_DM_I2C=y > CONFIG_I2C_SET_DEFAULT_BUS_NUM=y > CONFIG_I2C_DEFAULT_BUS_NUMBER=0 > CONFIG_DM_MMC=y > -CONFIG_MMC_HS200_SUPPORT=y > CONFIG_FSL_ESDHC=y > CONFIG_MTD=y > CONFIG_DM_SPI_FLASH=y > -- > 2.7.4
Hi, On 3/19/20 4:22 PM, Y.b. Lu wrote: > Any comments? > Thanks! > > Best regards, > Yangbo Lu > >> -----Original Message----- >> From: Yangbo Lu <yangbo.lu@nxp.com> >> Sent: Tuesday, March 3, 2020 10:33 AM >> To: u-boot@lists.denx.de; Priyanka Jain <priyanka.jain@nxp.com> >> Cc: Y.b. Lu <yangbo.lu@nxp.com> >> Subject: [PATCH] configs: disable eMMC HS200 support on layerscape >> platforms >> >> The eMMC HS200 speed mode on Layerscape platforms has not been >> supported properly. The eSDHC clock tuning has not been implemented >> by now. So disable it until it is supported properly in case of >> any potential issues. If it's not working fine, looks good to me. BTW, I didn't have tested on its platform. Do you have a plan to fix it? Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> >> >> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> >> --- >> configs/ls1012ardb_tfa_defconfig | 1 - >> configs/ls1028ardb_tfa_defconfig | 1 - >> configs/lx2160ardb_tfa_defconfig | 1 - >> 3 files changed, 3 deletions(-) >> >> diff --git a/configs/ls1012ardb_tfa_defconfig >> b/configs/ls1012ardb_tfa_defconfig >> index b47a47d..0e994f5 100644 >> --- a/configs/ls1012ardb_tfa_defconfig >> +++ b/configs/ls1012ardb_tfa_defconfig >> @@ -38,7 +38,6 @@ CONFIG_NET_RANDOM_ETHADDR=y >> CONFIG_DM=y >> CONFIG_SATA_CEVA=y >> CONFIG_DM_MMC=y >> -CONFIG_MMC_HS200_SUPPORT=y >> CONFIG_FSL_ESDHC=y >> CONFIG_MTD=y >> CONFIG_DM_SPI_FLASH=y >> diff --git a/configs/ls1028ardb_tfa_defconfig >> b/configs/ls1028ardb_tfa_defconfig >> index 3ef5520..7ffd1c3 100644 >> --- a/configs/ls1028ardb_tfa_defconfig >> +++ b/configs/ls1028ardb_tfa_defconfig >> @@ -45,7 +45,6 @@ CONFIG_I2C_DEFAULT_BUS_NUMBER=0 >> CONFIG_I2C_MUX=y >> CONFIG_I2C_MUX_PCA954x=y >> CONFIG_DM_MMC=y >> -CONFIG_MMC_HS200_SUPPORT=y >> CONFIG_FSL_ESDHC=y >> CONFIG_MTD=y >> CONFIG_DM_SPI_FLASH=y >> diff --git a/configs/lx2160ardb_tfa_defconfig >> b/configs/lx2160ardb_tfa_defconfig >> index b998cb6..0799cd4 100644 >> --- a/configs/lx2160ardb_tfa_defconfig >> +++ b/configs/lx2160ardb_tfa_defconfig >> @@ -41,7 +41,6 @@ CONFIG_DM_I2C=y >> CONFIG_I2C_SET_DEFAULT_BUS_NUM=y >> CONFIG_I2C_DEFAULT_BUS_NUMBER=0 >> CONFIG_DM_MMC=y >> -CONFIG_MMC_HS200_SUPPORT=y >> CONFIG_FSL_ESDHC=y >> CONFIG_MTD=y >> CONFIG_DM_SPI_FLASH=y >> -- >> 2.7.4 > > >
Hi Jaehoon, > -----Original Message----- > From: Jaehoon Chung <jh80.chung@samsung.com> > Sent: Thursday, March 19, 2020 5:01 PM > To: Y.b. Lu <yangbo.lu@nxp.com>; u-boot@lists.denx.de; Priyanka Jain > <priyanka.jain@nxp.com> > Subject: Re: [PATCH] configs: disable eMMC HS200 support on layerscape > platforms > > Hi, > > On 3/19/20 4:22 PM, Y.b. Lu wrote: > > Any comments? > > Thanks! > > > > Best regards, > > Yangbo Lu > > > >> -----Original Message----- > >> From: Yangbo Lu <yangbo.lu@nxp.com> > >> Sent: Tuesday, March 3, 2020 10:33 AM > >> To: u-boot@lists.denx.de; Priyanka Jain <priyanka.jain@nxp.com> > >> Cc: Y.b. Lu <yangbo.lu@nxp.com> > >> Subject: [PATCH] configs: disable eMMC HS200 support on layerscape > >> platforms > >> > >> The eMMC HS200 speed mode on Layerscape platforms has not been > >> supported properly. The eSDHC clock tuning has not been implemented > >> by now. So disable it until it is supported properly in case of > >> any potential issues. > > > If it's not working fine, looks good to me. > BTW, I didn't have tested on its platform. Do you have a plan to fix it? [Yangbo Lu] Because we got issues with HS200 mode in testing, I sent this patch to disable it for now. The tuning support with eSDHC tuning block is in my plan. Thanks. > > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> > > > >> > >> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> > >> --- > >> configs/ls1012ardb_tfa_defconfig | 1 - > >> configs/ls1028ardb_tfa_defconfig | 1 - > >> configs/lx2160ardb_tfa_defconfig | 1 - > >> 3 files changed, 3 deletions(-) > >> > >> diff --git a/configs/ls1012ardb_tfa_defconfig > >> b/configs/ls1012ardb_tfa_defconfig > >> index b47a47d..0e994f5 100644 > >> --- a/configs/ls1012ardb_tfa_defconfig > >> +++ b/configs/ls1012ardb_tfa_defconfig > >> @@ -38,7 +38,6 @@ CONFIG_NET_RANDOM_ETHADDR=y > >> CONFIG_DM=y > >> CONFIG_SATA_CEVA=y > >> CONFIG_DM_MMC=y > >> -CONFIG_MMC_HS200_SUPPORT=y > >> CONFIG_FSL_ESDHC=y > >> CONFIG_MTD=y > >> CONFIG_DM_SPI_FLASH=y > >> diff --git a/configs/ls1028ardb_tfa_defconfig > >> b/configs/ls1028ardb_tfa_defconfig > >> index 3ef5520..7ffd1c3 100644 > >> --- a/configs/ls1028ardb_tfa_defconfig > >> +++ b/configs/ls1028ardb_tfa_defconfig > >> @@ -45,7 +45,6 @@ CONFIG_I2C_DEFAULT_BUS_NUMBER=0 > >> CONFIG_I2C_MUX=y > >> CONFIG_I2C_MUX_PCA954x=y > >> CONFIG_DM_MMC=y > >> -CONFIG_MMC_HS200_SUPPORT=y > >> CONFIG_FSL_ESDHC=y > >> CONFIG_MTD=y > >> CONFIG_DM_SPI_FLASH=y > >> diff --git a/configs/lx2160ardb_tfa_defconfig > >> b/configs/lx2160ardb_tfa_defconfig > >> index b998cb6..0799cd4 100644 > >> --- a/configs/lx2160ardb_tfa_defconfig > >> +++ b/configs/lx2160ardb_tfa_defconfig > >> @@ -41,7 +41,6 @@ CONFIG_DM_I2C=y > >> CONFIG_I2C_SET_DEFAULT_BUS_NUM=y > >> CONFIG_I2C_DEFAULT_BUS_NUMBER=0 > >> CONFIG_DM_MMC=y > >> -CONFIG_MMC_HS200_SUPPORT=y > >> CONFIG_FSL_ESDHC=y > >> CONFIG_MTD=y > >> CONFIG_DM_SPI_FLASH=y > >> -- > >> 2.7.4 > > > > > >
>-----Original Message----- >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Yangbo Lu >Sent: Tuesday, March 3, 2020 8:03 AM >To: u-boot@lists.denx.de; Priyanka Jain <priyanka.jain@nxp.com> >Cc: Y.b. Lu <yangbo.lu@nxp.com> >Subject: [PATCH] configs: disable eMMC HS200 support on layerscape >platforms > >The eMMC HS200 speed mode on Layerscape platforms has not been >supported properly. The eSDHC clock tuning has not been implemented by >now. So disable it until it is supported properly in case of any potential >issues. > >Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> >--- Applied to u-boot-fsl-qoriq after rebasing. Waiting upstream Thanks Priyanka
diff --git a/configs/ls1012ardb_tfa_defconfig b/configs/ls1012ardb_tfa_defconfig index b47a47d..0e994f5 100644 --- a/configs/ls1012ardb_tfa_defconfig +++ b/configs/ls1012ardb_tfa_defconfig @@ -38,7 +38,6 @@ CONFIG_NET_RANDOM_ETHADDR=y CONFIG_DM=y CONFIG_SATA_CEVA=y CONFIG_DM_MMC=y -CONFIG_MMC_HS200_SUPPORT=y CONFIG_FSL_ESDHC=y CONFIG_MTD=y CONFIG_DM_SPI_FLASH=y diff --git a/configs/ls1028ardb_tfa_defconfig b/configs/ls1028ardb_tfa_defconfig index 3ef5520..7ffd1c3 100644 --- a/configs/ls1028ardb_tfa_defconfig +++ b/configs/ls1028ardb_tfa_defconfig @@ -45,7 +45,6 @@ CONFIG_I2C_DEFAULT_BUS_NUMBER=0 CONFIG_I2C_MUX=y CONFIG_I2C_MUX_PCA954x=y CONFIG_DM_MMC=y -CONFIG_MMC_HS200_SUPPORT=y CONFIG_FSL_ESDHC=y CONFIG_MTD=y CONFIG_DM_SPI_FLASH=y diff --git a/configs/lx2160ardb_tfa_defconfig b/configs/lx2160ardb_tfa_defconfig index b998cb6..0799cd4 100644 --- a/configs/lx2160ardb_tfa_defconfig +++ b/configs/lx2160ardb_tfa_defconfig @@ -41,7 +41,6 @@ CONFIG_DM_I2C=y CONFIG_I2C_SET_DEFAULT_BUS_NUM=y CONFIG_I2C_DEFAULT_BUS_NUMBER=0 CONFIG_DM_MMC=y -CONFIG_MMC_HS200_SUPPORT=y CONFIG_FSL_ESDHC=y CONFIG_MTD=y CONFIG_DM_SPI_FLASH=y
The eMMC HS200 speed mode on Layerscape platforms has not been supported properly. The eSDHC clock tuning has not been implemented by now. So disable it until it is supported properly in case of any potential issues. Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> --- configs/ls1012ardb_tfa_defconfig | 1 - configs/ls1028ardb_tfa_defconfig | 1 - configs/lx2160ardb_tfa_defconfig | 1 - 3 files changed, 3 deletions(-)