diff mbox series

[v1,5/5] arm: xea: dts: Add 'fec-3v3' regulator properties to prevent accidental disablement

Message ID 20200125080140.1267-6-lukma@denx.de
State Accepted
Commit a05eb8b14a46fd194caf2ae2c01e3a3431daab3e
Delegated to: Stefano Babic
Headers show
Series arm: xea: Enhancements for i.MX28 based XEA board | expand

Commit Message

Lukasz Majewski Jan. 25, 2020, 8:01 a.m. UTC 
The 'enable-active-high' DTS property configures GPIO so it is active with
HIGH state (by default it is low).

The 'regulator-boot-on' property indicates that the regulator was enabled
in the 'earlier' stage - i.e. bootloader/firmware.
In the XEA case the 'fec-3v3' was configured (as a "wrapper" on GPIO0_0) in
very early SPL code, so it shouldn't be modified at latter stages.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---

 arch/arm/dts/imx28-xea.dts | 2 ++
 1 file changed, 2 insertions(+)

Comments

Stefano Babic Feb. 10, 2020, 9:07 a.m. UTC | #1 
> The 'enable-active-high' DTS property configures GPIO so it is active with
> HIGH state (by default it is low).
> The 'regulator-boot-on' property indicates that the regulator was enabled
> in the 'earlier' stage - i.e. bootloader/firmware.
> In the XEA case the 'fec-3v3' was configured (as a "wrapper" on GPIO0_0) in
> very early SPL code, so it shouldn't be modified at latter stages.
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/arch/arm/dts/imx28-xea.dts b/arch/arm/dts/imx28-xea.dts
index 5de6774c5a..de049042f8 100644
--- a/arch/arm/dts/imx28-xea.dts
+++ b/arch/arm/dts/imx28-xea.dts
@@ -38,6 +38,8 @@ 
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 		gpio = <&gpio0 0 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+		regulator-boot-on;
 	};
 };