diff mbox series

Output information about device look up failure.

Message ID 20200121221005.9303-1-coffe92@gmail.com
State New
Delegated to: Tom Rini
Headers show
Series Output information about device look up failure. | expand

Commit Message

Nikita Ermakov Jan. 21, 2020, 10:10 p.m. UTC
In the case of error while device look up (e.g. wrong interface type
was specified) put a message about it even if debug was not enable.

Signed-off-by: Nikita Ermakov <coffe92@gmail.com>
---
 disk/part.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Wolfgang Denk Jan. 22, 2020, 12:05 p.m. UTC | #1
Dear Nikita,

In message <20200121221005.9303-1-coffe92@gmail.com> you wrote:
> In the case of error while device look up (e.g. wrong interface type
> was specified) put a message about it even if debug was not enable.
>
> Signed-off-by: Nikita Ermakov <coffe92@gmail.com>
> ---
>  disk/part.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/disk/part.c b/disk/part.c
> index 8982ef3bae..280e3e4f42 100644
> --- a/disk/part.c
> +++ b/disk/part.c
> @@ -513,7 +513,10 @@ int blk_get_device_part_str(const char *ifname, const char *dev_part_str,
>  	/* Look up the device */
>  	dev = blk_get_device_by_str(ifname, dev_str, dev_desc);
>  	if (dev < 0)
> +	{
> +		printf("** Look up for the device %s %s failed **\n", ifname, dev_str);
>  		goto cleanup;
> +	}

Please see my other patch instead.

You are using incorrect brace style, and I think your error message
is a bit misleading - "look up failed" sounds like some internal
error, the reason of which is still unclear.  We should instead say
clearly the the given device type is not supported/known in the
given configuration.

Thanks.

Best regards,

Wolfgang Denk
diff mbox series

Patch

diff --git a/disk/part.c b/disk/part.c
index 8982ef3bae..280e3e4f42 100644
--- a/disk/part.c
+++ b/disk/part.c
@@ -513,7 +513,10 @@  int blk_get_device_part_str(const char *ifname, const char *dev_part_str,
 	/* Look up the device */
 	dev = blk_get_device_by_str(ifname, dev_str, dev_desc);
 	if (dev < 0)
+	{
+		printf("** Look up for the device %s %s failed **\n", ifname, dev_str);
 		goto cleanup;
+	}
 
 	/* Convert partition ID string to number */
 	if (!part_str || !*part_str) {