| Message ID | 20191221011037.143972-2-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | 512563ba0b97ab3546d7c43211d158f1f50f38ad |
| Delegated to: | Anatolij Gustschin |
| Headers | show |
| Series | video: Avoid #ifdef to increase build coverage | expand |
Hi Anatolij, On Thu, 2 Jan 2020 at 07:34, Anatolij Gustschin <agust@denx.de> wrote: > > Hi Simon, > > On Fri, 20 Dec 2019 18:10:33 -0700 > Simon Glass sjg@chromium.org wrote: > > > Most x86 boards that use video make use of 32bpp graphics. Enable this by > > default. This fixes missing graphics output on some x86 boards. > > Must this patch be applied for v2010.01 release? I think so since these boards don't work for me at present. What do you think, Bin? Regards, SImon
Hi Simon, On Fri, Jan 3, 2020 at 10:30 AM Simon Glass <sjg@chromium.org> wrote: > > Hi Anatolij, > > On Thu, 2 Jan 2020 at 07:34, Anatolij Gustschin <agust@denx.de> wrote: > > > > Hi Simon, > > > > On Fri, 20 Dec 2019 18:10:33 -0700 > > Simon Glass sjg@chromium.org wrote: > > > > > Most x86 boards that use video make use of 32bpp graphics. Enable this by > > > default. This fixes missing graphics output on some x86 boards. > > > > Must this patch be applied for v2010.01 release? > > I think so since these boards don't work for me at present. > > What do you think, Bin? > Which board is currently broken due to missing this config? Should it be safer to move this to board defconfig? Regards, Bin
Hi Bin, On Thu, 2 Jan 2020 at 19:41, Bin Meng <bmeng.cn@gmail.com> wrote: > > Hi Simon, > > On Fri, Jan 3, 2020 at 10:30 AM Simon Glass <sjg@chromium.org> wrote: > > > > Hi Anatolij, > > > > On Thu, 2 Jan 2020 at 07:34, Anatolij Gustschin <agust@denx.de> wrote: > > > > > > Hi Simon, > > > > > > On Fri, 20 Dec 2019 18:10:33 -0700 > > > Simon Glass sjg@chromium.org wrote: > > > > > > > Most x86 boards that use video make use of 32bpp graphics. Enable this by > > > > default. This fixes missing graphics output on some x86 boards. > > > > > > Must this patch be applied for v2010.01 release? > > > > I think so since these boards don't work for me at present. > > > > What do you think, Bin? > > > > Which board is currently broken due to missing this config? Should it > be safer to move this to board defconfig? I think any x86 board with graphics would need this. Those that don't enable VIDEO won't get the change anyway. Regards, Simon
Hi Simon, On Fri, Jan 3, 2020 at 11:24 AM Simon Glass <sjg@chromium.org> wrote: > > Hi Bin, > > On Thu, 2 Jan 2020 at 19:41, Bin Meng <bmeng.cn@gmail.com> wrote: > > > > Hi Simon, > > > > On Fri, Jan 3, 2020 at 10:30 AM Simon Glass <sjg@chromium.org> wrote: > > > > > > Hi Anatolij, > > > > > > On Thu, 2 Jan 2020 at 07:34, Anatolij Gustschin <agust@denx.de> wrote: > > > > > > > > Hi Simon, > > > > > > > > On Fri, 20 Dec 2019 18:10:33 -0700 > > > > Simon Glass sjg@chromium.org wrote: > > > > > > > > > Most x86 boards that use video make use of 32bpp graphics. Enable this by > > > > > default. This fixes missing graphics output on some x86 boards. > > > > > > > > Must this patch be applied for v2010.01 release? > > > > > > I think so since these boards don't work for me at present. > > > > > > What do you think, Bin? > > > > > > > Which board is currently broken due to missing this config? Should it > > be safer to move this to board defconfig? > > I think any x86 board with graphics would need this. Those that don't > enable VIDEO won't get the change anyway. OK, thanks. I had a test with QEMU x86 and looks good. Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Tested-by: Bin Meng <bmeng.cn@gmail.com> Regards, Bin
Hi all, On Fri, 3 Jan 2020 23:41:49 +0800 Bin Meng bmeng.cn@gmail.com wrote: > Hi Simon, > > On Fri, Jan 3, 2020 at 11:24 AM Simon Glass <sjg@chromium.org> wrote: > > > > Hi Bin, > > > > On Thu, 2 Jan 2020 at 19:41, Bin Meng <bmeng.cn@gmail.com> wrote: > > > > > > Hi Simon, > > > > > > On Fri, Jan 3, 2020 at 10:30 AM Simon Glass <sjg@chromium.org> wrote: > > > > > > > > Hi Anatolij, > > > > > > > > On Thu, 2 Jan 2020 at 07:34, Anatolij Gustschin <agust@denx.de> wrote: > > > > > > > > > > Hi Simon, > > > > > > > > > > On Fri, 20 Dec 2019 18:10:33 -0700 > > > > > Simon Glass sjg@chromium.org wrote: > > > > > > > > > > > Most x86 boards that use video make use of 32bpp graphics. Enable this by > > > > > > default. This fixes missing graphics output on some x86 boards. > > > > > > > > > > Must this patch be applied for v2010.01 release? > > > > > > > > I think so since these boards don't work for me at present. > > > > > > > > What do you think, Bin? > > > > > > > > > > Which board is currently broken due to missing this config? Should it > > > be safer to move this to board defconfig? > > > > I think any x86 board with graphics would need this. Those that don't > > enable VIDEO won't get the change anyway. > > OK, thanks. I had a test with QEMU x86 and looks good. > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > Tested-by: Bin Meng <bmeng.cn@gmail.com> Thanks for testing. I've submitted a pull request for this series and Tom already merged the patches in master. -- Anatolij
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 4cde0acbf6..50ab3650ee 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -38,7 +38,6 @@ config BACKLIGHT_GPIO config VIDEO_BPP8 bool "Support 8-bit-per-pixel displays" depends on DM_VIDEO - default n help Support drawing text and bitmaps onto a 8-bit-per-pixel display. Enabling this will include code to support this display. Without @@ -48,7 +47,6 @@ config VIDEO_BPP8 config VIDEO_BPP16 bool "Support 16-bit-per-pixel displays" depends on DM_VIDEO - default n help Support drawing text and bitmaps onto a 16-bit-per-pixel display. Enabling this will include code to support this display. Without @@ -58,7 +56,7 @@ config VIDEO_BPP16 config VIDEO_BPP32 bool "Support 32-bit-per-pixel displays" depends on DM_VIDEO - default n + default y if X86 help Support drawing text and bitmaps onto a 32-bit-per-pixel display. Enabling this will include code to support this display. Without @@ -68,7 +66,6 @@ config VIDEO_BPP32 config VIDEO_ANSI bool "Support ANSI escape sequences in video console" depends on DM_VIDEO - default n help Enable ANSI escape sequence decoding for a more fully functional console.
Most x86 boards that use video make use of 32bpp graphics. Enable this by default. This fixes missing graphics output on some x86 boards. Also remove the unnecessary 'default n' while we are here. Signed-off-by: Simon Glass <sjg@chromium.org> --- drivers/video/Kconfig | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)