diff mbox series

[3/3] mx6slevk: Fix the pmic_get() parameter in the DM case

Message ID 20191220175928.13195-3-festevam@gmail.com
State Accepted
Commit 08b72863d7908703206773fe9338c9e2f493acdf
Delegated to: Stefano Babic
Headers show
Series [1/3] mx7dsabresd: Fix the pmic_get() parameter in the DM case | expand

Commit Message

Fabio Estevam Dec. 20, 2019, 5:59 p.m. UTC
When pmic_get() is used with DM the first parameter must be
the complete node name plus the unit address, so fix it
accordingly.

Reported-by: Igor Opaniuk <igor.opaniuk@toradex.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 board/freescale/mx6slevk/mx6slevk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peng Fan Dec. 23, 2019, 6:47 a.m. UTC | #1
> Subject: [PATCH 3/3] mx6slevk: Fix the pmic_get() parameter in the DM case
> 
> When pmic_get() is used with DM the first parameter must be the complete
> node name plus the unit address, so fix it accordingly.
> 
> Reported-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  board/freescale/mx6slevk/mx6slevk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/freescale/mx6slevk/mx6slevk.c
> b/board/freescale/mx6slevk/mx6slevk.c
> index 33ae91c307..453f281418 100644
> --- a/board/freescale/mx6slevk/mx6slevk.c
> +++ b/board/freescale/mx6slevk/mx6slevk.c
> @@ -145,7 +145,7 @@ int power_init_board(void)
>  	u32 switch_num = 6;
>  	u32 offset = PFUZE100_SW1CMODE;
> 
> -	ret = pmic_get("pfuze100", &dev);
> +	ret = pmic_get("pfuze100@08", &dev);
>  	if (ret == -ENODEV)
>  		return 0;
> 
> --
> 2.17.1
Stefano Babic Jan. 4, 2020, 11:03 a.m. UTC | #2
> When pmic_get() is used with DM the first parameter must be
> the complete node name plus the unit address, so fix it
> accordingly.
> Reported-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, -next, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/freescale/mx6slevk/mx6slevk.c b/board/freescale/mx6slevk/mx6slevk.c
index 33ae91c307..453f281418 100644
--- a/board/freescale/mx6slevk/mx6slevk.c
+++ b/board/freescale/mx6slevk/mx6slevk.c
@@ -145,7 +145,7 @@  int power_init_board(void)
 	u32 switch_num = 6;
 	u32 offset = PFUZE100_SW1CMODE;
 
-	ret = pmic_get("pfuze100", &dev);
+	ret = pmic_get("pfuze100@08", &dev);
 	if (ret == -ENODEV)
 		return 0;