diff mbox series

[1/3] mx7dsabresd: Fix the pmic_get() parameter in the DM case

Message ID 20191220175928.13195-1-festevam@gmail.com
State Accepted
Commit cb14a5bf661b83ba715b07268439fb7e3c054c16
Delegated to: Stefano Babic
Headers show
Series [1/3] mx7dsabresd: Fix the pmic_get() parameter in the DM case | expand

Commit Message

Fabio Estevam Dec. 20, 2019, 5:59 p.m. UTC
When pmic_get() is used with DM the first parameter must be
the complete node name plus the unit address, so fix it
accordingly.

Reported-by: Igor Opaniuk <igor.opaniuk@toradex.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 board/freescale/mx7dsabresd/mx7dsabresd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peng Fan Dec. 23, 2019, 6:47 a.m. UTC | #1
> Subject: [PATCH 1/3] mx7dsabresd: Fix the pmic_get() parameter in the DM
> case
> 
> When pmic_get() is used with DM the first parameter must be the complete
> node name plus the unit address, so fix it accordingly.
> 
> Reported-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  board/freescale/mx7dsabresd/mx7dsabresd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c
> b/board/freescale/mx7dsabresd/mx7dsabresd.c
> index f1120d67e3..05cf8c8c7c 100644
> --- a/board/freescale/mx7dsabresd/mx7dsabresd.c
> +++ b/board/freescale/mx7dsabresd/mx7dsabresd.c
> @@ -326,7 +326,7 @@ int power_init_board(void)
>  	struct udevice *dev;
>  	int ret, dev_id, rev_id;
> 
> -	ret = pmic_get("pfuze3000", &dev);
> +	ret = pmic_get("pfuze3000@08", &dev);
>  	if (ret == -ENODEV)
>  		return 0;
>  	if (ret != 0)
> --
> 2.17.1
Stefano Babic Jan. 4, 2020, 11:03 a.m. UTC | #2
> When pmic_get() is used with DM the first parameter must be
> the complete node name plus the unit address, so fix it
> accordingly.
> Reported-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, -next, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c b/board/freescale/mx7dsabresd/mx7dsabresd.c
index f1120d67e3..05cf8c8c7c 100644
--- a/board/freescale/mx7dsabresd/mx7dsabresd.c
+++ b/board/freescale/mx7dsabresd/mx7dsabresd.c
@@ -326,7 +326,7 @@  int power_init_board(void)
 	struct udevice *dev;
 	int ret, dev_id, rev_id;
 
-	ret = pmic_get("pfuze3000", &dev);
+	ret = pmic_get("pfuze3000@08", &dev);
 	if (ret == -ENODEV)
 		return 0;
 	if (ret != 0)