diff mbox series

cmd/blk_common: clarify no partition error message

Message ID 20191220142522.2594146-1-alexandre.besnard@softathome.com
State Accepted
Commit 45e4968e741440594d24137b3978c5fff52a025e
Delegated to: Tom Rini
Headers show
Series cmd/blk_common: clarify no partition error message | expand

Commit Message

Alexandre Besnard Dec. 20, 2019, 2:25 p.m. UTC
When no partition table is found, users should be warned so.
Warning that no device is available in this case could be misleading,
especially as it is the same error when no device is selected.

Signed-off-by: Alexandre Besnard <alexandre.besnard@softathome.com>
---
 cmd/blk_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--
2.24.1

Comments

Tom Rini Jan. 16, 2020, 2:41 p.m. UTC | #1
On Fri, Dec 20, 2019 at 03:25:22PM +0100, Alexandre Besnard wrote:

> When no partition table is found, users should be warned so.
> Warning that no device is available in this case could be misleading,
> especially as it is the same error when no device is selected.
> 
> Signed-off-by: Alexandre Besnard <alexandre.besnard@softathome.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/cmd/blk_common.c b/cmd/blk_common.c
index c5514cf8f8..cc6e161ba0 100644
--- a/cmd/blk_common.c
+++ b/cmd/blk_common.c
@@ -32,7 +32,8 @@  int blk_common_cmd(int argc, char * const argv[], enum if_type if_type,
 			return 0;
 		} else if (strncmp(argv[1], "part", 4) == 0) {
 			if (blk_list_part(if_type))
-				printf("\nno %s devices available\n", if_name);
+				printf("\nno %s partition table available\n",
+				       if_name);
 			return 0;
 		}
 		return CMD_RET_USAGE;