| Message ID | 20191209202609.39379-1-michael.auchter@ni.com |
|---|---|
| State | Accepted |
| Commit | b4f98b3b16ec513f7fa6b97ec49792a5e99ec165 |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | cros_ec: use uint instead of uint8_t for cmd param | expand |
On Mon, 9 Dec 2019 at 13:27, Michael Auchter <michael.auchter@ni.com> wrote: > > Chromium EC commands can be up to 16-bits, so using a uint8_t here can > cause truncation. Update to use a uint instead. > > It looks like this should likely have been done as a part of > 9fea76f5d30264dc08ac591a7a89427b8441555b, but this function was skipped > for some reason. > > Signed-off-by: Michael Auchter <michael.auchter@ni.com> > Cc: Simon Glass <sjg@chromium.org> > --- > drivers/misc/cros_ec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/drivers/misc/cros_ec.c b/drivers/misc/cros_ec.c index 3b6370a6d5..3332c1c8a5 100644 --- a/drivers/misc/cros_ec.c +++ b/drivers/misc/cros_ec.c @@ -316,7 +316,7 @@ static int send_command(struct cros_ec_dev *dev, uint cmd, int cmd_version, * @param din_len Maximum size of response in bytes * @return number of bytes in response, or -ve on error */ -static int ec_command_inptr(struct udevice *dev, uint8_t cmd, +static int ec_command_inptr(struct udevice *dev, uint cmd, int cmd_version, const void *dout, int dout_len, uint8_t **dinp, int din_len) {
Chromium EC commands can be up to 16-bits, so using a uint8_t here can cause truncation. Update to use a uint instead. It looks like this should likely have been done as a part of 9fea76f5d30264dc08ac591a7a89427b8441555b, but this function was skipped for some reason. Signed-off-by: Michael Auchter <michael.auchter@ni.com> Cc: Simon Glass <sjg@chromium.org> --- drivers/misc/cros_ec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)