diff mbox series

[06/20] clk: imx: pllv3: add disable() support

Message ID 20191204174439.69934-7-giulio.benetti@benettiengineering.com
State Changes Requested
Delegated to: Stefano Babic
Headers show
Series Add i.MXRT family support | expand

Commit Message

Giulio Benetti Dec. 4, 2019, 5:44 p.m. UTC
Add disable() support.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 drivers/clk/imx/clk-pllv3.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Lukasz Majewski Dec. 8, 2019, 2:27 p.m. UTC | #1
On Wed,  4 Dec 2019 18:44:25 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Add disable() support.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  drivers/clk/imx/clk-pllv3.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c
> index d8cbe3dd4e..9b37cd9cd9 100644
> --- a/drivers/clk/imx/clk-pllv3.c
> +++ b/drivers/clk/imx/clk-pllv3.c
> @@ -54,9 +54,25 @@ static int clk_pllv3_generic_enable(struct clk
> *clk) return 0;
>  }
>  
> +static int clk_pllv3_generic_disable(struct clk *clk)
> +{
> +	struct clk_pllv3 *pll = to_clk_pllv3(clk);
> +	u32 val;
> +
> +	val = readl(pll->base);
> +	if (pll->powerup_set)
> +		val &= ~pll->power_bit;
> +	else
> +		val |= pll->power_bit;
> +	writel(val, pll->base);
> +
> +	return 0;
> +}
> +
>  static const struct clk_ops clk_pllv3_generic_ops = {
>  	.get_rate	= clk_pllv3_generic_get_rate,
>  	.enable		= clk_pllv3_generic_enable,
> +	.disable	= clk_pllv3_generic_disable,
>  };
>  
>  struct clk *imx_clk_pllv3(enum imx_pllv3_type type, const char *name,

Reviewed-by: Lukasz Majewski <lukma@denx.de>

Thanks for adding this code to U-Boot.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff mbox series

Patch

diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c
index d8cbe3dd4e..9b37cd9cd9 100644
--- a/drivers/clk/imx/clk-pllv3.c
+++ b/drivers/clk/imx/clk-pllv3.c
@@ -54,9 +54,25 @@  static int clk_pllv3_generic_enable(struct clk *clk)
 	return 0;
 }
 
+static int clk_pllv3_generic_disable(struct clk *clk)
+{
+	struct clk_pllv3 *pll = to_clk_pllv3(clk);
+	u32 val;
+
+	val = readl(pll->base);
+	if (pll->powerup_set)
+		val &= ~pll->power_bit;
+	else
+		val |= pll->power_bit;
+	writel(val, pll->base);
+
+	return 0;
+}
+
 static const struct clk_ops clk_pllv3_generic_ops = {
 	.get_rate	= clk_pllv3_generic_get_rate,
 	.enable		= clk_pllv3_generic_enable,
+	.disable	= clk_pllv3_generic_disable,
 };
 
 struct clk *imx_clk_pllv3(enum imx_pllv3_type type, const char *name,