From patchwork Sun Nov 24 20:37:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 1200003 X-Patchwork-Delegate: agust@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WA6QIrli"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 47Lhnm2pQcz9sPc for ; Mon, 25 Nov 2019 07:38:18 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 161CAC21DA6; Sun, 24 Nov 2019 20:38:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 9A1A9C21C4A; Sun, 24 Nov 2019 20:38:07 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 9A74AC21C4A; Sun, 24 Nov 2019 20:38:05 +0000 (UTC) Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by lists.denx.de (Postfix) with ESMTPS id 21E1AC21BE5 for ; Sun, 24 Nov 2019 20:38:05 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id y10so14828867qto.3 for ; Sun, 24 Nov 2019 12:38:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ehboPjs37ygxQO9zBiCnAPrZoMvtrQyqSKJKEU75UyA=; b=WA6QIrlisI8LFzor1LlI8TxdKXZdncCMdrnZ8hmwosFPuRgdIaOCzMKACpdSH8Vpju oCtNaHg9MGRp7PCLSWXREOj4zak/aFuCe+eZRqu38vBQlOKDBOtISfVP09l2fWSIjG9S jkt3byPEhP6rFu7rGTqSgx1zXo3aFxCb1RzjClJEQD1GJdhVkwrmPAtjMiy4ZMBVsa92 0Y9d/lGaGADqAX9AQD4HogKiRpcc8c69GBvVHCo/w9vqAxmYDjoW7WaAI23aEdC6i7Rb xHGjin6uuFipmLJwgYmakHkIAi4Z8Wq2tJtvD1CFtGBOb4Drue4mxVWqajA+9rfWOTyC fpkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ehboPjs37ygxQO9zBiCnAPrZoMvtrQyqSKJKEU75UyA=; b=tYjDZzj860xhfRcleVeEhbPi1ClLM3w5i/KEQRINfSMC7JJE5e+yIItP9QmtglYKoG li7qcixJlUC3ZmO6LrkD/DYdqw29un6A7p+zTiidEkth/2zzcB2wmU3mMlPMyO6IAvGM ngw9z8PzrEBCew4navkGSvCyupSrzpIkBFDEociMMmzqp4cbawAn25q0lRM3otj2LTtB sM+G0sgLwPOdAb3GcdrYmBsC2PbzQb7kTcHEZdN3b+pAIbnFHLxJCCNmANynG3dwXKvt Q5Q8r0v+S5EJVJp4x5SkIXBbcDBqEwfCaDjopgis7lEQDRF5nQQDqMkcYA4u32sIm1MI nV4w== X-Gm-Message-State: APjAAAUGYWbnN9Cru3d9WzZVc/+K+Xt7kkEXpFiT7nmARlqcr8tW0TRR cXbuf83F0FGDm02RVqzngmc= X-Google-Smtp-Source: APXvYqxtfqmSDbhoeZaOga+OhBJKxjamE26Q4ZrL6cfyqeM1Lcypne66zAcWB/4V30vQPzfhVhvd1g== X-Received: by 2002:aed:3762:: with SMTP id i89mr25850702qtb.69.1574627883716; Sun, 24 Nov 2019 12:38:03 -0800 (PST) Received: from localhost.localdomain ([2804:14c:482:99:1a50:482f:3e7:284a]) by smtp.gmail.com with ESMTPSA id y15sm2268262qka.6.2019.11.24.12.38.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Nov 2019 12:38:02 -0800 (PST) From: Fabio Estevam To: agust@denx.de Date: Sun, 24 Nov 2019 17:37:52 -0300 Message-Id: <20191124203752.24172-1-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 Cc: u-boot@lists.denx.de Subject: [U-Boot] [PATCH] Revert "video: mxsfb: Configure the clock after eLCDIF reset" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Commit ec3dcea74470 ("video: mxsfb: Configure the clock after eLCDIF reset") causes boot regression on imx7d-pico/imx7d-sdb boards, so revert it until a better solution is prepared. This reverts commit ec3dcea7447031463643c33143b3a5f027f0b54d. Reported-by: Joris Offouga Signed-off-by: Fabio Estevam --- drivers/video/mxsfb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index d73a8bac99..c52981053e 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -57,6 +57,9 @@ static void mxs_lcd_init(u32 fb_addr, struct ctfb_res_modes *mode, int bpp) uint32_t word_len = 0, bus_width = 0; uint8_t valid_data = 0; + /* Kick in the LCDIF clock */ + mxs_set_lcdclk(MXS_LCDIF_BASE, PS2KHZ(mode->pixclock)); + /* Restart the LCDIF block */ mxs_reset_block(®s->hw_lcdif_ctrl_reg); @@ -127,9 +130,6 @@ static void mxs_lcd_init(u32 fb_addr, struct ctfb_res_modes *mode, int bpp) /* FIFO cleared */ writel(LCDIF_CTRL1_FIFO_CLEAR, ®s->hw_lcdif_ctrl1_clr); - /* Kick in the LCDIF clock */ - mxs_set_lcdclk(MXS_LCDIF_BASE, PS2KHZ(mode->pixclock)); - /* RUN! */ writel(LCDIF_CTRL_RUN, ®s->hw_lcdif_ctrl_set); }