| Message ID | 20191114103641.34085-7-biwen.li@nxp.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Priyanka Jain |
| Headers | show |
| Series | [U-Boot,01/42] configs: ls1012a: enable CONFIG_DM_I2C | expand |
>-----Original Message----- >From: Biwen Li <biwen.li@nxp.com> >Sent: Thursday, November 14, 2019 4:06 PM >To: Jagdish Gediya <jagdish.gediya@nxp.com>; Priyanka Jain ><priyanka.jain@nxp.com>; hs@denx.de; jagan@amarulasolutions.com; >aford173@gmail.com; Alison Wang <alison.wang@nxp.com>; >bhaskar.upadhaya@nxp.com; feng.li_2@nxp.com; jh80.chung@samsung.com; >Pramod Kumar <pramod.kumar_1@nxp.com>; Rajesh Bhagat ><rajesh.bhagat@nxp.com>; Ruchika Gupta <ruchika.gupta@nxp.com>; >olteanv@gmail.com >Cc: Xiaobo Xie <xiaobo.xie@nxp.com>; Jiafei Pan <jiafei.pan@nxp.com>; u- >boot@lists.denx.de; Biwen Li <biwen.li@nxp.com> >Subject: [PATCH 07/42] configs: ls1012a: enable CONFIG_DM_RTC > >This enables CONFIG_DM_RTC for SoC LS1012A to fix compilation error when >enabled CONFIG_DM_I2C and CONFIG_CMD_DATE as follows: > - cmd/date.c: In function ‘do_date’: > cmd/date.c:51:12: warning: implicit declaration of function >‘I2C_GET_BUS’; did you mean ‘IDE_BUS’? [-Wimplicit-function-declaration] > old_bus = I2C_GET_BUS(); > ^~~~~~~~~~~ > IDE_BUS > cmd/date.c:52:2: warning: implicit declaration of function >‘I2C_SET_BUS’; did you mean ‘IDE_BUS’? [-Wimplicit-function-declaration] > I2C_SET_BUS(CONFIG_SYS_RTC_BUS_NUM); > ^~~~~~~~~~~ > IDE_BUS > LD drivers/pci/built-in.o > cmd/date.c:52:14: error: ‘CONFIG_SYS_RTC_BUS_NUM’ undeclared >(first use in this function); did you mean ‘CONFIG_SYS_EEPROM_BUS_NUM’? > I2C_SET_BUS(CONFIG_SYS_RTC_BUS_NUM); > ^~~~~~~~~~~~~~~~~~~~~~ > CONFIG_SYS_EEPROM_BUS_NUM > cmd/date.c:52:14: note: each undeclared identifier is reported only >once for each function it appears in > scripts/Makefile.build:278: recipe for target cmd/date.o failed > make[1]: *** [cmd/date.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > If this compilation error is introduced by one of your patch, merge with that. >Signed-off-by: Biwen Li <biwen.li@nxp.com> <snip> -priyankajain
diff --git a/configs/ls1012a2g5rdb_qspi_defconfig b/configs/ls1012a2g5rdb_qspi_defconfig index ea0ec04545..e6733304d9 100644 --- a/configs/ls1012a2g5rdb_qspi_defconfig +++ b/configs/ls1012a2g5rdb_qspi_defconfig @@ -49,3 +49,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y diff --git a/configs/ls1012a2g5rdb_tfa_defconfig b/configs/ls1012a2g5rdb_tfa_defconfig index 5ee9e2e0e2..8a52bb8e13 100644 --- a/configs/ls1012a2g5rdb_tfa_defconfig +++ b/configs/ls1012a2g5rdb_tfa_defconfig @@ -49,3 +49,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y diff --git a/configs/ls1012afrdm_qspi_defconfig b/configs/ls1012afrdm_qspi_defconfig index e147914dba..62ce6c7576 100644 --- a/configs/ls1012afrdm_qspi_defconfig +++ b/configs/ls1012afrdm_qspi_defconfig @@ -49,3 +49,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y diff --git a/configs/ls1012afrdm_tfa_defconfig b/configs/ls1012afrdm_tfa_defconfig index fa9a33a9fb..628f763101 100644 --- a/configs/ls1012afrdm_tfa_defconfig +++ b/configs/ls1012afrdm_tfa_defconfig @@ -49,3 +49,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y diff --git a/configs/ls1012afrwy_qspi_SECURE_BOOT_defconfig b/configs/ls1012afrwy_qspi_SECURE_BOOT_defconfig index e92b10e89b..a29a1d8309 100644 --- a/configs/ls1012afrwy_qspi_SECURE_BOOT_defconfig +++ b/configs/ls1012afrwy_qspi_SECURE_BOOT_defconfig @@ -54,3 +54,4 @@ CONFIG_RSA=y CONFIG_RSA_SOFTWARE_EXP=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y diff --git a/configs/ls1012afrwy_qspi_defconfig b/configs/ls1012afrwy_qspi_defconfig index 5a3b7b7284..3af9439ef4 100644 --- a/configs/ls1012afrwy_qspi_defconfig +++ b/configs/ls1012afrwy_qspi_defconfig @@ -51,3 +51,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y diff --git a/configs/ls1012afrwy_tfa_SECURE_BOOT_defconfig b/configs/ls1012afrwy_tfa_SECURE_BOOT_defconfig index b9de7613bf..7980a67717 100644 --- a/configs/ls1012afrwy_tfa_SECURE_BOOT_defconfig +++ b/configs/ls1012afrwy_tfa_SECURE_BOOT_defconfig @@ -54,3 +54,4 @@ CONFIG_RSA=y CONFIG_RSA_SOFTWARE_EXP=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y diff --git a/configs/ls1012afrwy_tfa_defconfig b/configs/ls1012afrwy_tfa_defconfig index bf0979232f..70a5eff359 100644 --- a/configs/ls1012afrwy_tfa_defconfig +++ b/configs/ls1012afrwy_tfa_defconfig @@ -53,3 +53,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y diff --git a/configs/ls1012aqds_qspi_defconfig b/configs/ls1012aqds_qspi_defconfig index b96b9968d2..f4424de4b6 100644 --- a/configs/ls1012aqds_qspi_defconfig +++ b/configs/ls1012aqds_qspi_defconfig @@ -73,3 +73,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y diff --git a/configs/ls1012aqds_tfa_SECURE_BOOT_defconfig b/configs/ls1012aqds_tfa_SECURE_BOOT_defconfig index 6ebe2894b1..3b75ea19de 100644 --- a/configs/ls1012aqds_tfa_SECURE_BOOT_defconfig +++ b/configs/ls1012aqds_tfa_SECURE_BOOT_defconfig @@ -67,3 +67,4 @@ CONFIG_RSA=y CONFIG_RSA_SOFTWARE_EXP=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y diff --git a/configs/ls1012aqds_tfa_defconfig b/configs/ls1012aqds_tfa_defconfig index 857f04c1c4..9bb207769e 100644 --- a/configs/ls1012aqds_tfa_defconfig +++ b/configs/ls1012aqds_tfa_defconfig @@ -73,3 +73,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y diff --git a/configs/ls1012ardb_qspi_SECURE_BOOT_defconfig b/configs/ls1012ardb_qspi_SECURE_BOOT_defconfig index cd7902c5c9..3cd50af13c 100644 --- a/configs/ls1012ardb_qspi_SECURE_BOOT_defconfig +++ b/configs/ls1012ardb_qspi_SECURE_BOOT_defconfig @@ -57,3 +57,4 @@ CONFIG_RSA=y CONFIG_RSA_SOFTWARE_EXP=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y diff --git a/configs/ls1012ardb_qspi_defconfig b/configs/ls1012ardb_qspi_defconfig index 54d2aa6fb2..c4750a3494 100644 --- a/configs/ls1012ardb_qspi_defconfig +++ b/configs/ls1012ardb_qspi_defconfig @@ -56,3 +56,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y diff --git a/configs/ls1012ardb_tfa_SECURE_BOOT_defconfig b/configs/ls1012ardb_tfa_SECURE_BOOT_defconfig index 91edcb098d..49c895007f 100644 --- a/configs/ls1012ardb_tfa_SECURE_BOOT_defconfig +++ b/configs/ls1012ardb_tfa_SECURE_BOOT_defconfig @@ -57,3 +57,4 @@ CONFIG_RSA=y CONFIG_RSA_SOFTWARE_EXP=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y diff --git a/configs/ls1012ardb_tfa_defconfig b/configs/ls1012ardb_tfa_defconfig index e6c6b61f04..92085ec708 100644 --- a/configs/ls1012ardb_tfa_defconfig +++ b/configs/ls1012ardb_tfa_defconfig @@ -57,3 +57,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_DM_I2C=y CONFIG_DM_GPIO=y +CONFIG_DM_RTC=y
This enables CONFIG_DM_RTC for SoC LS1012A to fix compilation error when enabled CONFIG_DM_I2C and CONFIG_CMD_DATE as follows: - cmd/date.c: In function ‘do_date’: cmd/date.c:51:12: warning: implicit declaration of function ‘I2C_GET_BUS’; did you mean ‘IDE_BUS’? [-Wimplicit-function-declaration] old_bus = I2C_GET_BUS(); ^~~~~~~~~~~ IDE_BUS cmd/date.c:52:2: warning: implicit declaration of function ‘I2C_SET_BUS’; did you mean ‘IDE_BUS’? [-Wimplicit-function-declaration] I2C_SET_BUS(CONFIG_SYS_RTC_BUS_NUM); ^~~~~~~~~~~ IDE_BUS LD drivers/pci/built-in.o cmd/date.c:52:14: error: ‘CONFIG_SYS_RTC_BUS_NUM’ undeclared (first use in this function); did you mean ‘CONFIG_SYS_EEPROM_BUS_NUM’? I2C_SET_BUS(CONFIG_SYS_RTC_BUS_NUM); ^~~~~~~~~~~~~~~~~~~~~~ CONFIG_SYS_EEPROM_BUS_NUM cmd/date.c:52:14: note: each undeclared identifier is reported only once for each function it appears in scripts/Makefile.build:278: recipe for target cmd/date.o failed make[1]: *** [cmd/date.o] Error 1 make[1]: *** Waiting for unfinished jobs.... Signed-off-by: Biwen Li <biwen.li@nxp.com> --- configs/ls1012a2g5rdb_qspi_defconfig | 1 + configs/ls1012a2g5rdb_tfa_defconfig | 1 + configs/ls1012afrdm_qspi_defconfig | 1 + configs/ls1012afrdm_tfa_defconfig | 1 + configs/ls1012afrwy_qspi_SECURE_BOOT_defconfig | 1 + configs/ls1012afrwy_qspi_defconfig | 1 + configs/ls1012afrwy_tfa_SECURE_BOOT_defconfig | 1 + configs/ls1012afrwy_tfa_defconfig | 1 + configs/ls1012aqds_qspi_defconfig | 1 + configs/ls1012aqds_tfa_SECURE_BOOT_defconfig | 1 + configs/ls1012aqds_tfa_defconfig | 1 + configs/ls1012ardb_qspi_SECURE_BOOT_defconfig | 1 + configs/ls1012ardb_qspi_defconfig | 1 + configs/ls1012ardb_tfa_SECURE_BOOT_defconfig | 1 + configs/ls1012ardb_tfa_defconfig | 1 + 15 files changed, 15 insertions(+)