| Message ID | 20191113183945.18872-1-bob.beckett@collabora.com |
|---|---|
| State | Accepted |
| Commit | 677dac23d8ebfc0342f903aeee2a75e737fd4d7e |
| Headers | show |
| Series | [U-Boot] patman: fix coverletter cc list with nulls | expand |
Hi Robert, On Wed, 13 Nov 2019 at 12:40, Robert Beckett <bob.beckett@collabora.com> wrote: > > fixes: 8ab452d5877638a97e5bdd521d119403b70b45f5 > > When compiling list of cover letter cc addresses, using null as a > separater, then encoding to utf-8 results in lots of "\x00" as > separators. patman then doesnt understand that when it comes to > repoting the list to send-email. > > Fix this by not encoding to utf-8, as done for the other patch files. > > Signed-off-by: Robert Beckett <bob.beckett@collabora.com> > --- > > tools/patman/series.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I had applied my own patch to fix this but I think I like yours better. Reviewed-by: Simon Glass <sjg@chromium.org>
Hi Robert, On Wed, 13 Nov 2019 at 12:40, Robert Beckett <bob.beckett@collabora.com> wrote: > > fixes: 8ab452d5877638a97e5bdd521d119403b70b45f5 > > When compiling list of cover letter cc addresses, using null as a > separater, then encoding to utf-8 results in lots of "\x00" as > separators. patman then doesnt understand that when it comes to > repoting the list to send-email. > > Fix this by not encoding to utf-8, as done for the other patch files. > > Signed-off-by: Robert Beckett <bob.beckett@collabora.com> > --- > > tools/patman/series.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I had applied my own patch to fix this but I think I like yours better. Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot-dm, thanks!
Hi Robert, On Wed, 13 Nov 2019 at 12:40, Robert Beckett <bob.beckett@collabora.com> wrote: > > fixes: 8ab452d5877638a97e5bdd521d119403b70b45f5 > > When compiling list of cover letter cc addresses, using null as a > separater, then encoding to utf-8 results in lots of "\x00" as > separators. patman then doesnt understand that when it comes to > repoting the list to send-email. > > Fix this by not encoding to utf-8, as done for the other patch files. > > Signed-off-by: Robert Beckett <bob.beckett@collabora.com> > --- > > tools/patman/series.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I had applied my own patch to fix this but I think I like yours better. Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot-dm, thanks! Applied to u-boot-dm, thanks!
Hi Robert, On Wed, 13 Nov 2019 at 12:40, Robert Beckett <bob.beckett@collabora.com> wrote: > > fixes: 8ab452d5877638a97e5bdd521d119403b70b45f5 > > When compiling list of cover letter cc addresses, using null as a > separater, then encoding to utf-8 results in lots of "\x00" as > separators. patman then doesnt understand that when it comes to > repoting the list to send-email. > > Fix this by not encoding to utf-8, as done for the other patch files. > > Signed-off-by: Robert Beckett <bob.beckett@collabora.com> > --- > > tools/patman/series.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I had applied my own patch to fix this but I think I like yours better. Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot-dm, thanks! Applied to u-boot-dm, thanks! Applied to u-boot-dm, thanks!
diff --git a/tools/patman/series.py b/tools/patman/series.py index 02a1113ad0..a15f7625ed 100644 --- a/tools/patman/series.py +++ b/tools/patman/series.py @@ -251,7 +251,7 @@ class Series(dict): cover_cc = [tools.FromUnicode(m) for m in cover_cc] cc_list = '\0'.join([tools.ToUnicode(x) for x in sorted(set(cover_cc + all_ccs))]) - print(cover_fname, cc_list.encode('utf-8'), file=fd) + print(cover_fname, cc_list, file=fd) fd.close() return fname
fixes: 8ab452d5877638a97e5bdd521d119403b70b45f5 When compiling list of cover letter cc addresses, using null as a separater, then encoding to utf-8 results in lots of "\x00" as separators. patman then doesnt understand that when it comes to repoting the list to send-email. Fix this by not encoding to utf-8, as done for the other patch files. Signed-off-by: Robert Beckett <bob.beckett@collabora.com> --- tools/patman/series.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)