diff mbox series

[U-Boot,v4,2/5] fs: clean up around fs_type

Message ID 20191007055939.17093-3-takahiro.akashi@linaro.org
State Accepted, archived
Commit 185aed7855573214794b13f20e597d36c6dc5760
Delegated to: Heinrich Schuchardt
Headers show
Series efi_loader: disk: install FILE_SYSTEM_PROTOCOL to whole disk | expand

Commit Message

AKASHI Takahiro Oct. 7, 2019, 5:59 a.m. UTC 
fs_ls(), fs_mkdir() and fs_unlink() sets fs_type to FS_TYPE_ANY
explicitly, but it is redundant as they call fs_close().
So just remove those lines.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
 fs/fs.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Heinrich Schuchardt Oct. 12, 2019, 9:23 p.m. UTC | #1 
On 10/7/19 7:59 AM, AKASHI Takahiro wrote:
> fs_ls(), fs_mkdir() and fs_unlink() sets fs_type to FS_TYPE_ANY
> explicitly, but it is redundant as they call fs_close().
> So just remove those lines.
>
> Signed-off-by: AKASHI Takahiro<takahiro.akashi@linaro.org>

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
diff mbox series

Patch

diff --git a/fs/fs.c b/fs/fs.c
index 64ba25fea8bf..b17b76a46ae0 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -413,7 +413,6 @@  int fs_ls(const char *dirname)
 
 	ret = info->ls(dirname);
 
-	fs_type = FS_TYPE_ANY;
 	fs_close();
 
 	return ret;
@@ -597,7 +596,6 @@  int fs_unlink(const char *filename)
 
 	ret = info->unlink(filename);
 
-	fs_type = FS_TYPE_ANY;
 	fs_close();
 
 	return ret;
@@ -611,7 +609,6 @@  int fs_mkdir(const char *dirname)
 
 	ret = info->mkdir(dirname);
 
-	fs_type = FS_TYPE_ANY;
 	fs_close();
 
 	return ret;