| Message ID | 20190919081642.21038-2-grygorii.strashko@ti.com |
|---|---|
| State | Accepted |
| Commit | 60e81d0d2855690347bc479c9c20b4ad5de0b703 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | net: ti: set of fixes and improvements | expand |
On Thu, Sep 19, 2019 at 11:16:37AM +0300, Grygorii Strashko wrote: > According to TRMs the 10Mbps link speed is supported in RGMII only when > CPSW2G MAC SL is configured for External Control ("in band") mode > CPSW_SL_MACCTRL.EXT_EN(18) = 1. > > Hence update cpsw_slave_update_link() to follow documentation. > > [1] https://patchwork.kernel.org/patch/10285239/ > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> Applied to u-boot/master, thanks!
diff --git a/drivers/net/ti/cpsw.c b/drivers/net/ti/cpsw.c index 20ddb44dd8..f0d008f0f5 100644 --- a/drivers/net/ti/cpsw.c +++ b/drivers/net/ti/cpsw.c @@ -33,6 +33,7 @@ DECLARE_GLOBAL_DATA_PTR; #define GIGABITEN BIT(7) #define FULLDUPLEXEN BIT(0) #define MIIEN BIT(15) +#define CTL_EXT_EN BIT(18) /* DMA Registers */ #define CPDMA_TXCONTROL 0x004 #define CPDMA_RXCONTROL 0x014 @@ -489,6 +490,8 @@ static int cpsw_slave_update_link(struct cpsw_slave *slave, mac_control |= FULLDUPLEXEN; if (phy->speed == 100) mac_control |= MIIEN; + if (phy->speed == 10 && phy_interface_is_rgmii(phy)) + mac_control |= CTL_EXT_EN; } if (mac_control == slave->mac_control)
According to TRMs the 10Mbps link speed is supported in RGMII only when CPSW2G MAC SL is configured for External Control ("in band") mode CPSW_SL_MACCTRL.EXT_EN(18) = 1. Hence update cpsw_slave_update_link() to follow documentation. [1] https://patchwork.kernel.org/patch/10285239/ Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- drivers/net/ti/cpsw.c | 3 +++ 1 file changed, 3 insertions(+)