From patchwork Tue Sep 17 06:10:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 1163176 X-Patchwork-Delegate: ykai007@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="mjIRzp8v"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 46XXqy1bsbz9sNx for ; Tue, 17 Sep 2019 16:14:06 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id C208EC2210F; Tue, 17 Sep 2019 06:13:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 5C0A3C220D9; Tue, 17 Sep 2019 06:13:00 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 5D3AFC220FB; Tue, 17 Sep 2019 06:11:24 +0000 (UTC) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by lists.denx.de (Postfix) with ESMTPS id F3374C22095 for ; Tue, 17 Sep 2019 06:11:21 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id y5so1501837pfo.4 for ; Mon, 16 Sep 2019 23:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=25e7EAc79Jn2luYyrFMk67KzyhLcgMKLLU0RSV3N1QY=; b=mjIRzp8vGoZA3zVQlAfiL0TN0u8BdPYJyun6jGleM89QKj8vZKLx5O4e6hzYTkRLpc pOQShQZke7ZH9szgV47uxx9Xhbb+tzDspCY4DprOA0/3uiz0CEFOcQkbhEbAtcsHnmWg pY8S66PQEdAYvaSi2Na0oncrKrSEOOX4P5SZA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=25e7EAc79Jn2luYyrFMk67KzyhLcgMKLLU0RSV3N1QY=; b=D3FQnBuMHro3NNpwOU42EwgqF8iiaBYUi811GG9hXvPYX6G9ED/NLOTZl+NMYjnNEl 8o0gi1LftCvVVBJvoDiUXQUs9tByU8OGKB5o5Mzt0diXf5Hgx5bSi6htXhCpDyzQLnga 7/PcG8xBEL7dMGQ2pRSXX/Z9svJb/re/rjHGA5RF1uTJcN2Er6RoT2v4+B4+Vw+Xp++6 6OWcSbnHZb7zhBEzBGMSo0gguYO4WmsgrWoIsF/tl1glUoy3+z7p4W7oiYUywWw1JtMH rtKBSXZAE6E7WueLrMSEsjnYLmcNIJlr8EtNx4ebG0QoJYGZxuoZdQx97t+cqmE8istS Yy5w== X-Gm-Message-State: APjAAAUyNTDnrS5MB1doaBdMbhUqMQ7vZeywSpygwPbONSzDJgus/I3r +G3kP6pVIcEhx77AgwPvCHZfCw== X-Google-Smtp-Source: APXvYqzSG8VdnB3rR9d2XUJ5MMCfqocKSsnfAk+0bdNvCO1oLhFP2xfQJHbRgISygPi9DEbtzryIig== X-Received: by 2002:a62:2f85:: with SMTP id v127mr2341331pfv.68.1568700680561; Mon, 16 Sep 2019 23:11:20 -0700 (PDT) Received: from localhost.localdomain ([49.206.203.254]) by smtp.gmail.com with ESMTPSA id a17sm1229150pfc.26.2019.09.16.23.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2019 23:11:20 -0700 (PDT) From: Jagan Teki To: Kever Yang , Philipp Tomsich , Simon Glass , Michael Nazzareno Trimarchi Date: Tue, 17 Sep 2019 11:40:41 +0530 Message-Id: <20190917061042.32053-7-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190917061042.32053-1-jagan@amarulasolutions.com> References: <20190917061042.32053-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Cc: Tom Rini , u-boot@lists.denx.de Subject: [U-Boot] [PATCH 6/7] configs: tinker: Enable SDRAM, SPL stack X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" SPL sets up SDRAM while in its board_init_f() function, it is possible for the stack to move there before board_init_r() is reached. So it is required to reserve the stack for SDRAM, with a proper location and size otherwise any operations during SPL handoff would leads to failure. On, this particular context tinker-rk3288 SPL is failing to launch U-Boot proper on SDRAM due to lack of stack. U-Boot SPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36 +0530) Trying to boot from MMC1 spl: mmc init failed with error: -110 SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ### So, enable SPL_STACK_R_ADDR and it's related-config items for SDRAM, SPL stack to setup properly. Reported-by: Jagan Teki Signed-off-by: Jagan Teki Reviewed-by: Kever Yang --- configs/tinker-rk3288_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig index adab1cba42..359be078ac 100644 --- a/configs/tinker-rk3288_defconfig +++ b/configs/tinker-rk3288_defconfig @@ -4,6 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x01000000 CONFIG_ROCKCHIP_RK3288=y CONFIG_TARGET_TINKER_RK3288=y CONFIG_NR_DRAM_BANKS=1 +CONFIG_SPL_STACK_R_ADDR=0x80000 CONFIG_SPL_SIZE_LIMIT=307200 CONFIG_DEBUG_UART_BASE=0xff690000 CONFIG_DEBUG_UART_CLOCK=24000000 @@ -15,6 +16,8 @@ CONFIG_CONSOLE_MUX=y CONFIG_DEFAULT_FDT_FILE="rk3288-tinker.dtb" # CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y +CONFIG_SPL_STACK_R=y +CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y