diff mbox series

[U-Boot,v1,5/5] colibri_t30: disable rs232 serial transceiver forceoff pins

Message ID 20190912091256.15573-6-marcel@ziswiler.com
State Accepted
Commit 1b56cd868e3c691625aa9bce2f475fcd4cf0405a
Delegated to: Tom Warren
Headers show
Series apalis/colibri_t30: uart pinmuxing improvements | expand

Commit Message

Marcel Ziswiler Sept. 12, 2019, 9:12 a.m. UTC 
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Use gpio_early_init_uart() function to disable RS232 serial transceiver
ForceOFF# pins on Iris.

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

---

 board/toradex/colibri_t30/colibri_t30.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Igor Opaniuk Oct. 16, 2019, 9:20 a.m. UTC | #1 
Hi Marcel,

On Thu, Sep 12, 2019 at 12:15 PM Marcel Ziswiler <marcel@ziswiler.com> wrote:
>
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Use gpio_early_init_uart() function to disable RS232 serial transceiver
> ForceOFF# pins on Iris.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
>  board/toradex/colibri_t30/colibri_t30.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/board/toradex/colibri_t30/colibri_t30.c b/board/toradex/colibri_t30/colibri_t30.c
> index b6b00e3860..eb53fa6126 100644
> --- a/board/toradex/colibri_t30/colibri_t30.c
> +++ b/board/toradex/colibri_t30/colibri_t30.c
> @@ -55,6 +55,17 @@ void pinmux_init(void)
>                                    ARRAY_SIZE(colibri_t30_padctrl));
>  }
>
> +/*
> + * Disable RS232 serial transceiver ForceOFF# pins on Iris
> + */
> +void gpio_early_init_uart(void)
> +{
> +       gpio_request(TEGRA_GPIO(X, 6), "Force OFF# X13");
> +       gpio_direction_output(TEGRA_GPIO(X, 6), 1);
> +       gpio_request(TEGRA_GPIO(X, 7), "Force OFF# X14");
> +       gpio_direction_output(TEGRA_GPIO(X, 7), 1);
> +}
> +
>  /*
>   * Enable AX88772B USB to LAN controller
>   */
> --
> 2.21.0
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot

What not to handle this in the dts instead?

--
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk@gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk
diff mbox series

Patch

diff --git a/board/toradex/colibri_t30/colibri_t30.c b/board/toradex/colibri_t30/colibri_t30.c
index b6b00e3860..eb53fa6126 100644
--- a/board/toradex/colibri_t30/colibri_t30.c
+++ b/board/toradex/colibri_t30/colibri_t30.c
@@ -55,6 +55,17 @@  void pinmux_init(void)
 				   ARRAY_SIZE(colibri_t30_padctrl));
 }
 
+/*
+ * Disable RS232 serial transceiver ForceOFF# pins on Iris
+ */
+void gpio_early_init_uart(void)
+{
+	gpio_request(TEGRA_GPIO(X, 6), "Force OFF# X13");
+	gpio_direction_output(TEGRA_GPIO(X, 6), 1);
+	gpio_request(TEGRA_GPIO(X, 7), "Force OFF# X14");
+	gpio_direction_output(TEGRA_GPIO(X, 7), 1);
+}
+
 /*
  * Enable AX88772B USB to LAN controller
  */