diff mbox series

[U-Boot,2/2] rockchip: rk3328: enable DMA for MMCs at Rock64

Message ID 20190729091819.9455-2-matwey.kornilov@gmail.com
State Accepted
Commit 16593ccd07afdbb24a937eac4ea7e16269ff51e0
Delegated to: Kever Yang
Headers show
Series [U-Boot,1/2] rockchip: rk3328: set DDR as non-secure in SPL | expand

Commit Message

Matwey V. Kornilov July 29, 2019, 9:18 a.m. UTC
DMA for MMCs can be enabled, since the previous patch fixes
the following issue in SPL:

    Trying to boot from MMC1
    spl: mmc init failed with error: -110
    SPL: failed to boot from all boot devices
    ### ERROR ### Please RESET the board ###

Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
---
 arch/arm/dts/rk3328-rock64-u-boot.dtsi | 2 --
 1 file changed, 2 deletions(-)

Comments

Kever Yang Aug. 5, 2019, 12:54 p.m. UTC | #1
On 2019/7/29 下午5:18, Matwey V. Kornilov wrote:
> DMA for MMCs can be enabled, since the previous patch fixes
> the following issue in SPL:
>
>      Trying to boot from MMC1
>      spl: mmc init failed with error: -110
>      SPL: failed to boot from all boot devices
>      ### ERROR ### Please RESET the board ###
>
> Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/dts/rk3328-rock64-u-boot.dtsi | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/dts/rk3328-rock64-u-boot.dtsi b/arch/arm/dts/rk3328-rock64-u-boot.dtsi
> index b077436cbc..928911f6a6 100644
> --- a/arch/arm/dts/rk3328-rock64-u-boot.dtsi
> +++ b/arch/arm/dts/rk3328-rock64-u-boot.dtsi
> @@ -25,10 +25,8 @@
>   
>   &emmc {
>   	u-boot,dm-pre-reloc;
> -	fifo-mode;
>   };
>   
>   &sdmmc {
>   	u-boot,dm-pre-reloc;
> -	fifo-mode;
>   };
Chen-Yu Tsai Aug. 6, 2019, 4:20 a.m. UTC | #2
On Mon, Aug 5, 2019 at 8:54 PM Kever Yang <kever.yang@rock-chips.com> wrote:
>
>
> On 2019/7/29 下午5:18, Matwey V. Kornilov wrote:
> > DMA for MMCs can be enabled, since the previous patch fixes
> > the following issue in SPL:
> >
> >      Trying to boot from MMC1
> >      spl: mmc init failed with error: -110
> >      SPL: failed to boot from all boot devices
> >      ### ERROR ### Please RESET the board ###
> >
> > Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
>
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Tested-by: Chen-Yu Tsai <wens@csie.org>

on a Rock64.
diff mbox series

Patch

diff --git a/arch/arm/dts/rk3328-rock64-u-boot.dtsi b/arch/arm/dts/rk3328-rock64-u-boot.dtsi
index b077436cbc..928911f6a6 100644
--- a/arch/arm/dts/rk3328-rock64-u-boot.dtsi
+++ b/arch/arm/dts/rk3328-rock64-u-boot.dtsi
@@ -25,10 +25,8 @@ 
 
 &emmc {
 	u-boot,dm-pre-reloc;
-	fifo-mode;
 };
 
 &sdmmc {
 	u-boot,dm-pre-reloc;
-	fifo-mode;
 };