| Message ID | 20190718213001.24815-7-olteanv@gmail.com |
|---|---|
| State | Accepted |
| Commit | 1c8ad086748545f3c0f0fd5abfba4cea7ebfdc15 |
| Delegated to: | Joe Hershberger |
| Headers | show |
| Series | NXP LS1021A-TSN Board | expand |
On Thu, Jul 18, 2019 at 4:36 PM Vladimir Oltean <olteanv@gmail.com> wrote: > > In the case of the tsec network driver, so far there has been no > mainline user of DM_ETH where the DT bindings get used. > > In the case of the mdio bus, it looks like the "fsl,tsec-mdio" string > was made up for the documentation, but there is no mainline code that > parses the "compatible" property anyway. > > In both cases, there are no DT blobs that contain the old strings. > > So change the documentation to "fsl,etsec2" for the Ethernet ports and > "fsl,etsec2-mdio" for the MDIO buses, which are strings that Linux also > uses, at least for LS1021A. More compatible strings can be added once > other (PowerPC) SoCs are migrated to DM_ETH. > > The current ls1021a.dtsi doesn't match what was documented for the MDIO > buses anyway (the "compatible" is "gianfar" currently). This will be > fixed in the next patch. > > Fixes: 69a00875e3db ("doc: dt-bindings: Describe Freescale TSEC ethernet controller") > Signed-off-by: Vladimir Oltean <olteanv@gmail.com> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Hi Vladimir, https://patchwork.ozlabs.org/patch/1133865/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe
diff --git a/doc/device-tree-bindings/net/fsl-tsec-phy.txt b/doc/device-tree-bindings/net/fsl-tsec-phy.txt index c5bf48c3cb51..59989e3b09d6 100644 --- a/doc/device-tree-bindings/net/fsl-tsec-phy.txt +++ b/doc/device-tree-bindings/net/fsl-tsec-phy.txt @@ -28,13 +28,13 @@ device that exists on this bus, a PHY node should be created. Required properties: - compatible : Should define the compatible device type for the - mdio. Currently supported string/device is "fsl,tsec-mdio". + mdio. Currently supported string/device is "fsl,etsec2-mdio". - reg : Offset and length of the register set for the device Example: mdio@24520 { - compatible = "fsl,tsec-mdio"; + compatible = "fsl,etsec2-mdio"; reg = <0x24520 0x20>; ethernet-phy@0 { diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c index f6278817330d..f85cdcb97ebf 100644 --- a/drivers/net/tsec.c +++ b/drivers/net/tsec.c @@ -880,7 +880,7 @@ static const struct eth_ops tsec_ops = { }; static const struct udevice_id tsec_ids[] = { - { .compatible = "fsl,tsec" }, + { .compatible = "fsl,etsec2" }, { } };
In the case of the tsec network driver, so far there has been no mainline user of DM_ETH where the DT bindings get used. In the case of the mdio bus, it looks like the "fsl,tsec-mdio" string was made up for the documentation, but there is no mainline code that parses the "compatible" property anyway. In both cases, there are no DT blobs that contain the old strings. So change the documentation to "fsl,etsec2" for the Ethernet ports and "fsl,etsec2-mdio" for the MDIO buses, which are strings that Linux also uses, at least for LS1021A. More compatible strings can be added once other (PowerPC) SoCs are migrated to DM_ETH. The current ls1021a.dtsi doesn't match what was documented for the MDIO buses anyway (the "compatible" is "gianfar" currently). This will be fixed in the next patch. Fixes: 69a00875e3db ("doc: dt-bindings: Describe Freescale TSEC ethernet controller") Signed-off-by: Vladimir Oltean <olteanv@gmail.com> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> --- Changes from v2: None. Changes from v1: Patch is new. doc/device-tree-bindings/net/fsl-tsec-phy.txt | 4 ++-- drivers/net/tsec.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)