From patchwork Mon Jul 15 18:20:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 1132171 X-Patchwork-Delegate: ykai007@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="hQY2ym+H"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45nX7J1Rtvz9s3l for ; Tue, 16 Jul 2019 04:27:08 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id D21C2C21FB5; Mon, 15 Jul 2019 18:22:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id C9779C21F0F; Mon, 15 Jul 2019 18:22:08 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 5EFCBC21F0F; Mon, 15 Jul 2019 18:21:40 +0000 (UTC) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by lists.denx.de (Postfix) with ESMTPS id 54EA6C21FAE for ; Mon, 15 Jul 2019 18:21:36 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id g2so7815826pfq.0 for ; Mon, 15 Jul 2019 11:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wtH+L++PhkK0wx6pSCUYJbZO6pOG2ERf3vcIuQe4X5s=; b=hQY2ym+H1XKJ1Wnq0PwWVIS9Xl9vPViycQ4PooTAopDlM/3kUswTbTks7/6CkDyPUC Hd2hz30zXfEFTJhLn9Ft3hJhZyQ7oeUq/zo/EhXvxlwKs09OokMKaQnvI+ESXddMqmq8 JWe0oVrmDBrGKRfD1Om8TKNehwmlbvrEBLtVk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wtH+L++PhkK0wx6pSCUYJbZO6pOG2ERf3vcIuQe4X5s=; b=fPAYBqWMRrADOUi6IoNvcAL/BmNCq681M4Mh0lhfa2MoxTRK2TnA1ukryjNmS4PFYZ ZewnYHXeEx1TArf0HdkdXwJWu7CUNGqVCx8IyM+Dgs+mN/K8WUKiiv2fUdW8dRcHere/ b8r4gzKwKuwtrNk8/8/eX/tFyEqvPTHbDPjZjnYb9Yj0e8W3pJG7Sjn/dMPWHtxDIQT4 7sJdCm83kOmA63hst+xdx444UjJHOMO4B+qssj296Qqi5Q0nXBJSFUSU3iB5uOALN33K Lxq1OVPhso5+kvYgh0H2OU157q1jOCNu9m8XIa06PTpuxTnieglUTQWKJtFdM3tFKijV +Ipg== X-Gm-Message-State: APjAAAXnQI40wEVZ6WKwI8YIzYsDtwQRDrMY13Idys1z/2/io4UzeS2G 8QYfIxv4kjP7TE+lIUESKRrgtA== X-Google-Smtp-Source: APXvYqz9SmiPCjhDaJ66e3eNzEEkgGBqq+W48Y9UIctpiGPlz9eP6V9LBJx9ME98AEUkugUJu7KnFA== X-Received: by 2002:a63:d448:: with SMTP id i8mr9006870pgj.173.1563214894885; Mon, 15 Jul 2019 11:21:34 -0700 (PDT) Received: from localhost.localdomain ([49.206.201.107]) by smtp.gmail.com with ESMTPSA id l15sm18152405pgf.5.2019.07.15.11.21.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jul 2019 11:21:34 -0700 (PDT) From: Jagan Teki To: Simon Glass , Philipp Tomsich , Kever Yang , YouMin Chen , u-boot@lists.denx.de Date: Mon, 15 Jul 2019 23:50:59 +0530 Message-Id: <20190715182110.21336-5-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190715182110.21336-1-jagan@amarulasolutions.com> References: <20190715182110.21336-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Cc: linux-rockchip@lists.infradead.org, gajjar04akash@gmail.com, linux-amarula@amarulasolutions.com, Manivannan Sadhasivam Subject: [U-Boot] [PATCH v3 04/15] ram: rk3399: Handle pctl_cfg return type X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Add proper return type handling of pctl_cfg with meaningful print statement. Signed-off-by: Jagan Teki Reviewed-by: Kever Yang --- drivers/ram/rockchip/sdram_rk3399.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c index c918c2e588..de5d8c1b5f 100644 --- a/drivers/ram/rockchip/sdram_rk3399.c +++ b/drivers/ram/rockchip/sdram_rk3399.c @@ -1063,6 +1063,7 @@ static int sdram_init(struct dram_info *dram, unsigned char dramtype = params->base.dramtype; unsigned int ddr_freq = params->base.ddr_freq; int channel; + int ret; debug("Starting SDRAM initialization...\n"); @@ -1082,9 +1083,10 @@ static int sdram_init(struct dram_info *dram, if (channel >= params->base.num_channels) continue; - if (pctl_cfg(chan, channel, params) != 0) { - printf("pctl_cfg fail, reset\n"); - return -EIO; + ret = pctl_cfg(chan, channel, params); + if (ret < 0) { + printf("%s: pctl config failed\n", __func__); + return ret; } /* LPDDR2/LPDDR3 need to wait DAI complete, max 10us */