From patchwork Sun Jul 14 00:16:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 1131673 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Rv9nJPao"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45mS7c5tRwz9sMQ for ; Sun, 14 Jul 2019 10:23:40 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 842BDC21D56; Sun, 14 Jul 2019 00:21:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id D1625C21E39; Sun, 14 Jul 2019 00:20:08 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 341C3C21DB6; Sun, 14 Jul 2019 00:19:57 +0000 (UTC) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by lists.denx.de (Postfix) with ESMTPS id 5ABA6C21DDC for ; Sun, 14 Jul 2019 00:19:54 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id f9so13382213wre.12 for ; Sat, 13 Jul 2019 17:19:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EQ2MrWHFxO8hqbiqLV3mqVnMZcO286TeHwx36+rlE2I=; b=Rv9nJPao8Rl079bY0o4L+z6nZE6WFNDB+XYQLTDhfhG9M44JhyffcCQEcb5ZSwGj6P /K424Lxd15R+F9+v6cdyrh9wJkmblZpMkmxzsMNYwQf9oND0ZJhpTQds1wHPT2Y297ks nr6zSXNV+CkcgzvzZIRT8Hy3xvjw4zbpB3ut8jMR15CoTz7WaHgh5kiyTelxb0aNHBtb bY93SzF2XEZuXwBiZVu6ILeWyBO6LBKHuCKEn6MOiFqP+bTQMhC2ACXkxbJSF835SSgS kZeFI0n3DncqzVxVOgq7ZeEsfLU4SpJdcZQq2PmBxReAMYvcC5NCB+Q1y6cFmsPnZUgn 2flw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EQ2MrWHFxO8hqbiqLV3mqVnMZcO286TeHwx36+rlE2I=; b=jpoL3j+W49FVwDYSStnjubwW160O8vcHywwdcZoJCeEJqyVfRKrHQT1YFyZ4mlpDx3 sRlyDZPM8kQV/FadUQZSYhMXkzKjz+wPiH/qu+9nrdYXkb3nNLPbcSvkz8OY+/CT6/jC hxIi0p3pGkDNv0iWdGXigyK125PkZDAKcdDKU4K9GD51Pt1RmTr4ecZKEKyyXkNPehbN 39ZghgVIRsYHACKnFBCHzR6KyWIpxXJrfrKyS4Lo/weST+zWQm8eycuCFRAcWWz2Tkxz rYOAVw9wFiXtIgnCCyiHXD9loFhfWf1vGA/w22dOTDX+Tds7hVnFKIGPVK1FP36I9wmO 8mag== X-Gm-Message-State: APjAAAV3otEksKjao0vDdHOKyTeYr93uE7/5VcPq9O4SGteT02WkUdaH ESbxMvNTTzynlV8x3yPLdD8= X-Google-Smtp-Source: APXvYqwHcpB9dFnZhDj5pctZHdBkFhjqOr39FVbGh6eRfRLroMxm8LkSaBkCUM/TkgX2gWLHJYWQOA== X-Received: by 2002:a5d:428c:: with SMTP id k12mr20078795wrq.81.1563063593988; Sat, 13 Jul 2019 17:19:53 -0700 (PDT) Received: from localhost.localdomain ([188.26.252.192]) by smtp.gmail.com with ESMTPSA id m24sm7801973wmi.39.2019.07.13.17.19.53 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 13 Jul 2019 17:19:53 -0700 (PDT) From: Vladimir Oltean To: joe.hershberger@ni.com, prabhakar.kushwaha@nxp.com, bmeng.cn@gmail.com, u-boot@lists.denx.de Date: Sun, 14 Jul 2019 03:16:56 +0300 Message-Id: <20190714001701.2781-5-olteanv@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190714001701.2781-1-olteanv@gmail.com> References: <20190714001701.2781-1-olteanv@gmail.com> Subject: [U-Boot] [PATCH v2 4/9] net: tsec: Make errors visible X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" This replaces debug() calls with printf() so that it is immediately obvious from the console that something is wrong. Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberger Reviewed-by: Bin Meng --- Changes from v1: None. drivers/net/tsec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c index ce19ff9228fd..1e20fe4cd246 100644 --- a/drivers/net/tsec.c +++ b/drivers/net/tsec.c @@ -268,7 +268,7 @@ static int tsec_send(struct udevice *dev, void *packet, int length) in_be16(&priv->txbd[priv->tx_idx].status) & TXBD_READY; i++) { if (i >= TOUT_LOOP) { - debug("%s: tsec: tx buffers full\n", dev->name); + printf("%s: tsec: tx buffers full\n", dev->name); return result; } } @@ -287,7 +287,7 @@ static int tsec_send(struct udevice *dev, void *packet, int length) in_be16(&priv->txbd[priv->tx_idx].status) & TXBD_READY; i++) { if (i >= TOUT_LOOP) { - debug("%s: tsec: tx error\n", dev->name); + printf("%s: tsec: tx error\n", dev->name); return result; } } @@ -809,7 +809,7 @@ int tsec_probe(struct udevice *dev) if (dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0, &phandle_args)) { - debug("phy-handle does not exist under tsec %s\n", dev->name); + printf("phy-handle does not exist under tsec %s\n", dev->name); return -ENOENT; } else { int reg = ofnode_read_u32_default(phandle_args.node, "reg", 0); @@ -838,7 +838,7 @@ int tsec_probe(struct udevice *dev) if (phy_mode) pdata->phy_interface = phy_get_interface_by_name(phy_mode); if (pdata->phy_interface == -1) { - debug("Invalid PHY interface '%s'\n", phy_mode); + printf("Invalid PHY interface '%s'\n", phy_mode); return -EINVAL; } priv->interface = pdata->phy_interface;