From patchwork Mon Jul 8 19:18:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1129273 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="VLjBY1S/"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45jFnT6lxKz9sDB for ; Tue, 9 Jul 2019 05:26:53 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 9454EC21D8A; Mon, 8 Jul 2019 19:24:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 384A7C21DED; Mon, 8 Jul 2019 19:21:20 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 2EB34C21E1E; Mon, 8 Jul 2019 19:21:13 +0000 (UTC) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by lists.denx.de (Postfix) with ESMTPS id 6E577C21DF9 for ; Mon, 8 Jul 2019 19:21:08 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id s7so37812348iob.11 for ; Mon, 08 Jul 2019 12:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TUySJ0k5KIP9Gps2T22HwJ0ZxmvHxLtTtmHClKcccKQ=; b=VLjBY1S/yG3SqX4N0aJQtrBBPiU//3/c/HLEJfW4eN0os0ssohNJlO5rVPqn/FKkqn IWv9Wl8PV2GdpuRbJHRiVnXuHRE1qTh59pl6O61PsTbVC5q1zw74DSeltLzCxWDJPw1Z N8LAArcQf4baOlf0I7/65NO/TX+YqWJLYbubA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TUySJ0k5KIP9Gps2T22HwJ0ZxmvHxLtTtmHClKcccKQ=; b=KvlVDMp++ZS6hvOxWrwbjMwrjeO9uCb8Mp/NQ+28E4zKaOsrA4wigyGYsOky4hW/8l erkbimyNWqM2PaTtTHqM9A1RzlXy/vpv/GuIytbSQLj6uDqFE42TpQXtTAXvoz34Xv+g 5ci0U1l2tQGC99gOaH0690sx0zP/XjOtLUsKaCFoaU33JO97qYRbWQfjWyf0eyeRWaLe wACGHpPoxLHe3Kjuc4UkmVIQpD0MmPM9CEGMDjs0bwIKFuwxclEemUhCUYHFKuYudc2W /4osThPTNzy621fe4aA524bopHtWajP72PV/6svXeLZPlW2oqFX5zzUKKs2AETfScVbD RWzQ== X-Gm-Message-State: APjAAAUwpon3/6qUlC8YD5/jiK5UbNxdxQIe3iGnU0Wc6YyJRyBjjNAY FjH7pjqyo6JzCN1xqjE9nvWD3vz1H4s= X-Google-Smtp-Source: APXvYqxcmNDxIZLl72gYXkjAZnFsqs8teaaTJMLYceA/dAUD8RC8Os9j7AUGWBGPUWO1nqW+cOaodg== X-Received: by 2002:a02:54c1:: with SMTP id t184mr24313221jaa.10.1562613667252; Mon, 08 Jul 2019 12:21:07 -0700 (PDT) Received: from kiwi.bld.corp.google.com ([2620:15c:183:0:8223:87c:a681:66aa]) by smtp.gmail.com with ESMTPSA id j1sm15545094iop.14.2019.07.08.12.21.06 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 08 Jul 2019 12:21:06 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Date: Mon, 8 Jul 2019 13:18:30 -0600 Message-Id: <20190708191856.138863-12-sjg@chromium.org> X-Mailer: git-send-email 2.22.0.410.gd8fdbe21b5-goog In-Reply-To: <20190708191856.138863-1-sjg@chromium.org> References: <20190708191856.138863-1-sjg@chromium.org> MIME-Version: 1.0 Subject: [U-Boot] [PATCH v2 11/37] binman: Add missing comments toentry X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" At present GetOffsets() lacks a function comment. Add one. Signed-off-by: Simon Glass Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/entry.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/tools/binman/entry.py b/tools/binman/entry.py index d842d89dd66..e8d0adec1e9 100644 --- a/tools/binman/entry.py +++ b/tools/binman/entry.py @@ -355,6 +355,21 @@ class Entry(object): return self.data def GetOffsets(self): + """Get the offsets for siblings + + Some entry types can contain information about the position or size of + other entries. An example of this is the Intel Flash Descriptor, which + knows where the Intel Management Engine section should go. + + If this entry knows about the position of other entries, it can specify + this by returning values here + + Returns: + Dict: + key: Entry type + value: List containing position and size of the given entry + type. + """ return {} def SetOffsetSize(self, pos, size):