From patchwork Sat Jun 15 12:10:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1116387 X-Patchwork-Delegate: xypron.glpk@gmx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="J7PmyiDj"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45QxJt5FRHz9sDX for ; Sat, 15 Jun 2019 22:15:56 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 450E3C21DCA; Sat, 15 Jun 2019 12:15:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 40BEEC21D65; Sat, 15 Jun 2019 12:15:43 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 53966C21D65; Sat, 15 Jun 2019 12:15:41 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by lists.denx.de (Postfix) with ESMTPS id F35F0C21C50 for ; Sat, 15 Jun 2019 12:15:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1560600939; bh=LB9WJF2F8siGTHFv6Yu1914lUAsXLhgRzWbncm2mjpA=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=J7PmyiDjl+MWvDBW7pHlDz38BM5qvtCTXmQGmmnzYm8+WPgGWoIKluBBpYI4z8wn5 Q/1G4rNe5zqTcWNmT8qP9IGfdeHjOVsWB9+jNz/y+gVzMSgcHn692LB9ITxCsRgIxZ SK1TS9TFoBjafITbEojadydwvnw73dDlNQTUrqIM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([84.118.159.3]) by mail.gmx.com (mrgmx003 [212.227.17.184]) with ESMTPSA (Nemesis) id 0LkgAG-1iA5Lu452K-00aV1E; Sat, 15 Jun 2019 14:10:31 +0200 From: Heinrich Schuchardt To: Alexander Graf Date: Sat, 15 Jun 2019 14:10:19 +0200 Message-Id: <20190615121019.20218-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:TMLpet4vtpZh5jPCs3EwwGi9PWODHqGwIsyNsF9Psl8tRsUsOnj fU6WdS3T7DZnz+GfuFVc7tUPw+US/RInSyWd7MntcJfqhFiZqTAXLMw/nw9ynnTA+1k/+lV KCZSEF+cMuFMx7biFrsszOeVahdRo9BQS2QwqNePCYVR+3xVpx34zYFMLfugqFwgIp3QhCG GB3B4SToAU6vRwNi4h+qA== X-UI-Out-Filterresults: notjunk:1; V03:K0:ysL3kj6thko=:S11J9eltHRO+Jf2T1Xp0zM 4i+nV5O5PyswbvZcEQKutTPZkWeh/Up5ZTzcTCy4fHu9rS9z3Bhq3wi5WyMAuJPqAoMemm9h0 J/ZUMv+2w/rv24mkUJDjz3QLIfhHOt4rpIW9jcKZgB2jG1A8zGVCpiTOR7Ik6bKVYg1UMQgKO O4OpEnFqxkvRr9ZgiJUMJTjxLbGicswAYosK5XJ6iMojATG4cVLy9DGAWH9D5I2qSN21aEn3g JRB3yr8J0/ZjYs704+wb2LBkv+7S1x9DV8pEXVCohtDn4q6Qv03dX3x5B9Xe1oiWiYq0hBmSr tpky5tD19YvueIM+i8LMINX1MhWNaQ/M5DBq5lpOgip9+K83zw6BZyu+bOb6QhLpfohINQfZ3 L6Lem12zKWho6PNl9bYcjaXYaGKmMF+FIHym7nQpSMqOaA9kbceL9ds62y3RKemW7d19hb0wY hwcp1IoMP8oZZH4zdsRLyEakHqIv/jgAy/vjaMLtPR3vs5Ln0pJRkRnq7x2ORZKk7Q+2LxK8u h4PQRZUu1EVwRxE6ncOBnyRr5DM2Newk7pYjYi6c/J+pu9fcN7/D9LkItU3ykqFP2dOVg9Leb X8KJ4+gJxPdG6dn8fGhU41w4uF10JXh7vz5+VvDj+O3qFphj9c2/scgAJJL0GxKm4rVa4k87U kAnnMEh5HPL8ozYSeIeIFMHsa0SQ30ArL8zeHZp5nX45f6wqXF8Lmy5wcWMl39VMAgcCHnBN1 2GuB7BxcIGZaIyTc7/HvaYKxfMC0pSAs0xtOrIA/zRXGXB9MFN+3MQ9j4M/NKTz3O30gOgoIC eLDhBtLWsFxK4IOGXDI6b6e5legEzYni20AMAqBXYy0vuD7QjJtdjcrfoNw6pOGjZaNp0UoKI Dpsnt9Byq1A/jcURtRjpYLT+ZHJ+PW6wFGahPfRBUtCW1zWjG7kVi9qdZfE9KNVeyM1oDJJoz uLNvekdeT4dp3LnWGgQ65LXSjCbLgA+SKuwPyKO3ByhyTDwaqc/OX Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [U-Boot] [PATCH 1/1] efi_loader: QueryMode() must allocate buffer X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" EFI_GRAPHICS_OUTPUT_PROTOCOL.QueryMode() must allocate a buffer for the mode information structure. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_gop.c | 6 +++++- lib/efi_selftest/efi_selftest_gop.c | 5 +++++ 2 files changed, 10 insertions(+), 1 deletion(-) -- 2.20.1 diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c index 676463f2de..2385c0f3b1 100644 --- a/lib/efi_loader/efi_gop.c +++ b/lib/efi_loader/efi_gop.c @@ -51,8 +51,12 @@ static efi_status_t EFIAPI gop_query_mode(struct efi_gop *this, u32 mode_number, } gopobj = container_of(this, struct efi_gop_obj, ops); + ret = efi_allocate_pool(EFI_BOOT_SERVICES_DATA, sizeof(gopobj->info), + (void **)info); + if (ret != EFI_SUCCESS) + goto out; *size_of_info = sizeof(gopobj->info); - *info = &gopobj->info; + memcpy(*info, &gopobj->info, sizeof(gopobj->info)); out: return EFI_EXIT(ret); diff --git a/lib/efi_selftest/efi_selftest_gop.c b/lib/efi_selftest/efi_selftest_gop.c index 4ad043c597..d64294ac79 100644 --- a/lib/efi_selftest/efi_selftest_gop.c +++ b/lib/efi_selftest/efi_selftest_gop.c @@ -80,6 +80,11 @@ static int execute(void) } efi_st_printf("Mode %u: %u x %u\n", i, info->width, info->height); + ret = boottime->free_pool(info); + if (ret != EFI_SUCCESS) { + efi_st_printf("FreePool failed"); + return EFI_ST_FAILURE; + } } return EFI_ST_SUCCESS;