From patchwork Mon Jun 3 09:47:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Marginean X-Patchwork-Id: 1109170 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EFmNJKv2"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45HVbs12bVz9s7h for ; Mon, 3 Jun 2019 19:48:08 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 52862C21DA6; Mon, 3 Jun 2019 09:47:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 33F70C21DA6; Mon, 3 Jun 2019 09:47:39 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 2FE17C21D72; Mon, 3 Jun 2019 09:47:38 +0000 (UTC) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by lists.denx.de (Postfix) with ESMTPS id ACFADC21BE5 for ; Mon, 3 Jun 2019 09:47:37 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id e16so3054057wrn.1 for ; Mon, 03 Jun 2019 02:47:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=X8nBJxJK/aKETX8ed40rg+fcbXvICrqW4TY1DUMTurM=; b=EFmNJKv2eJQOuN37WDqJZQAX8VtSpcb3JVi0dmAxHVxMM20lc8UyEj8nuxlKtF8HVe +qI8mK46LhlzfVTylZZkjg3MpE22iX12VRlk2TZrqQSJKieEVMn4hxGNdaLETNA22+xe Vi3Raj6GUlwhPZv+MykgnmF5R0y/VT+zA5/MvlArmD8E52NvWTHYfAkevK2k0KOeMsnk Usz6xIiHoRt1R0AqYxj1ZD5mbjiw+HK9gHIuFjm0XjBvRyMAd8UpGVR61DXcKoCr9ryv dE60Cn2I11LXUvBFIrrJ/icnX6vfUPnvUjNggDyAfWrR/1R+3V1uGjICxTnpHd0HDk1h CIXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=X8nBJxJK/aKETX8ed40rg+fcbXvICrqW4TY1DUMTurM=; b=mIum5DMc7Gcuc4StMSRKSqZzy9E0c1XwM814UI0bWTlriic7LiIsudGt6xHX3l4uGX yonlW3AE/h6LWJ6i+I7cLIzZkdDPfoNOMMX4h2/NCYlLTbaDVzeF6GzseJyOnB6dWcRX IMkWzA/srQR3Pi8v7qWYF87VgyPC1WCgLLLO0ZY1On4AUdsncEWKQQU7eWYE2aTDg8Gh hu/z7iWMPr56Q8xA1tEdG8P6+tx0Zkh9i1+0t63ZgJ3vnDdnBe4db8YmLqKRv6R9VvQM EPfZEar4WvqpPJjhF5hiCcZ+JGQbFVBFvv7Vp1iFGPqs31jSVSCrpdKUibnjsIi8YjMA 8HKQ== X-Gm-Message-State: APjAAAXmc75IxBGVZ2ka8MYNmSctcAM7m3SSLUs9DmfEiul9kLO1l5KI pcraHa2CTNiom2kqLpBOnpUFwpad X-Google-Smtp-Source: APXvYqzwnSKkzVt9Rdkrc6av4jurYsLV5ocqo1iwO9zXLBbSmdX50B1wwQ48O2EkRMMUK+Q2fmM+iw== X-Received: by 2002:a05:6000:10b:: with SMTP id o11mr15693948wrx.337.1559555257058; Mon, 03 Jun 2019 02:47:37 -0700 (PDT) Received: from fsr-ub1864-115.ea.freescale.net ([86.121.167.19]) by smtp.gmail.com with ESMTPSA id n5sm15075283wrj.27.2019.06.03.02.47.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 02:47:36 -0700 (PDT) From: Alex Marginean To: u-boot@lists.denx.de Date: Mon, 3 Jun 2019 12:47:20 +0300 Message-Id: <20190603094720.23503-2-alexm.osslist@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190603094720.23503-1-alexm.osslist@gmail.com> References: <20190531162709.30590-1-alexm.osslist@gmail.com> <20190603094720.23503-1-alexm.osslist@gmail.com> Cc: Joe Hershberger Subject: [U-Boot] [PATCH 2/2 v2] test: dm: add MDIO test X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" A very simple test for DM_MDIO, mimicks a register write/read through the sandbox bus to a dummy PHY. Signed-off-by: Alex Marginean Reviewed-by: Bin Meng Tested-by: Bin Meng --- Changes in v2: - new patch, v1 didn't have a test included arch/sandbox/dts/test.dts | 4 ++ configs/sandbox_defconfig | 2 + drivers/net/Kconfig | 10 +++++ drivers/net/Makefile | 1 + drivers/net/mdio_sandbox.c | 92 ++++++++++++++++++++++++++++++++++++++ test/dm/Makefile | 1 + test/dm/mdio.c | 48 ++++++++++++++++++++ 7 files changed, 158 insertions(+) create mode 100644 drivers/net/mdio_sandbox.c create mode 100644 test/dm/mdio.c diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts index 8b2d6451c6..70b7e4c275 100644 --- a/arch/sandbox/dts/test.dts +++ b/arch/sandbox/dts/test.dts @@ -799,6 +799,10 @@ dmas = <&dma 0>, <&dma 1>, <&dma 2>; dma-names = "m2m", "tx0", "rx0"; }; + + mdio-test { + compatible = "sandbox,mdio_sandbox"; + }; }; #include "sandbox_pmic.dtsi" diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 4877f1099a..2a00df9807 100644 --- a/configs/sandbox_defconfig +++ b/configs/sandbox_defconfig @@ -139,7 +139,9 @@ CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_SPI_FLASH_SST=y CONFIG_SPI_FLASH_WINBOND=y +CONFIG_PHYLIB=y CONFIG_DM_ETH=y +CONFIG_DM_MDIO=y CONFIG_NVME=y CONFIG_PCI=y CONFIG_DM_PCI=y diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 6fba5a84dd..635f8d72c2 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -24,6 +24,16 @@ config DM_MDIO This is currently implemented in net/mdio-uclass.c Look in include/miiphy.h for details. +config MDIO_SANDBOX + depends on DM_MDIO && SANDBOX + default y + bool "Sandbox: Mocked MDIO driver" + help + This driver implements dummy read/write/reset MDIO functions mimicking + a bus with a single PHY. + + This driver is used in for testing in test/dm/mdio.c + menuconfig NETDEVICES bool "Network device support" depends on NET diff --git a/drivers/net/Makefile b/drivers/net/Makefile index 8d02a37896..40038427db 100644 --- a/drivers/net/Makefile +++ b/drivers/net/Makefile @@ -77,3 +77,4 @@ obj-y += ti/ obj-$(CONFIG_MEDIATEK_ETH) += mtk_eth.o obj-y += mscc_eswitch/ obj-$(CONFIG_HIGMACV300_ETH) += higmacv300.o +obj-$(CONFIG_MDIO_SANDBOX) += mdio_sandbox.o diff --git a/drivers/net/mdio_sandbox.c b/drivers/net/mdio_sandbox.c new file mode 100644 index 0000000000..d55a7c4466 --- /dev/null +++ b/drivers/net/mdio_sandbox.c @@ -0,0 +1,92 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * (C) Copyright 2019 + * Alex Marginean, NXP + */ + +#include +#include +#include + +#define SANDBOX_PHY_ADDR 5 +#define SANDBOX_PHY_REG 0 + +struct mdio_sandbox_priv { + int enabled; + u16 reg; +}; + +static int mdio_sandbox_read(struct udevice *dev, int addr, int devad, int reg) +{ + struct mdio_sandbox_priv *priv = dev_get_priv(dev); + + if (!priv->enabled) + return -ENODEV; + + if (addr != SANDBOX_PHY_ADDR) + return -ENODEV; + if (devad != MDIO_DEVAD_NONE) + return -ENODEV; + if (reg != SANDBOX_PHY_REG) + return -ENODEV; + + return priv->reg; +} + +static int mdio_sandbox_write(struct udevice *dev, int addr, int devad, int reg, + u16 val) +{ + struct mdio_sandbox_priv *priv = dev_get_priv(dev); + + if (!priv->enabled) + return -ENODEV; + + if (addr != SANDBOX_PHY_ADDR) + return -ENODEV; + if (devad != MDIO_DEVAD_NONE) + return -ENODEV; + if (reg != SANDBOX_PHY_REG) + return -ENODEV; + + priv->reg = val; + + return 0; +} + +static int mdio_sandbox_reset(struct udevice *dev) +{ + struct mdio_sandbox_priv *priv = dev_get_priv(dev); + + priv->reg = 0; + + return 0; +} + +static const struct mdio_ops mdio_sandbox_ops = { + .read = mdio_sandbox_read, + .write = mdio_sandbox_write, + .reset = mdio_sandbox_reset, +}; + +int mdio_sandbox_probe(struct udevice *dev) +{ + struct mdio_sandbox_priv *priv = dev_get_priv(dev); + + priv->enabled = 1; + + return 0; +} + +static const struct udevice_id mdio_sandbox_ids[] = { + { .compatible = "sandbox,mdio_sandbox" }, + { } +}; + +U_BOOT_DRIVER(mdio_sandbox) = { + .name = "mdio_sandbox", + .id = UCLASS_MDIO, + .of_match = mdio_sandbox_ids, + .probe = mdio_sandbox_probe, + .ops = &mdio_sandbox_ops, + .priv_auto_alloc_size = sizeof(struct mdio_sandbox_priv), +}; diff --git a/test/dm/Makefile b/test/dm/Makefile index 49857c5092..3f042e3ab4 100644 --- a/test/dm/Makefile +++ b/test/dm/Makefile @@ -60,4 +60,5 @@ obj-$(CONFIG_SOUND) += sound.o obj-$(CONFIG_TEE) += tee.o obj-$(CONFIG_VIRTIO_SANDBOX) += virtio.o obj-$(CONFIG_DMA) += dma.o +obj-$(CONFIG_DM_MDIO) += mdio.o endif diff --git a/test/dm/mdio.c b/test/dm/mdio.c new file mode 100644 index 0000000000..aabb8c2d52 --- /dev/null +++ b/test/dm/mdio.c @@ -0,0 +1,48 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * (C) Copyright 2019 + * Alex Marginean, NXP + */ + +#include +#include +#include +#include +#include +#include + +/* macros copied over from mdio_sandbox.c */ +#define SANDBOX_PHY_ADDR 5 +#define SANDBOX_PHY_REG 0 + +#define TEST_REG_VALUE 0xabcd + +static int dm_test_mdio(struct unit_test_state *uts) +{ + struct uclass *uc; + struct udevice *dev; + struct mdio_ops *ops; + u16 reg; + + ut_assertok(uclass_get(UCLASS_MDIO, &uc)); + + ut_assertok(uclass_get_device_by_name(UCLASS_MDIO, "mdio-test", &dev)); + + ops = mdio_get_ops(dev); + ut_assertnonnull(ops); + ut_assertnonnull(ops->read); + ut_assertnonnull(ops->write); + + ut_assertok(ops->write(dev, SANDBOX_PHY_ADDR, MDIO_DEVAD_NONE, + SANDBOX_PHY_REG, TEST_REG_VALUE)); + reg = ops->read(dev, SANDBOX_PHY_ADDR, MDIO_DEVAD_NONE, + SANDBOX_PHY_REG); + ut_asserteq(reg, TEST_REG_VALUE); + + ut_assert(ops->read(dev, SANDBOX_PHY_ADDR + 1, MDIO_DEVAD_NONE, + SANDBOX_PHY_REG) != 0); + + return 0; +} + +DM_TEST(dm_test_mdio, DM_TESTF_SCAN_FDT);