From patchwork Fri May 24 06:59:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AKASHI Takahiro X-Patchwork-Id: 1104653 X-Patchwork-Delegate: xypron.glpk@gmx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="z4M850HG"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 459HLs58T7z9s9N for ; Fri, 24 May 2019 17:00:21 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 5087BC21F3A; Fri, 24 May 2019 06:59:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 2164FC21EFD; Fri, 24 May 2019 06:59:48 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id BBB8FC21F22; Fri, 24 May 2019 06:59:11 +0000 (UTC) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by lists.denx.de (Postfix) with ESMTPS id 81AC0C21E88 for ; Fri, 24 May 2019 06:59:07 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id go2so3769551plb.9 for ; Thu, 23 May 2019 23:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=j86oGgr6y1aw6qr/Uf/69Ymo/u6oABaJvZdSLbildRc=; b=z4M850HG/O7MCiJyX+P4390XqEd6DtJRxtPfIXzcJzBHM8Hg1b9OoB/Y2ChR5PG0pB Qafnx4qgeLYOABZXbed8iCBv4CYxMK4s1sXXQ+XjsKgoQU9adFWpWymdjtC4CMfypr3a 58DCQEfogZawxp7lrY9+mtCOyO/q3Q9FGomo1WdiQbkdLht1iwRdmECS1jun7ZcZOO1X QH0AZ0KXeVDdnpj9jIMIARwHX5iJpd2Hc2Xl/9OOV+oMw+np0Lvb0OwJQb5GnEJNFRc2 Txk/LUvA/+fG+5EEW7WLjIs8ga1/CsIZOCmqHZd4WBNGhVmSB1O0fKNoKlkdMdesDHBE mixw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=j86oGgr6y1aw6qr/Uf/69Ymo/u6oABaJvZdSLbildRc=; b=jMG9jX8z2c1fGJG4aSeai6VJNa2Cpu1hPbz2cLVK2hG6eJXKP5MYZ5V6nHYpWwl+xK HqwW1omKKum7B4cin5hdTH9bxc/dTswGkZEKGEpnh1WvPVAA1BgFIuCC3rRu4TTpE0S2 RKPwBRSjM/h5QUiVfgfpy2jIUo/Nwj182bl1AR3XvnZmYKEkcljTCfvIYQVWVxT46ofv 0001sSAIpRppO14l3/muhDhj1MDl4U9qzZ1KEibwB82hYJHEiH3FS9Al/fFNigjeTDQp SVoavFon53I8SaRSoPEPq/EM7X8z3lmk1IwzGDHb+JqPBYYkL5qmoszc6KMMxh4d6Neq xV8w== X-Gm-Message-State: APjAAAUnwYOKjJVdpwgPJyr1JP9Rx+pIUpcmdkALXH5KpV0RxT8cS0Yr AjJ+4N2BD1TYi9Oi28X5kjVX2w== X-Google-Smtp-Source: APXvYqxRs1BA5kIz3VKiJ6qOGEYqQjlOrdiuxzK0ESdl+9neuclwqfTqe5RZHTH1zBW6lmtjT+jtIA== X-Received: by 2002:a17:902:e60a:: with SMTP id cm10mr94658635plb.316.1558681146169; Thu, 23 May 2019 23:59:06 -0700 (PDT) Received: from linaro.org ([121.95.100.191]) by smtp.googlemail.com with ESMTPSA id u20sm1581102pfm.145.2019.05.23.23.59.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 May 2019 23:59:05 -0700 (PDT) From: AKASHI Takahiro To: xypron.glpk@gmx.de, agraf@csgraf.de Date: Fri, 24 May 2019 15:59:48 +0900 Message-Id: <20190524065948.21566-1-takahiro.akashi@linaro.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Cc: u-boot@lists.denx.de Subject: [U-Boot] [PATCH v2] cmd: env: print a message when setting UEFI variable failed X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Error message will alert a user that setting/deleting a variable failed. Signed-off-by: AKASHI Takahiro --- Changes in v2 (May 24, 2019) * change a message to "Out of memory" * add more error messages --- cmd/nvedit_efi.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/cmd/nvedit_efi.c b/cmd/nvedit_efi.c index 2805e8182b41..88d6ca1cd7f2 100644 --- a/cmd/nvedit_efi.c +++ b/cmd/nvedit_efi.c @@ -373,6 +373,8 @@ int do_env_set_efi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) for ( ; argc > 0; argc--, argv++) if (append_value(&value, &size, argv[0]) < 0) { + printf("## Failed to process an argument, %s\n", + argv[0]); ret = CMD_RET_FAILURE; goto out; } @@ -381,6 +383,7 @@ int do_env_set_efi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) len = utf8_utf16_strnlen(var_name, strlen(var_name)); var_name16 = malloc((len + 1) * 2); if (!var_name16) { + printf("## Out of memory (%ld bytes)\n", (len + 1) * 2); ret = CMD_RET_FAILURE; goto out; } @@ -392,7 +395,13 @@ int do_env_set_efi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, size, value)); - ret = (ret == EFI_SUCCESS ? CMD_RET_SUCCESS : CMD_RET_FAILURE); + if (ret == EFI_SUCCESS) { + ret = CMD_RET_SUCCESS; + } else { + printf("## Failed to set EFI variable (%ld)\n", + ret & ~EFI_ERROR_MASK); + ret = CMD_RET_FAILURE; + } out: free(value); free(var_name16);