From patchwork Sun Apr 28 20:28:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 1092334 X-Patchwork-Delegate: jagannadh.teki@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="N4/zEtFH"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 44sfjS4y0Zz9s47 for ; Mon, 29 Apr 2019 06:37:16 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 52C8EC21DA6; Sun, 28 Apr 2019 20:35:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id B9858C21C93; Sun, 28 Apr 2019 20:35:23 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 8C2D6C21C2F; Sun, 28 Apr 2019 20:29:18 +0000 (UTC) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by lists.denx.de (Postfix) with ESMTPS id 909F4C21DFB for ; Sun, 28 Apr 2019 20:29:14 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id e24so4280976pfi.12 for ; Sun, 28 Apr 2019 13:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TXnmJXWzQZbceoQ13rsAItoSdwmGHt2K3HR8Es2Fhzs=; b=N4/zEtFHreYKyaQzvFmjp7e0rlYK6hKVlJzOtDYTvW6krIIqC9U4uxZSaCL+JEv5Ox xbuWM8SfzH6iuLvajF0UZS7mLXnfjKBzeUI+AzP8krzeVpAGjv3BDmpnJD3zI65X+PNA uaMmfN2M29Ip7h6kIpzzCgmurZofhD111aLwY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TXnmJXWzQZbceoQ13rsAItoSdwmGHt2K3HR8Es2Fhzs=; b=BR943jN6BcbZxs+EM25RpPHYr2E4GWgA97Dgov+IysBC3IcjeLsBb16LmHwGRIJw8B 1QFG3XGhkf1eQCocFHlBZNXBZvVecag4P4iYVjypwE4slNgaLiIY6P4er4rwfP+aB8Gr DboOy9V2peVWIgt1+m5d5ZC4ig5go245KZ3546RivIMpTfafZoCGfZrSJOaEQulcMw7L +9lQsrtRBzY/W5cNQk5gqUSN5UT4bFcAiTzTph/AVSzoR2WsY3X0pLDNvyAjqt1TXLOi RaHMX1VfUAy8fYy+tSNJg3XHCljYv8X5jVIi7nmCz2O/hCQ4xubtakWZDMzZJkpVj3Ua B/Lw== X-Gm-Message-State: APjAAAWPUoS3h8mhKpe7+Ru8+5I8bBzHUmwCS3/Fq/HSDuNZ2A3H7d2D 6Xmed3E6Ikdx0ieQqjNDsRPnjQ== X-Google-Smtp-Source: APXvYqzZlyIWxO2h9RYVOk+E/2alK1QZoM5v88JENfEgp5oMQyJ4kvqas+X7Ef6rquTREPFkey/+qw== X-Received: by 2002:a63:1654:: with SMTP id 20mr10034237pgw.166.1556483353171; Sun, 28 Apr 2019 13:29:13 -0700 (PDT) Received: from localhost.localdomain ([115.97.185.144]) by smtp.gmail.com with ESMTPSA id x66sm68841439pfb.78.2019.04.28.13.29.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Apr 2019 13:29:12 -0700 (PDT) From: Jagan Teki To: Heiko Schocher , Tom Rini Date: Mon, 29 Apr 2019 01:58:38 +0530 Message-Id: <20190428202854.8590-4-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190428202854.8590-1-jagan@amarulasolutions.com> References: <20190428202854.8590-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Cc: u-boot@lists.denx.de, linux-amarula@amarulasolutions.com Subject: [U-Boot] [PATCH v2 03/19] spi: mpc8xxx: Rename camel-case variables X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Mario Six There are three variables that have camel-case names, which is not the preferred naming style. Give those variables more compliant names instead. Signed-off-by: Mario Six --- drivers/spi/mpc8xxx_spi.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c index 3016cfe2ca..0393765b6f 100644 --- a/drivers/spi/mpc8xxx_spi.c +++ b/drivers/spi/mpc8xxx_spi.c @@ -77,9 +77,9 @@ int spi_xfer(struct spi_slave *slave, uint bitlen, const void *dout, void *din, { volatile spi8xxx_t *spi = &((immap_t *) (CONFIG_SYS_IMMR))->spi; uint tmpdout, tmpdin, event; - int numBlks = DIV_ROUND_UP(bitlen, 32); - int tm, isRead = 0; - uchar charSize = 32; + int num_blks = DIV_ROUND_UP(bitlen, 32); + int tm, is_read = 0; + uchar char_size = 32; debug("spi_xfer: slave %u:%u dout %08X din %08X bitlen %u\n", slave->bus, slave->cs, *(uint *) dout, *(uint *) din, bitlen); @@ -91,12 +91,12 @@ int spi_xfer(struct spi_slave *slave, uint bitlen, const void *dout, void *din, spi->event = 0xffffffff; /* Handle data in 32-bit chunks */ - while (numBlks--) { + while (num_blks--) { tmpdout = 0; - charSize = (bitlen >= 32 ? 32 : bitlen); + char_size = (bitlen >= 32 ? 32 : bitlen); /* Shift data so it's msb-justified */ - tmpdout = *(u32 *) dout >> (32 - charSize); + tmpdout = *(u32 *) dout >> (32 - char_size); /* The LEN field of the SPMODE register is set as follows: * @@ -134,15 +134,15 @@ int spi_xfer(struct spi_slave *slave, uint bitlen, const void *dout, void *din, * or time out (1 second = 1000 ms) * The NE event must be read and cleared first */ - for (tm = 0, isRead = 0; tm < SPI_TIMEOUT; ++tm) { + for (tm = 0, is_read = 0; tm < SPI_TIMEOUT; ++tm) { event = spi->event; if (event & SPI_EV_NE) { tmpdin = spi->rx; spi->event |= SPI_EV_NE; - isRead = 1; + is_read = 1; - *(u32 *) din = (tmpdin << (32 - charSize)); - if (charSize == 32) { + *(u32 *) din = (tmpdin << (32 - char_size)); + if (char_size == 32) { /* Advance output buffer by 32 bits */ din += 4; } @@ -153,7 +153,7 @@ int spi_xfer(struct spi_slave *slave, uint bitlen, const void *dout, void *din, * in the future put an arbitrary delay after writing * the device. Arbitrary delays suck, though... */ - if (isRead && (event & SPI_EV_NF)) + if (is_read && (event & SPI_EV_NF)) break; } if (tm >= SPI_TIMEOUT)