diff mbox series

[U-Boot,2/3] i2c: muxes: pca954x: clarify enable field

Message ID 20190405103224.16223-2-luca@lucaceresoli.net
State Superseded
Delegated to: Heiko Schocher
Headers show
Series [U-Boot,1/3] i2c: muxes: pca954x: update list of supported devices | expand

Commit Message

Luca Ceresoli April 5, 2019, 10:32 a.m. UTC
The chip_desc.enable field is used only for muxes, not tor switches.
Document it and remove the unused values.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 drivers/i2c/muxes/pca954x.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Michal Simek April 5, 2019, 10:57 a.m. UTC | #1
On 05. 04. 19 12:32, Luca Ceresoli wrote:
> The chip_desc.enable field is used only for muxes, not tor switches.

typo tor.

M

> Document it and remove the unused values.
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
>  drivers/i2c/muxes/pca954x.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/pca954x.c
> index bd4e9abe5f3c..5669753ce14d 100644
> --- a/drivers/i2c/muxes/pca954x.c
> +++ b/drivers/i2c/muxes/pca954x.c
> @@ -22,7 +22,7 @@ enum pca_type {
>  };
>  
>  struct chip_desc {
> -	u8 enable;
> +	u8 enable; /* Enable mask in ctl register (used for muxes only) */
>  	enum muxtype {
>  		pca954x_ismux = 0,
>  		pca954x_isswi,
> @@ -48,12 +48,10 @@ static const struct chip_desc chips[] = {
>  		.width = 8,
>  	},
>  	[PCA9548] = {
> -		.enable = 0x8,
>  		.muxtype = pca954x_isswi,
>  		.width = 8,
>  	},
>  	[PCA9646] = {
> -		.enable = 0x0,
>  		.muxtype = pca954x_isswi,
>  		.width = 4,
>  	},
>
Heiko Schocher April 9, 2019, 6:04 a.m. UTC | #2
Hello Luca,

Am 05.04.2019 um 12:32 schrieb Luca Ceresoli:
> The chip_desc.enable field is used only for muxes, not tor switches.
> Document it and remove the unused values.
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
>   drivers/i2c/muxes/pca954x.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)

beside the comment from Michal,

Reviewed-by: Heiko Schocher<hs@denx.de>

bye,
Heiko
diff mbox series

Patch

diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/pca954x.c
index bd4e9abe5f3c..5669753ce14d 100644
--- a/drivers/i2c/muxes/pca954x.c
+++ b/drivers/i2c/muxes/pca954x.c
@@ -22,7 +22,7 @@  enum pca_type {
 };
 
 struct chip_desc {
-	u8 enable;
+	u8 enable; /* Enable mask in ctl register (used for muxes only) */
 	enum muxtype {
 		pca954x_ismux = 0,
 		pca954x_isswi,
@@ -48,12 +48,10 @@  static const struct chip_desc chips[] = {
 		.width = 8,
 	},
 	[PCA9548] = {
-		.enable = 0x8,
 		.muxtype = pca954x_isswi,
 		.width = 8,
 	},
 	[PCA9646] = {
-		.enable = 0x0,
 		.muxtype = pca954x_isswi,
 		.width = 4,
 	},