From patchwork Tue Mar 19 19:12:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1058649 X-Patchwork-Delegate: xypron.glpk@gmx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="SpNDQgMJ"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 44P2kW403kz9s47 for ; Wed, 20 Mar 2019 06:12:49 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 12283C21FFB; Tue, 19 Mar 2019 19:12:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 74D69C21F99; Tue, 19 Mar 2019 19:12:42 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 823F5C21F99; Tue, 19 Mar 2019 19:12:40 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by lists.denx.de (Postfix) with ESMTPS id 35DD4C21F8E for ; Tue, 19 Mar 2019 19:12:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1553022758; bh=fvotb8ZLm2pA0kWByaurzzck0M7kq1w6Xu6ygx5Qdp4=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=SpNDQgMJJ0CbMbfqvEc2wcWDA75LS0w4sQybWHYwJhB5u8gtdOJTW5TFVBKpvU5vK eh++Sj7NTH9FJSdWWT7FSLRtGhHpAI6+pUIsICAxaxw5RjqzkJsi/pBaBIZphPMFpt 6hEINKQnBz0OxerdC9UkdkhKXCAd3Bv7FcHYRY6g= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([84.118.159.3]) by mail.gmx.com (mrgmx001 [212.227.17.184]) with ESMTPSA (Nemesis) id 0LfkUs-1geLro1Tkg-00pKX1; Tue, 19 Mar 2019 20:12:38 +0100 From: Heinrich Schuchardt To: Alexander Graf Date: Tue, 19 Mar 2019 20:12:33 +0100 Message-Id: <20190319191233.17633-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:HZ3/mLz2aTxpl1t+AlBizlaMK9Gr8+hodow2Fiivk0z6exjuRtZ qkeCLrik3Ps8Q6+DORkcy+eQDf9dnDKncYz1SAHsrn0qetc5xiCizbc7MeywOuCSBQxp0QZ N3Pg6bMJyoDSxHrCzjfCi/7lVSV+GiKbv1oUxtCDVBSUSeDhm5oSoe2tBZIHDIhfQvIny5l 9ffU5oRxK7S5et95Dul6w== X-UI-Out-Filterresults: notjunk:1; V03:K0:FrzQVbVs50Y=:NrXOOPJOL1cDhblcvfVjs8 o+ovJD0rZnatgF186Vr+kl6HUCCUL+d73as0DD6efhhKpp9SAEMI+fifTphvu/BMkpuantc7N UYlFHNB6XlFSsNx0lgZgqMGovPZ7OQzj6ND7TnuwiONBipPPjS9vDk4hAhaX7MaFwKfKqDWgL SkMlKGs1Xft5upK+phs5yKtS9pa1M4oTVOhHciOwwcpSyjX5u09t2DdPR1Vbetg/lLB35J+3s K0JgBEMiAmhGhpjVAJathG6tVrt3o7N+0arpUUH+Hb0A8wBlfcC9OQV75qRysbPlY66Mah3E4 XlDFntkRGCSEhHtRiwtZ+Mr+8UrgUANXAWaGlhUwi1sN4x3yzGRCsLIFEVXrEkQcy7j8b5AvG dduygCZ+hVQjyO0zYQF7gfJifNALi+h/oyEnX7iOWxfDAdUaT5BJg+ztATVcWzW4Jh+QO5AUT zgkfrwJa1aBIL+ttqEProthoWGqsV07pwVDHx75uOZbtdhBdffiVUWa4+EsA7iRbtWrhoaWa+ 5qT/nJRWESw8q1j5wi9OpHrJtVHobobBGuSxtYKTRguILxaJzj+GYSKJKokKsXATYGdjl0mUF CEZpOpLphfMENURuCIvCuImWuXwgSsUZqnDcfjZHaoGB4oMPJjZt6lDQIqck3DLgaicp1gGNX SmPoiahRmhHSRfafImUKK5X7Mzq9Qdk86MIqEsAvh+Fkpz5L/EeSnL4+KGKg1/pgUTwtgZ1BY aDvOjMhYTZzKdxsaqFq7wXHlltTqw1sArZHj4Qv8mT7Vwp6fRe3DgXnOx1h/X9UwWACw56ynD cOD+LCnM57ebvvCmaJm2Xed14DzwGHbgeD1fRRvdOjwXsrO7etIju3zC6K1V+Kxj02ATNBZ2m PpB86IyX684qPMohdWTPZSX3IiCM6jv9Rgz4MoS6p25uQgS9xfT3BH//nb7mJE Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [U-Boot] [PATCH 1/1] efi_selftest: fix test_hii_string_get_string() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The check testing the string result of get_string() returned the wrong result. The result was ignored. Use efi_st_strcmp_16_8() for the string comparison. Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/efi_selftest_hii.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) -- 2.20.1 diff --git a/lib/efi_selftest/efi_selftest_hii.c b/lib/efi_selftest/efi_selftest_hii.c index 8a0b3bc3536..f4b70f79508 100644 --- a/lib/efi_selftest/efi_selftest_hii.c +++ b/lib/efi_selftest/efi_selftest_hii.c @@ -783,19 +783,10 @@ static int test_hii_string_get_string(void) goto out; } -#if 1 - u16 *c1, *c2; - - for (c1 = string, c2 = L"Japanese"; *c1 == *c2; c1++, c2++) - ; - if (!*c1 && !*c2) - result = EFI_ST_SUCCESS; - else - result = EFI_ST_FAILURE; -#else - /* TODO: %ls */ - efi_st_printf("got string is %s (can be wrong)\n", string); -#endif + if (efi_st_strcmp_16_8(string, "Japanese")) { + efi_st_error("get_string returned incorrect string\n"); + goto out; + } result = EFI_ST_SUCCESS;