From patchwork Mon Feb 25 08:15:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1047623 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="nfK3L7cN"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="OZdQrOGa"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 447FHv5xJYz9s9T for ; Mon, 25 Feb 2019 19:20:27 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 6388FC21D8E; Mon, 25 Feb 2019 08:20:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAD_ENC_HEADER, KHOP_BIG_TO_CC, RCVD_IN_DNSWL_BLOCKED, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 17ABAC21D4A; Mon, 25 Feb 2019 08:15:24 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id C6DDEC21D83; Mon, 25 Feb 2019 08:15:19 +0000 (UTC) Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by lists.denx.de (Postfix) with ESMTPS id E9B74C21DB5 for ; Mon, 25 Feb 2019 08:15:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1551082512; x=1582618512; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AGopGUiXazjgN5ZuY1nzw0BAbdwpOrkv1RV7FfRgwcQ=; b=nfK3L7cNIt/Ot/DzEdhrqWlfnE2/ryJrc+ySYKDPFX1HPxBwr5wu/my9 97yUsTlhZzrl8efKxdEgTT/mhVXRO0o7/owO0FrJXP3Z05z/YKDbz2td7 XfUE8VY2z8mWA6bNWh1Apt4hckPz7R0Tf3RVBjkhpUOIPSMN+wdi5x3H+ t0a6xJnc9ZUnaDcfn4Ap+M8q4BY6S55UT6+HmMIwXoCPjjvQ6uok7AWPb ycUMklyG+h/UN4QUgKHovd7vxcxrsj7gQIaul+Sda85kaHunlE5Uo4awx 5CF9I9LcN6Fpl0gdJL0YI98yPzXY65clZ6gx5ae/YfjBza1ILOGwV2szl A==; X-IronPort-AV: E=Sophos;i="5.58,410,1544457600"; d="scan'208";a="102080782" Received: from mail-dm3nam03lp2056.outbound.protection.outlook.com (HELO NAM03-DM3-obe.outbound.protection.outlook.com) ([104.47.41.56]) by ob1.hgst.iphmx.com with ESMTP; 25 Feb 2019 16:15:09 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u0pk+m+saWEBpumb8AcuizP7KdgAEiXUxCJ16WAWEek=; b=OZdQrOGanDoKaf42wlJJ49iZNlcNqS/xlDuggXRFOqL69zQPYxVC/4JATl/w0S224ak1bsNj4/rv67K0I/xu4YfvJXRex3gpx8RXQxrTDc8mpOi8cgqtLFXoC/f8KJTdx+sNOL6Wj5jt6bKWB6XzQLUQSzbj9EspSeyHLztSRGg= Received: from MN2PR04MB6061.namprd04.prod.outlook.com (20.178.246.15) by MN2PR04MB5789.namprd04.prod.outlook.com (20.179.20.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.15; Mon, 25 Feb 2019 08:15:08 +0000 Received: from MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::d197:7b59:7e0d:e819]) by MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::d197:7b59:7e0d:e819%3]) with mapi id 15.20.1643.019; Mon, 25 Feb 2019 08:15:08 +0000 From: Anup Patel To: Rick Chen , Bin Meng , Joe Hershberger , Michal Simek , Michal Simek , Lukas Auer , Masahiro Yamada , Simon Glass Thread-Topic: [PATCH v10 11/15] drivers: serial_sifive: Skip baudrate config if no input clock Thread-Index: AQHUzOI4UcFhaOpcMEuHb6MHGzHrnw== Date: Mon, 25 Feb 2019 08:15:08 +0000 Message-ID: <20190225081334.23256-12-anup.patel@wdc.com> References: <20190225081334.23256-1-anup.patel@wdc.com> In-Reply-To: <20190225081334.23256-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: TYAPR01CA0069.jpnprd01.prod.outlook.com (2603:1096:404:2b::33) To MN2PR04MB6061.namprd04.prod.outlook.com (2603:10b6:208:d8::15) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [129.253.179.161] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2b0806ac-7be9-43e5-0ed4-08d69af95a91 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:MN2PR04MB5789; x-ms-traffictypediagnostic: MN2PR04MB5789: wdcipoutbound: EOP-TRUE x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; MN2PR04MB5789; 23:DPXDK6RkrGg+l4RRZN2JI4QzXkeQ5EnZ2WNHl+n?= =?iso-8859-1?q?b3tMFBIkvX47Ye49v0BWkUQgv?= =?iso-8859-1?q?LbKV0XVYNf+YWFIP7pnL5JStDL2Mv6VOA+73h5lwQ/w6g9Sc64N?= =?iso-8859-1?q?jY36VZ1zOK9QNs0QKSyH9RTnre3OrufwYiIgtZkQFIEEIakBpyT?= =?iso-8859-1?q?vPmN5URZ6eCqZcWQW4TRAc1L01aiS4AP8VpjjcVZQyokAdK3NrN?= =?iso-8859-1?q?/qRs9SstmpHCf3X1Usx/o24slMiFX+1uzkfR1mSEHs+U9qbvKM7?= =?iso-8859-1?q?69TProMJIjfv33zDU9t/seQBVXfDPScQD0iFrqM4kyO3Y9wDC0s?= =?iso-8859-1?q?j25DZr7r+LdfAKaYDTXFzOktY6F1OYDkA4BMoVjgVtuMSoArpiN?= =?iso-8859-1?q?av1JmvBiGa75V18xUXUHpJoQBBwRZ9l/MJ/7x8A/Giv3lnK2alv?= =?iso-8859-1?q?djVmPgttN+6R9nDtltq+Q1mHp6ueFc5+0kdhATa+Cx8BpTG4QSc?= =?iso-8859-1?q?yI3lxjJyboUJynsZ5MPZrq2UFlaJe4kQgZBv9DyAaX3iQp/ehFZ?= =?iso-8859-1?q?pO3w8PbYFNDySJwMYwSCFifsQ8aD4juozyPl8CplgRdCUkWggdd?= =?iso-8859-1?q?j4vdkLgIWAZ5Gr6vAkBY7WcXAaeahWRKHj217RVqsPdNoJsPmBH?= =?iso-8859-1?q?x85NPAVJ00L1yNKLDr/hcQ8XGp5rcBV/wW+2kkyk53v0nFebOLA?= =?iso-8859-1?q?2+lo3D15Mng6Vjh1fp9hMLxR0YsHaFqczuop7kb1yHP15h7/0cJ?= =?iso-8859-1?q?4eXal5VbdBFND+O6TTiZ5uZiusDKNeuEHeZuf0stE193oS7gxZA?= =?iso-8859-1?q?eLW47VMq6xD0TFgQeg/z8/aGw7yb4e2aDCZPfPmt99HIZ1VLXs5?= =?iso-8859-1?q?R9ddjqg4gX0m2pQub2WPNuaTJjXzDblohrwqMyT5t8f/yUtlwB8?= =?iso-8859-1?q?goiUsuQI+XUWpqh8LQdI1xnfwyHVcBpODiSm8WodHp75Y73OwYQ?= =?iso-8859-1?q?OKSM+3cdX1w5Z+D9MlnNfwLF9zhVWwapQeL3vc54nieBBITatrt?= =?iso-8859-1?q?jzPIC0nOsxmTMoI3OAnwuo2hwacRsmujyEMOhRmZA1UI2UbyBsi?= =?iso-8859-1?q?xHSCtD4Nmy/Y0Hqg3auw8uicl+VXp8Z+ut+LPKwTXVpDd1/38VM?= =?iso-8859-1?q?gEc/JuWccxVQtNA9L/Oprfiq15KStkD7AxJZ/SgTf/DFveaNquj?= =?iso-8859-1?q?hfHjW0leBbaSdEWCGZrqCZf16qmPXTogrRTZzATAfucPT8FJ7y0?= =?iso-8859-1?q?vE+rCgws4I5tWEpFxLjByiTKofwBSyQIO4xn201UI4WaiMpKG2I?= =?iso-8859-1?q?eud+GcrmFhIWdyXiAJgfDtjUWhNvCPfk7Bz5/1swEwHp9lFeAFi?= =?iso-8859-1?q?iImAMannWWp+PQ=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 095972DF2F x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(346002)(396003)(366004)(39860400002)(136003)(189003)(199004)(66066001)(6512007)(186003)(53936002)(7736002)(305945005)(44832011)(478600001)(106356001)(26005)(486006)(2616005)(476003)(105586002)(7416002)(5660300002)(14454004)(6506007)(386003)(72206003)(8676002)(86362001)(54906003)(110136005)(81156014)(71190400001)(316002)(102836004)(6346003)(71200400001)(81166006)(1076003)(36756003)(25786009)(99286004)(97736004)(52116002)(50226002)(76176011)(2906002)(8936002)(11346002)(6486002)(6436002)(4326008)(68736007)(446003)(256004)(6116002)(3846002); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR04MB5789; H:MN2PR04MB6061.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: xLSw6juKMLgPcstdBWMTBeHUxbBQ+bV0ne8pAYCUKLPAIcdXWx+cJArwQ0Y7LoMG6U5sPeZ8jD/H7BuPYctQE0ygfqbcn0lpvFnufGJU8pEx6KEI8LIyRvDQUZ4RTho6lYcTezpUKFuW8pQpwooun/3LGqn3vZaTqUHUmycGZbtJ/DP/dadw4EpMU7NvEvx4Afdpfz/dv8tEf/IVzwSU1bLZOw6RJdWNI49cnA0MlIJRnCDvmrg7yx41gbHOLCQJ2a3D8wVK+Pu2RU/uUU644N5kzjvB1CoezCiMD152yfYRGnzfZ50c7SXdKza6osxw6D0gmavFn0JlyLBJwciNNJ/E3UoHUMGHSq+m7GlPmaKa3+ewgXd4G5tyrBGVcst4+EU5Ry4byE52sZ7ibYGzZhRdRkVj4O80X/T3Rr6M+SY= MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b0806ac-7be9-43e5-0ed4-08d69af95a91 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2019 08:15:03.2162 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5789 Cc: Palmer Dabbelt , Alexander Graf , U-Boot Mailing List Subject: [U-Boot] [PATCH v10 11/15] drivers: serial_sifive: Skip baudrate config if no input clock X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Atish Patra It is possible that input clock is not available because clk device was not available and 'clock-frequency' DT property is also not available. In this case, instead of failing we should just skip baudrate config by returning zero. Signed-off-by: Atish Patra Signed-off-by: Anup Patel Reviewed-by: Alexander Graf --- drivers/serial/serial_sifive.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/serial/serial_sifive.c b/drivers/serial/serial_sifive.c index ea4d35d48c..537bc7a975 100644 --- a/drivers/serial/serial_sifive.c +++ b/drivers/serial/serial_sifive.c @@ -99,27 +99,27 @@ static int _sifive_serial_getc(struct uart_sifive *regs) static int sifive_serial_setbrg(struct udevice *dev, int baudrate) { - int err; + int ret; struct clk clk; struct sifive_uart_platdata *platdata = dev_get_platdata(dev); + u32 clock = 0; - err = clk_get_by_index(dev, 0, &clk); - if (!err) { - err = clk_get_rate(&clk); - if (!IS_ERR_VALUE(err)) - platdata->clock = err; - } else if (err != -ENOENT && err != -ENODEV && err != -ENOSYS) { + ret = clk_get_by_index(dev, 0, &clk); + if (IS_ERR_VALUE(ret)) { debug("SiFive UART failed to get clock\n"); - return err; - } - - if (!platdata->clock) - platdata->clock = dev_read_u32_default(dev, "clock-frequency", 0); - if (!platdata->clock) { - debug("SiFive UART clock not defined\n"); - return -EINVAL; + ret = dev_read_u32(dev, "clock-frequency", &clock); + if (IS_ERR_VALUE(ret)) { + debug("SiFive UART clock not defined\n"); + return 0; + } + } else { + clock = clk_get_rate(&clk); + if (IS_ERR_VALUE(clock)) { + debug("SiFive UART clock get rate failed\n"); + return 0; + } } - + platdata->clock = clock; _sifive_serial_setbrg(platdata->regs, platdata->clock, baudrate); return 0;