From patchwork Fri Feb 22 13:37:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ismael Luceno Cortes X-Patchwork-Id: 1046821 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=silicon-gears.com Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 445XT24wQZz9s21 for ; Sat, 23 Feb 2019 00:37:22 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id DB1A1C21D8A; Fri, 22 Feb 2019 13:37:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id ECF13C21C93; Fri, 22 Feb 2019 13:37:12 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id B2386C21C93; Fri, 22 Feb 2019 13:37:11 +0000 (UTC) Received: from mx1.silicon-gears.com (mx1.silicon-gears.com [81.47.169.96]) by lists.denx.de (Postfix) with ESMTPS id 5D1B7C21BE5 for ; Fri, 22 Feb 2019 13:37:11 +0000 (UTC) From: Ismael Luceno Cortes To: "u-boot@lists.denx.de" Thread-Topic: [PATCH v2] cmd: clk: Handle ENODEV from clk_get_rate Thread-Index: AQHUyrO0lqP5sJsAzEu5YP4Tgk9r4g== Date: Fri, 22 Feb 2019 13:37:08 +0000 Message-ID: <20190222133700.18499-1-ismael.luceno@silicon-gears.com> Accept-Language: en-GB, es-ES, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-User-Approved-Sender: Yes;No X-TMASE-Result: 10-1.476600-10.000000 X-TMASE-MatchedRID: bk2QpUPDfamZP/E4Q97hKZyBsp6+TmyGgGa+oYp5i6qpFqY8JHz7MBFu p4CINH3Jeh2c8viUKTsuqKKqdUbdyPvlwQ3r+q9MngIgpj8eDcCEYGTT/umyEsRB0bsfrpPInxM yeYT53RlJsfiO8wGgFRX+OZOOZb3Vk9eTCcR/xrswfX7slYCw2RVRUyHIOlikMbWPajEI7JI6Ds JDlRvrOtFAIqj8bxU65T7E7EljWssVrF5acJLxmyW9IBbILc6d46pgtcXT03Xyd7w6XNKfQcPIN hwTXBeZ X-IMSS-DKIM-White-List: No;No X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0-0 Cc: Matthias Brugger Subject: [U-Boot] [PATCH v2] cmd: clk: Handle ENODEV from clk_get_rate X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" clk_get_rate may return -ENODEV if the clock isn't valid. Also, make all the error cases go through a single path. Signed-off-by: Ismael Luceno Reviewed-by: Matthias Brugger --- CC: Matthias Brugger Notes: Changes since v1: - Added further explanation to the commit message. cmd/clk.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/cmd/clk.c b/cmd/clk.c index fd4231589c..41f2ae0a50 100644 --- a/cmd/clk.c +++ b/cmd/clk.c @@ -26,20 +26,23 @@ int __weak soc_clk_dump(void) uclass_foreach_dev(dev, uc) { memset(&clk, 0, sizeof(clk)); ret = device_probe(dev); - if (ret) { - printf("%-30.30s : ? Hz\n", dev->name); - continue; - } + if (ret) + goto noclk; ret = clk_request(dev, &clk); - if (ret) { - printf("%-30.30s : ? Hz\n", dev->name); - continue; - } - - printf("%-30.30s : %lu Hz\n", dev->name, clk_get_rate(&clk)); + if (ret) + goto noclk; + ulong rate = clk_get_rate(&clk); clk_free(&clk); + + if (rate == -ENODEV) + goto noclk; + + printf("%-30.30s : %lu Hz\n", dev->name, rate); + continue; + noclk: + printf("%-30.30s : ? Hz\n", dev->name); } return 0;