From patchwork Thu Feb 14 15:58:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Nazzareno Trimarchi X-Patchwork-Id: 1042262 X-Patchwork-Delegate: jagannadh.teki@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="ijp1rCM6"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 440h0G5X2tz9sN4 for ; Fri, 15 Feb 2019 02:59:10 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 651A4C2209D; Thu, 14 Feb 2019 15:58:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 98198C22082; Thu, 14 Feb 2019 15:58:43 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 55895C21F69; Thu, 14 Feb 2019 15:58:40 +0000 (UTC) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by lists.denx.de (Postfix) with ESMTPS id 43CC6C21F69 for ; Thu, 14 Feb 2019 15:58:37 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id f16so6597316wmh.4 for ; Thu, 14 Feb 2019 07:58:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3KQz6LfW8sk1IHkep4P3xfGZdL9Hi7BBwlFznNbY8zw=; b=ijp1rCM6NDxA880VGaP0/DJZdJjIlOggeWH0fEZe4Gf6EOfXCxrZzHf4N1cSBqkaT6 l0+7DHYVC0glosk1cgbQdlUCQq6EuA4GBjgB2pH6YDRf/2w5jPCjCLDcyBNC8lm65jYL piUKU9T6ME1gPWtxtLlfAYtk+Gaq6G2EHmHg8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3KQz6LfW8sk1IHkep4P3xfGZdL9Hi7BBwlFznNbY8zw=; b=MjYdQqy0+J7SNsT7MeydLEEs2Oeude8itsJc3jp4XjMti5yK9CUWemx1n+SQtUiUN6 nGoVjU1p1zm0m3d+Lx5kkM/ER/04/oGBiLDQC06N6aBHRGndo1Ao5SVnWgVYLIrS9ckC fl9LMQKnsOoDyiCYJ2ZT0q479NXqkMOt8R+xr++W1XzVeqji03qFOxOByoq73ar0odvS 3zknQI8J8vM+5ARoR4RIFyW2IxCYDvJdarGy4ovgDmJgDVtUz7gs4q/XSyvWjrUBxbD0 2SflBDjIIPd57QuvhhJ5rsiFIiCVNBli6U7FePNer91ddNP3hxXG/mKyR99vcFLGzvmu IcBA== X-Gm-Message-State: AHQUAuaZahhGk7vNci3BbtLQ9cRgjthN4MZMeO9ThYJYezRjggCD4u9/ 4+KBdRyNJvLqCE6dLwCTH8hvhQ== X-Google-Smtp-Source: AHgI3IaCSKir8w+ZdpXjHN56J8scdoN+TwGmtXcMuWiDumVo/ufdi2tnXCgasc2mTnTtbnLQjQc6hw== X-Received: by 2002:a1c:b189:: with SMTP id a131mr3383633wmf.38.1550159916527; Thu, 14 Feb 2019 07:58:36 -0800 (PST) Received: from localhost.localdomain (host211-95-static.0-79-b.business.telecomitalia.it. [79.0.95.211]) by smtp.gmail.com with ESMTPSA id b12sm2406123wmj.3.2019.02.14.07.58.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 07:58:35 -0800 (PST) From: Michael Trimarchi To: Maxime Ripard , Jagan Teki Date: Thu, 14 Feb 2019 16:58:32 +0100 Message-Id: <20190214155833.11984-2-michael@amarulasolutions.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190214155833.11984-1-michael@amarulasolutions.com> References: <20190214155833.11984-1-michael@amarulasolutions.com> Cc: andre.przywara@arm.com, u-boot@lists.denx.de Subject: [U-Boot] [PATCH V2 2/3] sunxi: Don't change the rank in dram size detection in A33 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Change the size create a glitch in the clken signal on second bank. According to the ddr manual the clken need to be sent accros the reset signal coming the cpu. The rank is calculated just before this function is called and the mctl_set_cr should not change this value anymore Signed-off-by: Michael Trimarchi --- V1->V2: Adjust commit description --- arch/arm/mach-sunxi/dram_sun8i_a33.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/mach-sunxi/dram_sun8i_a33.c b/arch/arm/mach-sunxi/dram_sun8i_a33.c index 83212aaddf..d73a93a132 100644 --- a/arch/arm/mach-sunxi/dram_sun8i_a33.c +++ b/arch/arm/mach-sunxi/dram_sun8i_a33.c @@ -45,14 +45,12 @@ static void mctl_set_cr(struct dram_para *para) static void auto_detect_dram_size(struct dram_para *para) { - u8 orig_rank = para->rank; int rows, columns; /* Row detect */ para->page_size = 512; para->seq = 1; para->rows = 16; - para->rank = 1; mctl_set_cr(para); for (rows = 11 ; rows < 16 ; rows++) { if (mctl_mem_matches(1 << (rows + 9))) /* row-column */ @@ -69,7 +67,6 @@ static void auto_detect_dram_size(struct dram_para *para) } para->seq = 0; - para->rank = orig_rank; para->rows = rows; para->page_size = 1 << columns; mctl_set_cr(para);