From patchwork Fri Feb 8 17:42:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 1038878 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ziswiler.com Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43x2sc6BwLz9sN1 for ; Sat, 9 Feb 2019 04:55:48 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 58F5EC22097; Fri, 8 Feb 2019 17:47:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id AC448C22086; Fri, 8 Feb 2019 17:43:37 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 3AF3BC22064; Fri, 8 Feb 2019 17:43:04 +0000 (UTC) Received: from mout.perfora.net (mout.perfora.net [74.208.4.194]) by lists.denx.de (Postfix) with ESMTPS id 4D219C22019 for ; Fri, 8 Feb 2019 17:43:00 +0000 (UTC) Received: from localhost.localdomain ([81.221.139.23]) by mrelay.perfora.net (mreueus002 [74.208.5.2]) with ESMTPSA (Nemesis) id 0LfRNf-1hT5QU3snR-00p2UC; Fri, 08 Feb 2019 18:42:56 +0100 From: Marcel Ziswiler To: u-boot@lists.denx.de Date: Fri, 8 Feb 2019 18:42:20 +0100 Message-Id: <20190208174229.23562-18-marcel@ziswiler.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190208174229.23562-1-marcel@ziswiler.com> References: <20190208174229.23562-1-marcel@ziswiler.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:Li8X1xVjhplOtqPGuhYMZAlpvIudNv8H/h0Xi7fZrMN2lqiICcl D5K4PpOyiCgnzpe+6T0Qy9SPII4skXOkGH461kpF7Wdf4xe4EFFoiVQteC3QMiUqOiXozPM gOjbN0BDjQncX+uUc9Dx/ZuCC7AVZe0RIhWTexRnsKaBbr3vF+hXJn9irxjfFa31yDzcYVq Bjv/owtZEPqX7uKDM6Icw== X-UI-Out-Filterresults: notjunk:1; V03:K0:vaJb+v7AsWw=:gslner6LJZxPFhyJM53KDn YKZkPIK0MDIpwL1FOqvaj4CP0oR90DKtlVgwb6rsYNsAw08F7TBSb9P6/hpq9Mtdc4zjgWTqP 8b9ixm9191odft9oqAU093svMpOKNway6q4pXUyKQpvGvLuPesHKMPb609mZbscXlMjTN2aEZ FH1ZEqoNHYlvvPhqY1BpeEBLsWcvO4Ej6sQLqc6GM7U6/TiQD7tPaXKwWAL0Ed9XekHXbx6hf m98+NcLe9ZyJlce8WXjOXfkdXFqYRr32SRjoSObgO4K1iQfgAIxT7JKoYM9WOqcxc69H3xnWV Hfnqd2E6X2UHfygtutlwQSAhskNjGzM+YnWVrvVHOsWoKN0Ot60ZFhTh9TjgN6C9l3V2cOMsI /EERIzhxZX1xt0UQjmhkfY3FCEWqyoKuavLuZcw7FXb0qhEliLSyBkZb5oHle9xy3aJCCug3w 7VhnqVSypHswQMF5BEsCbQ4wwBy7gT76pETqsAUj67YZhZWB75E9CDFNU0GZNHjXbM7/XUHiA eZgX2Ncrb3kuUMHutDe1nMqAuYGe3aQ0oNTFkTPHSdRQh0BrYDNOv1lDS3jOz85/8jwxzK+PK sHPProeZafvPPP4umb85S7IG17hl+CXDJOT52eVCopNBSzBfs+nBU13z/TZmNy8YF4TmWSFo9 QtLHM2uOJrZWMiJq719dXkK4RePAk2khNJNkiebrxKqqjclL4PFlOwyzo2YCRPcRkSkw28LAQ lyjFqaOAcpImCzGieqbHeCsOWcL9Sm5ECbNOeQ== Cc: Marcel Ziswiler , Max Krummenacher Subject: [U-Boot] [PATCH v1 17/26] colibri imx6: pf0100: reorder and cleanup message printing X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Max Krummenacher Keep debug code at the end of the function. Use a one line informational message for the PMIC only. Signed-off-by: Max Krummenacher Acked-by: Marcel Ziswiler --- board/toradex/colibri_imx6/pf0100.c | 82 ++++++++++++++--------------- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/board/toradex/colibri_imx6/pf0100.c b/board/toradex/colibri_imx6/pf0100.c index 5e411f1743..09c3cc950a 100644 --- a/board/toradex/colibri_imx6/pf0100.c +++ b/board/toradex/colibri_imx6/pf0100.c @@ -35,7 +35,7 @@ unsigned pmic_init(void) uchar bus = 1; uchar devid, revid, val; - puts("PMIC: "); + puts("PMIC: "); rc = i2c_get_chip_for_busnum(bus, PFUZE100_I2C_ADDR, 1, &dev); if (rc) { printf("failed to get device for PMIC at address 0x%x\n", @@ -51,7 +51,46 @@ unsigned pmic_init(void) puts("i2c pmic revid read failed\n"); return 0; } - printf("device id: 0x%.2x, revision id: 0x%.2x\n", devid, revid); + printf("device id: 0x%.2x, revision id: 0x%.2x, ", devid, revid); + + /* get device programmed state */ + val = PFUZE100_PAGE_REGISTER_PAGE1; + if (dm_i2c_write(dev, PFUZE100_PAGE_REGISTER, &val, 1)) { + puts("i2c write failed\n"); + return 0; + } + if (dm_i2c_read(dev, PFUZE100_FUSE_POR1, &val, 1) < 0) { + puts("i2c fuse_por read failed\n"); + return 0; + } + if (val & PFUZE100_FUSE_POR_M) + programmed++; + + if (dm_i2c_read(dev, PFUZE100_FUSE_POR2, &val, 1) < 0) { + puts("i2c fuse_por read failed\n"); + return programmed; + } + if (val & PFUZE100_FUSE_POR_M) + programmed++; + + if (dm_i2c_read(dev, PFUZE100_FUSE_POR3, &val, 1) < 0) { + puts("i2c fuse_por read failed\n"); + return programmed; + } + if (val & PFUZE100_FUSE_POR_M) + programmed++; + + switch (programmed) { + case 0: + puts("not programmed\n"); + break; + case 3: + puts("programmed\n"); + break; + default: + puts("undefined programming state\n"); + break; + } #ifdef DEBUG { @@ -103,45 +142,6 @@ unsigned pmic_init(void) } #endif /* DEBUG */ - /* get device programmed state */ - val = PFUZE100_PAGE_REGISTER_PAGE1; - if (dm_i2c_write(dev, PFUZE100_PAGE_REGISTER, &val, 1)) { - puts("i2c write failed\n"); - return 0; - } - if (dm_i2c_read(dev, PFUZE100_FUSE_POR1, &val, 1) < 0) { - puts("i2c fuse_por read failed\n"); - return 0; - } - if (val & PFUZE100_FUSE_POR_M) - programmed++; - - if (dm_i2c_read(dev, PFUZE100_FUSE_POR2, &val, 1) < 0) { - puts("i2c fuse_por read failed\n"); - return programmed; - } - if (val & PFUZE100_FUSE_POR_M) - programmed++; - - if (dm_i2c_read(dev, PFUZE100_FUSE_POR3, &val, 1) < 0) { - puts("i2c fuse_por read failed\n"); - return programmed; - } - if (val & PFUZE100_FUSE_POR_M) - programmed++; - - switch (programmed) { - case 0: - printf("PMIC: not programmed\n"); - break; - case 3: - printf("PMIC: programmed\n"); - break; - default: - printf("PMIC: undefined programming state\n"); - break; - } - return programmed; }