From patchwork Thu Jan 24 14:29:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 1030483 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ziswiler.com Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43ll2n1JvKz9s4s for ; Fri, 25 Jan 2019 01:31:29 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id E5159C21D65; Thu, 24 Jan 2019 14:30:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 4598AC21DA6; Thu, 24 Jan 2019 14:30:21 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id D3685C21DFB; Thu, 24 Jan 2019 14:30:15 +0000 (UTC) Received: from mout.perfora.net (mout.perfora.net [74.208.4.194]) by lists.denx.de (Postfix) with ESMTPS id E4447C21DA2 for ; Thu, 24 Jan 2019 14:30:11 +0000 (UTC) Received: from marcel-nb-toradex-int.toradex.int ([46.140.72.82]) by mrelay.perfora.net (mreueus002 [74.208.5.2]) with ESMTPA (Nemesis) id 0LwHJA-1hGlLk3lYU-0183AF; Thu, 24 Jan 2019 15:30:07 +0100 From: Marcel Ziswiler To: u-boot@lists.denx.de Date: Thu, 24 Jan 2019 15:29:57 +0100 Message-Id: <20190124142957.15040-4-marcel@ziswiler.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190124142957.15040-1-marcel@ziswiler.com> References: <20190124142957.15040-1-marcel@ziswiler.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:OeuZdZ2XIDnhvoQ37JaoxcSwueePPp0Jt0rwLzqYh0sEz2jyf09 bE8/sHg1OAULIX9BHHoBe5ZnZwIQH4TkPgS35S8mVgggpPZU6NtWgKwX4YAzVgIix5b6JY8 eZLfi9EycFTqIVQIftWlG1q8PL5MQno5/oICADPqABSiVZ03CkCS6ZVtFfLbN2VdG8vFsPN hSojoh0tcuwQfuPbJhUbA== X-UI-Out-Filterresults: notjunk:1; V03:K0:KxMn4RSg3Rs=:l8Ty5HIh1VYy/vZm7iaV3l Q1u+GHLsHSsAYQE6WJucDI/2urFbXpmb+Fl8A1kNVWMUfBHovyAw/uqm0YrgSencc49//4gRH z9W0BARVQSrvZ1LPSaI81oE/gN3nWIb62sA/7wJwNikApOUV8L63uVv3+g6K50ssGAOJht7AW jcIQDu+h6uJI9dd9C9bKRJGbBRl9LkJIe/23PX283lxCj/Iv7FWlO8+uPgekjNsZGTpVvr9WG NfaHC5dyzST826FCYOqCbgBxVMLen0kkTqw+HnjbeZULQ0q3LHqIUE5IQnZdyyt34QThCP0fz GXnOzXNpgEcppc4p/dsK4UzQWkLtnmIm80LhrALbMy0xoBQ12HgLrQbVk70SQo6E+TBXQDjh1 z4wCPaUUNaBmSrLxHeJwiZO6KMfr+M/K1Hf88KEDdBs1n3mrxh+ns9pxqX/DkT0n8O92mvI/Z vzqmzyQGs2RetvKa04RqFBp1QbIKzsjBei4x9LAZSDCYPAIjoBESK5icgUpSg8yJJY21RCOGm 0yNu5vnsvVcWbBRzsMnCW1Uqzo+gLscmem4kw0RcbpblsO7p5Mi0E7YqPKwEGlQ4jGyU2QjEv 2Uo+RJBU3vYQNCIDiZmmZk9nQtLdK7KrTom83Wl4ViU7tcpSDd6mh0IFQunn7rB5BAIVHzR/T 7AzUKJ0BcL2NHo92Z6ahl3Jv/AZLzi+wDCb+TpkOsGNcMBLCmW9TQ/TulP5us1D07NrB/4yG9 9Ku2b9lI4w2ClGe6GMzsFN27PH7qr/bhd15UMQ== Cc: Marcel Ziswiler , Tom Rini , Simon Glass Subject: [U-Boot] [PATCH 3/3] cmd: sata: add null pointer check for dev X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Marcel Ziswiler Calling sata_scan() with a null pointer probably won't make much sense. Signed-off-by: Marcel Ziswiler Reviewed-by: Simon Glass --- cmd/sata.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/cmd/sata.c b/cmd/sata.c index 6d62ba8f74..a73cc54bd3 100644 --- a/cmd/sata.c +++ b/cmd/sata.c @@ -60,6 +60,10 @@ int sata_probe(int devnum) printf("Cannot probe SATA device %d (err=%d)\n", devnum, rc); return CMD_RET_FAILURE; } + if (!dev) { + printf("No SATA device found!\n"); + return CMD_RET_FAILURE; + } rc = sata_scan(dev); if (rc) { printf("Cannot scan SATA device %d (err=%d)\n", devnum, rc);