From patchwork Mon Dec 10 11:05:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martyn Welch X-Patchwork-Id: 1010371 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=welchs.me.uk Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jT1oaXFq"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43D0c85jMqz9s4s for ; Mon, 10 Dec 2018 22:05:44 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 74C4CC2249F; Mon, 10 Dec 2018 11:05:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 89AE0C21F21; Mon, 10 Dec 2018 11:05:38 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 37EFEC21F21; Mon, 10 Dec 2018 11:05:37 +0000 (UTC) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by lists.denx.de (Postfix) with ESMTPS id 05011C21EEB for ; Mon, 10 Dec 2018 11:05:36 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id r10so9981896wrs.10 for ; Mon, 10 Dec 2018 03:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=n8eIkVNF5jOf+DJtvhlhiM5eHI3oN6OjbrrZ4PDuenI=; b=jT1oaXFqeJ0dps3qkDgl19aVEyJgYV6auMu8++gNoZzcmmIp6NKwzdc/NExq+LHN7n wgM5d1oc2IppBaLWc2W3zlXsPi6Er0nsPSXqPkoCyLTUEjRp7Mqr/hSUjlK+36LsHM0U 2u32e5XBUOUUAYHgm/6vkrwi+Qzdyram6ECuz3U6UHme57dqEZt2+cJPi+qsYnHw1163 Ool4E8qgd9wAfXjdhzrAWpCIt8eaXy/n+MnbP7uqpobUd+Cn2AswlPdcBwMZlXQuGSiT 84m8h/Fl/hXOk39WKHPiFxs25paKoHWxIMS+yfIqILAhu5lqcqAURg6ZuTi3FeiJChnD 0ctw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=n8eIkVNF5jOf+DJtvhlhiM5eHI3oN6OjbrrZ4PDuenI=; b=LY+XARkB0Jrf6xYm9KJoc1iU+ZleoV7DAbP2I2dz+zDS+KbKomtsQ+5gwBcaHX8nJ9 EIhL7UQ4U+wIR6E5unTbww2vyTKmSD+VCt7x3qJhMETLgwp4w4a5rIa05eM+e7XpwB99 E10DuaqY4y9mScOZKhfN6aZ+eVDvbvGlKqjEsE3pU3pmJmXSM1tdaxchILgtkzvhGl45 5Le8sGHiP6pol/HFoKH07VLL9U1wnXU0cyUj3auj8soKozfzc1negDDseUDcUbzmRFL0 Gc8UToydtQmPwAsYKBtzx82fddL0TPsvbJWklxMgzT8DGUFTsUSKD6fAwSMO0wayzyA4 fzcA== X-Gm-Message-State: AA+aEWb3PhwZLufw90ng8JJXOmjD+2Sp4mX7QEAV4EQr91PIMpAacU+0 xKFgw4DblRd+MlCbdnZ6jHA= X-Google-Smtp-Source: AFSGD/VjJtLcr6TCbt93BizyRhaOughfz2AYJDp2+mUIfJ9INeTjpRY5sUlYkQeEBP1S7doUD3zZKw== X-Received: by 2002:adf:fc51:: with SMTP id e17mr9130793wrs.268.1544439935439; Mon, 10 Dec 2018 03:05:35 -0800 (PST) Received: from hades ([2a00:23c5:58d:db00:68bb:47d:d5ca:9abd]) by smtp.gmail.com with ESMTPSA id a6sm10995841wmh.10.2018.12.10.03.05.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Dec 2018 03:05:34 -0800 (PST) From: Martyn Welch X-Google-Original-From: Martyn Welch Received: from martyn by hades with local (Exim 4.91) (envelope-from ) id 1gWJNV-0003kS-Qa; Mon, 10 Dec 2018 11:05:33 +0000 To: Marek Vasut , Sven Schwermer , u-boot@lists.denx.de Date: Mon, 10 Dec 2018 11:05:16 +0000 Message-Id: <20181210110518.14012-1-martyn.welch@collabora.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Cc: Martyn Welch Subject: [U-Boot] [RESEND PATCH v3 1/3] Don't enable CONFIG_SPL_DM_USB for non-DM SPL X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" When CONFIG_SPL_DM_USB was added, it was added defaulted on without protection to ensure it didn't get set for non-DM SPL builds. This leads to unexpected and confusing failures when building a DM based U-Boot but with a non-DM SPL, as the defconfig is unlikely to have CONFIG_SPL_DM_USB actively disabled. Tweak the Kconfig to not enable this setting unless CONFIG_SPL_DM is set. Signed-off-by: Martyn Welch Reviewed-by: Jean-Jacques Hiblot --- Changes in v3: - New in v3 Changes in v2: None drivers/usb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index d456beb43f..3c978d43aa 100644 --- a/drivers/usb/Kconfig +++ b/drivers/usb/Kconfig @@ -49,7 +49,7 @@ config DM_USB config SPL_DM_USB bool "Enable driver model for USB in SPL" - depends on DM_USB + depends on SPL_DM && DM_USB default y source "drivers/usb/host/Kconfig"