From patchwork Tue Dec 4 06:54:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 1007466 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="iD1Rx8dg"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 438CKc5KWLz9s8J for ; Tue, 4 Dec 2018 17:55:00 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 6A0ADC22340; Tue, 4 Dec 2018 06:54:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 75FB6C222D0; Tue, 4 Dec 2018 06:54:54 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 62AE0C222D0; Tue, 4 Dec 2018 06:54:53 +0000 (UTC) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by lists.denx.de (Postfix) with ESMTPS id C1353C2208D for ; Tue, 4 Dec 2018 06:54:52 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id i12so7719859pfo.7 for ; Mon, 03 Dec 2018 22:54:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xyGt7sxHI6xsSiGXrgybV9esqtFKDN1RBUkMmeehdEE=; b=iD1Rx8dgTOH/mfnnxqoNc+GlNpp6WhYNdhMtMqiLRW/8g8U042Em69Q39/j+S+i4qJ Cc7cmq+q2g2aUNmXzX2bVs2VIuy9jedAl9gERGpRI5YSn6oMnewFgU3bWJbCH6PD6vvc iynkSPvs6QkrHxG3ON6QvvSXXJ/IwVB2IWIvyAM3WPdz0qz7bm2055I4NkMjKwAVfV2X 5Szs27tRfYze/k10gXEQBvMW/r01LvAbzhVQ3afhOiG9FkDKMjrp8vKZ6NseWs/N6jjJ t3K1JpFqQSNDAGfktO9pff8PVKYWGTp90AHMaPvsrp83NYrcZNjQ5ct34HhEr6Zfq2Zm uTrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xyGt7sxHI6xsSiGXrgybV9esqtFKDN1RBUkMmeehdEE=; b=KIJLO0tq39+gAWaFoNM4WEvCnoH49+PvPIO0P/OnJtxGOl1zfmC1QqIu6JEROcFicv QTwAIUV8LEvxr/rYMVN1fQr/VUJJ0C3yFvFy3x4Qi/hfQ+lhOUBVmKkhapS2h7VrnDSX QjNVanh9dwWLpYr1byq4AEU+OCE3kthv3Fav4SmFW6NwqXiCvGcj7Cc8W25ZoycfsY1y f8To+zxHWk0NET48ALBj7jJiNGS414QIMbZtDEUuC9HIwnKTC8HqpV0dGOMxFBqs2OGZ /IocwmLxj8fz8ehw/2fTxx3RgQtNrYXJY1hHbqFDfgWZX9bCo4ZEzRPkPUk7qzxxTkTK +YNQ== X-Gm-Message-State: AA+aEWbhlP7SwUR3kejaW8WBwyEaHywDbea7wlmTlQqdwdsCq23IPof7 ewW0gWZR5Nx/baF5FSHr7nnfDZI37GM= X-Google-Smtp-Source: AFSGD/Ux/AUYhOJPf+v9m3Bf0fQCXHrk3jSs1Qw85rEuRXSZZKrhynWH5m1lFs+luuu/fopZXOv0Vw== X-Received: by 2002:a63:295:: with SMTP id 143mr15352380pgc.362.1543906490914; Mon, 03 Dec 2018 22:54:50 -0800 (PST) Received: from chrisp-dl.ws.atlnz.lc ([2001:df5:b000:22:3a2c:4aff:fe70:2b02]) by smtp.gmail.com with ESMTPSA id c13sm21586432pfo.121.2018.12.03.22.54.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Dec 2018 22:54:49 -0800 (PST) From: Chris Packham To: u-boot@lists.denx.de Date: Tue, 4 Dec 2018 19:54:30 +1300 Message-Id: <20181204065430.18480-1-judge.packham@gmail.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Cc: Tom Rini , Stefan Roese , Chris Packham , Joe Hershberger Subject: [U-Boot] [PATCH] net: mvgbe: fallback phy-mode to GMII X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Some existing device trees don't specify a phy-mode so fallback to GMII when a phy-mode is not provided. Signed-off-by: Chris Packham Reviewed-by: Stefan Roese Acked-by: Joe Hershberger --- This is similar to what the Linux mv643xx_eth.c network driver does to handle the same case. drivers/net/mvgbe.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c index 74fed7abd837..037e59ec6e3c 100644 --- a/drivers/net/mvgbe.c +++ b/drivers/net/mvgbe.c @@ -1005,10 +1005,8 @@ static int mvgbe_ofdata_to_platdata(struct udevice *dev) phy_mode = fdt_getprop(gd->fdt_blob, pnode, "phy-mode", NULL); if (phy_mode) pdata->phy_interface = phy_get_interface_by_name(phy_mode); - if (pdata->phy_interface == -1) { - debug("%s: Invalid PHY interface '%s'\n", __func__, phy_mode); - return -EINVAL; - } + else + pdata->phy_interface = PHY_INTERFACE_MODE_GMII; dmvgbe->phy_interface = pdata->phy_interface;