Message ID | 20181125172853.20491-15-jagan@amarulasolutions.com |
---|---|
State | Accepted |
Delegated to: | Jagannadha Sutradharudu Teki |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="ezLlQ5vK"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 432yMb5dqxz9s29 for <incoming@patchwork.ozlabs.org>; Mon, 26 Nov 2018 04:53:31 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 55335C22040; Sun, 25 Nov 2018 17:43:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: *** X-Spam-Status: No, score=3.0 required=5.0 tests=KHOP_BIG_TO_CC, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SINGLE_HEADER_3K, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 80B28C220F4; Sun, 25 Nov 2018 17:38:14 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id B8FC3C22012; Sun, 25 Nov 2018 17:34:13 +0000 (UTC) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by lists.denx.de (Postfix) with ESMTPS id 0E4DDC2200E for <u-boot@lists.denx.de>; Sun, 25 Nov 2018 17:34:13 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id u6so5403006pfh.11 for <u-boot@lists.denx.de>; Sun, 25 Nov 2018 09:34:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p2yOgWDOu2LU09nRm/oHIlXZTD47h62ToxLJhnnyR9E=; b=ezLlQ5vKilghOdjehCFIk71N/Wa00Zu3JPjk4hJWvftSjqrOgYWzxZ9M2eI1uijZhN wR5WvWfmpcZ/No6bsA2gZxlurLGv1AoSKaD6ZmXVm0Ad5c2uZCaVva81yUyc2Rr1B1Th qZiqV8H1Gb1FARowq9bAJYe7cdEe8tJJID7SU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p2yOgWDOu2LU09nRm/oHIlXZTD47h62ToxLJhnnyR9E=; b=NOS68GHIkhbJkbShvgACGg8R2l1JNNrquBCdiungWFT83ZeGizY0kCU63H2yPs2q+s 29rWwQ3PYGTl9NkoUhHassUZL3zZFdh8U6wtGgpIjqSiYEXzsYqTp/DVfz/d6ERVncxh GncdYGJeQZOukEoTs2nOIkwW7BSPrEviyI7vnOGOM4NIKAOHCVMQseMQzvlM2KwrFRgk xsTv4MH4ry7vWAdIDRK9SaY2T7ajg6dRk5uAurz687Su6zOsEJmsfd7zMzs8ixKh8Bjw 8SBnAPUeptyA1tcBL5qpsGVHiIvcjhEpFfDi3UbeWh9FmbYGw0jjF2i29/M9lvNSCxh2 iqZw== X-Gm-Message-State: AGRZ1gIhGJDCosPbe/sE4n7M8bPUTz4aQK0TcqAi71eVsHEwXntTc8HO eFDMnTtk/aW1wxq5hPOohjT39A== X-Google-Smtp-Source: AJdET5dizV4MHrQ17sXVLOpIHbxocOhWXe6YnAFhAgrg/As89yeRt0qyuqixyfYyeD8Pp46PoZb7+A== X-Received: by 2002:a62:4681:: with SMTP id o1-v6mr24623238pfi.172.1543167251578; Sun, 25 Nov 2018 09:34:11 -0800 (PST) Received: from localhost.localdomain ([115.97.190.86]) by smtp.gmail.com with ESMTPSA id k15sm16620785pfb.147.2018.11.25.09.33.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Nov 2018 09:34:10 -0800 (PST) From: Jagan Teki <jagan@amarulasolutions.com> To: Adam Ford <aford173@gmail.com>, Vitaly Andrianov <vitalya@ti.com>, Stefano Babic <sbabic@denx.de>, Peter Howard <phoward@gme.net.au>, Tom Rini <trini@konsulko.com>, Walter Schweizer <swwa@users.sourceforge.net>, Valentin Longchamp <valentin.longchamp@keymile.com>, Phil Sutter <phil@nwl.cc>, Stefan Roese <sr@denx.de>, Simon Glass <sjg@chromium.org>, Tuomas Tynkkynen <tuomas@tuxera.com>, Sam Protsenko <semen.protsenko@linaro.org>, Dirk Eibach <dirk.eibach@gdsys.cc>, Mario Six <mario.six@gdsys.cc>, Simon Guinot <simon.guinot@sequanux.org>, Konstantin Porotchkin <kostap@marvell.com>, Jason Cooper <u-boot@lakedaemon.net>, =?utf-8?q?Marek_Beh=C3=BAn?= <marek.behun@nic.cz>, Lokesh Vutla <lokeshvutla@ti.com>, "Andrew F . Davis" <afd@ti.com>, Uri Mashiach <uri.mashiach@compulab.co.il>, Heiko Schocher <hs@denx.de>, TsiChung Liew <Tsi-Chung.Liew@nxp.com>, Joe Hershberger <joe.hershberger@ni.com>, Angelo Dureghello <angelo@sysam.it>, Vladimir Zapolskiy <vz@mleia.com>, Albert ARIBAUD <albert.aribaud@3adev.fr>, Marek Vasut <marex@denx.de>, Fabio Estevam <fabio.estevam@nxp.com>, Nikita Kiryanov <nikita@compulab.co.il>, Lukasz Majewski <lukma@denx.de>, Markus Niebel <Markus.Niebel@tq-group.com>, Troy Kisky <troy.kisky@boundarydevices.com>, Akshay Bhat <akshaybhat@timesys.com>, Ken Lin <Ken.Lin@advantech.com.tw>, Peng Fan <peng.fan@nxp.com>, Magnus Lilja <lilja.magnus@gmail.com>, Christian Gmeiner <christian.gmeiner@gmail.com>, =?utf-8?q?Eric_B=C3=A9nard?= <eric@eukrea.com>, Ian Ray <ian.ray@ge.com>, Otavio Salvador <otavio@ossystems.com.br>, Andreas Geisreiter <ageisreiter@dh-electronics.de>, Ludwig Zenz <lzenz@dh-electronics.de>, Dmitry Lifshitz <lifshitz@compulab.co.il>, Roger Meier <r.meier@siemens.com>, Gilles Gameiro <gilles@gigadevices.com>, Lothar Felten <lothar.felten@gmail.com>, Tapani Utriainen <linuxfae@technexion.com>, Steve Sakoman <sakoman@gmail.com>, =?utf-8?q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>, Marcin Niestroj <m.niestroj@grinn-global.com>, Nishanth Menon <nm@ti.com>, Lars Poeschel <poeschel@lemonage.de>, Enric Balletbo i Serra <eballetbo@gmail.com>, Yegor Yefremov <yegorslists@googlemail.com>, Ash Charles <ash@gumstix.com>, Grazvydas Ignotas <notasas@gmail.com>, Igor Grinberg <grinberg@compulab.co.il>, "Derald D . Woods" <woods.technical@gmail.com>, Hannes Schmelzer <hannes.schmelzer@br-automation.com>, Eugen Hristev <eugen.hristev@microchip.com>, Ludovic Desroches <ludovic.desroches@microchip.com>, Stelian Pop <stelian@popies.net>, Mateusz Kulikowski <mateusz.kulikowski@gmail.com>, Ilko Iliev <iliev@ronetix.at>, Daniel Gorsulowski <daniel.gorsulowski@esd.eu>, Ben Whitten <ben.whitten@lairdtech.com>, =?utf-8?q?Andreas_Bie=C3=9Fm?= =?utf-8?q?ann?= <andreas@biessmann.org>, Erik van Luijk <evanluijk@interact.nl>, Gregory CLEMENT <gregory.clement@free-electrons.com>, Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>, Sumit Garg <sumit.garg@nxp.com>, York Sun <york.sun@nxp.com>, Yinbo Zhu <yinbo.zhu@nxp.com>, Priyanka Jain <priyanka.jain@nxp.com>, Mingkai Hu <Mingkai.Hu@nxp.com>, Alison Wang <alison.wang@nxp.com>, Ashish Kumar <Ashish.Kumar@nxp.com>, Udit Agarwal <udit.agarwal@nxp.com>, Vinitha Pillai-B57223 <vinitha.pillai@nxp.com>, Feng Li <feng.li_2@nxp.com>, Qiang Zhao <qiang.zhao@nxp.com>, Naveen Burmi <naveen.burmi@nxp.com>, Shengzhou Liu <Shengzhou.Liu@nxp.com>, Ruchika Gupta <ruchika.gupta@nxp.com>, Poonam Aggrwal <poonam.aggrwal@nxp.com>, Timur Tabi <timur@tabi.org>, Xiaobo Xie <xiaobo.xie@nxp.com>, Po Liu <po.liu@nxp.com> Date: Sun, 25 Nov 2018 22:58:35 +0530 Message-Id: <20181125172853.20491-15-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20181125172853.20491-1-jagan@amarulasolutions.com> References: <20181125172853.20491-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Mailman-Approved-At: Sun, 25 Nov 2018 17:37:55 +0000 Cc: u-boot@lists.denx.de Subject: [U-Boot] [PATCH v2 14/32] spi: mpc8xxx: Reduce scope of loop variables X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <http://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> |
Series |
spi: DM_SPI migration timeout, remainder(2)
|
expand
|
diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c index a2e698ea17..2a0f3cc06a 100644 --- a/drivers/spi/mpc8xxx_spi.c +++ b/drivers/spi/mpc8xxx_spi.c @@ -88,10 +88,8 @@ int spi_xfer(struct spi_slave *slave, uint bitlen, const void *dout, void *din, ulong flags) { spi8xxx_t *spi = &((immap_t *)(CONFIG_SYS_IMMR))->spi; - uint tmpdout, tmpdin, event; + u32 tmpdin; int num_blks = DIV_ROUND_UP(bitlen, 32); - int tm; - uchar char_size = 32; debug("%s: slave %u:%u dout %08X din %08X bitlen %u\n", __func__, slave->bus, slave->cs, *(uint *)dout, *(uint *)din, bitlen); @@ -104,8 +102,9 @@ int spi_xfer(struct spi_slave *slave, uint bitlen, const void *dout, void *din, /* Handle data in 32-bit chunks */ while (num_blks--) { - tmpdout = 0; - char_size = (bitlen >= 32 ? 32 : bitlen); + int tm; + u32 tmpdout = 0; + uchar char_size = (bitlen >= 32 ? 32 : bitlen); /* Shift data so it's msb-justified */ tmpdout = *(u32 *)dout >> (32 - char_size); @@ -145,7 +144,7 @@ int spi_xfer(struct spi_slave *slave, uint bitlen, const void *dout, void *din, * The NE event must be read and cleared first */ for (tm = 0; tm < SPI_TIMEOUT; ++tm) { - event = in_be32(&spi->event); + u32 event = in_be32(&spi->event); bool have_ne = event & SPI_EV_NE; bool have_nf = event & SPI_EV_NF;