diff mbox series

[U-Boot,4/4] ARM: chiliboard: remove dead !CONFIG_DM_SERIAL code

Message ID 20181121193203.10906-5-m.niestroj@grinn-global.com
State Accepted
Commit 70c44f171882768fc6e4dcb0435110b7f897d02e
Delegated to: Tom Rini
Headers show
Series ARM: chiliboard: move towards driver model and device-tree boot | expand

Commit Message

Marcin Niestroj Nov. 21, 2018, 7:32 p.m. UTC 
DM_SERIAL is selected by TARGET_CHILIBOARD, so there is no reason to
keep code that will not be built. Remove it.

Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
---
 board/grinn/chiliboard/board.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Tom Rini Nov. 22, 2018, 1:30 p.m. UTC | #1 
On Wed, Nov 21, 2018 at 08:32:03PM +0100, Marcin Niestroj wrote:

> DM_SERIAL is selected by TARGET_CHILIBOARD, so there is no reason to
> keep code that will not be built. Remove it.
> 
> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
Tom Rini Nov. 27, 2018, 6:48 p.m. UTC | #2 
On Wed, Nov 21, 2018 at 08:32:03PM +0100, Marcin Niestroj wrote:

> DM_SERIAL is selected by TARGET_CHILIBOARD, so there is no reason to
> keep code that will not be built. Remove it.
> 
> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/board/grinn/chiliboard/board.c b/board/grinn/chiliboard/board.c
index 2bb91e31b7..dc0de620fc 100644
--- a/board/grinn/chiliboard/board.c
+++ b/board/grinn/chiliboard/board.c
@@ -19,7 +19,6 @@ 
 #include <environment.h>
 #include <errno.h>
 #include <miiphy.h>
-#include <serial.h>
 #include <spl.h>
 #include <watchdog.h>
 
@@ -69,13 +68,6 @@  static void enable_board_pin_mux(void)
 }
 #endif /* CONFIG_SKIP_LOWLEVEL_INIT */
 
-#ifndef CONFIG_DM_SERIAL
-struct serial_device *default_serial_console(void)
-{
-	return &eserial1_device;
-}
-#endif
-
 #ifndef CONFIG_SKIP_LOWLEVEL_INIT
 void set_uart_mux_conf(void)
 {