From patchwork Tue Nov 20 12:47:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 1000475 X-Patchwork-Delegate: jagannadh.teki@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="PYqISX54"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42zmFc4X85z9s0n for ; Wed, 21 Nov 2018 00:07:15 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 769D8C220C5; Tue, 20 Nov 2018 12:55:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 3242EC22105; Tue, 20 Nov 2018 12:49:48 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 8A340C220EB; Tue, 20 Nov 2018 12:49:36 +0000 (UTC) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by lists.denx.de (Postfix) with ESMTPS id B0AAAC220A6 for ; Tue, 20 Nov 2018 12:49:19 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id gn14so955723plb.10 for ; Tue, 20 Nov 2018 04:49:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DvxOHgjATfWl2XuOb3BuIsm23gd4oYcGplmjAwTQIp8=; b=PYqISX54XcLZaT9f6ZJV/MJ998EkzeFDaTj5XErdUZj7gin57m/mUzd1n2Ysl3Vrgx cMqWtcGsYO+Nk7NNq+4qnSRoDV+NjpDXt8IQnYt64gdXm3F3T/OSy9EWLEnlqH4my7ZZ 6znvCc/74ynt9lrGYRQyTXOePpenh3MJAE53w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DvxOHgjATfWl2XuOb3BuIsm23gd4oYcGplmjAwTQIp8=; b=DQ3aUAilG7c83PsQdPyEBz//U/vlt9LHjx7ojax/kCmHGMrWpfH2w3brGae1QfAR60 vQC7TlR2XaYvXjM4zApYHnFKq41Q+5xguoLN+q3Vrh0lAxaXqr2ic+PTyNzyFIxOpOZf /wNvNMk/udrepA/phKbRRQFLCaodloPqm7Tpf3hOn3RS0vEPHCJvOQiqK1QHYz4P7LE5 Yr3gcprLm/ry03ha0GTLDUAyKE/zBScAdpo3SDMoA1JUZYoF2N4hU7Z/04TcOcy2mRf3 7WolKE5ZeL7DVwhUjmlPg6uJEKS2PC8mMUsUOFj0wfiTdikqf+4QwXhKkMpfbvQrGr7V NNRw== X-Gm-Message-State: AA+aEWZX0FBBWfn0FCJERIDlvjckdnoh2dcF+258aNwhCJN1UcSLFfiZ BNdKMOPmg/7h73t9i5Xx4U8dk3rNS4A= X-Google-Smtp-Source: AFSGD/XPNpsR+1pfX1/0HFlG43NGgQLPE5w1EsXu7qwfTWkBDTMmbe7Jkq15h+flasmE8hTWrdX87w== X-Received: by 2002:a17:902:4401:: with SMTP id k1mr2082962pld.307.1542718158190; Tue, 20 Nov 2018 04:49:18 -0800 (PST) Received: from localhost.localdomain ([115.97.190.86]) by smtp.gmail.com with ESMTPSA id b5sm34880349pfc.150.2018.11.20.04.49.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Nov 2018 04:49:17 -0800 (PST) From: Jagan Teki To: u-boot@lists.denx.de Date: Tue, 20 Nov 2018 18:17:58 +0530 Message-Id: <20181120124814.23293-19-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20181120124814.23293-1-jagan@amarulasolutions.com> References: <20181120124814.23293-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Cc: Tom Rini Subject: [U-Boot] [PATCH 18/34] spi: mpc8xxx: Rename variable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Mario Six The variable "char_size" holds the number of bits to be transferred in the current loop iteration. A better name would be "xfer_bitlen", which we rename this variable to. Signed-off-by: Mario Six --- drivers/spi/mpc8xxx_spi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c index 83fd8b3cc1..63d956a295 100644 --- a/drivers/spi/mpc8xxx_spi.c +++ b/drivers/spi/mpc8xxx_spi.c @@ -114,10 +114,10 @@ int spi_xfer(struct spi_slave *slave, uint bitlen, const void *dout, void *din, while (num_blks--) { int tm; u32 tmpdout = 0; - uchar char_size = (bitlen >= 32 ? 32 : bitlen); + uchar xfer_bitlen = (bitlen >= 32 ? 32 : bitlen); /* Shift data so it's msb-justified */ - tmpdout = *(u32 *)dout >> (32 - char_size); + tmpdout = *(u32 *)dout >> (32 - xfer_bitlen); /* The LEN field of the SPMODE register is set as follows: * @@ -165,8 +165,8 @@ int spi_xfer(struct spi_slave *slave, uint bitlen, const void *dout, void *din, tmpdin = in_be32(&spi->rx); setbits_be32(&spi->event, SPI_EV_NE); - *(u32 *)din = (tmpdin << (32 - char_size)); - if (char_size == 32) { + *(u32 *)din = (tmpdin << (32 - xfer_bitlen)); + if (xfer_bitlen == 32) { /* Advance output buffer by 32 bits */ din += 4; }