diff mbox series

[U-Boot,14/25] binman: Add a way to enable debugging from the build

Message ID 20181106222142.94537-15-sjg@chromium.org
State Accepted
Commit a3c005506ac87f3684603fc40ada98070027aaa0
Delegated to: Simon Glass
Headers show
Series sandbox: Changes and improvements to support verified boot | expand

Commit Message

Simon Glass Nov. 6, 2018, 10:21 p.m. UTC 
When the build fails due to something wrong in binman it is sometimes
useful to get a full backtrace showing the location of the failure. Add
a BINMAN_DEBUG environment variable to support this along with some
documentation.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 Makefile            | 6 ++++--
 tools/binman/README | 6 ++++++
 2 files changed, 10 insertions(+), 2 deletions(-)

Comments

Simon Glass Nov. 22, 2018, 8:20 p.m. UTC | #1 
When the build fails due to something wrong in binman it is sometimes
useful to get a full backtrace showing the location of the failure. Add
a BINMAN_DEBUG environment variable to support this along with some
documentation.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 Makefile            | 6 ++++--
 tools/binman/README | 6 ++++++
 2 files changed, 10 insertions(+), 2 deletions(-)

Applied to u-boot-dm/master, thanks!
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 250eb6c3c39..c7df436a161 100644
--- a/Makefile
+++ b/Makefile
@@ -1048,9 +1048,11 @@  u-boot.ldr:	u-boot
 
 # binman
 # ---------------------------------------------------------------------------
+# Use 'make BINMAN_DEBUG=1' to enable debugging
 quiet_cmd_binman = BINMAN  $@
-cmd_binman = $(srctree)/tools/binman/binman -d u-boot.dtb -O . \
-		-I . -I $(srctree)/board/$(BOARDDIR) $<
+cmd_binman = $(srctree)/tools/binman/binman -u -d u-boot.dtb -O . -m \
+		-I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \
+		$(if $(BINMAN_DEBUG),-D) $(BINMAN_$(@F)) $<
 
 OBJCOPYFLAGS_u-boot.ldr.hex := -I binary -O ihex
 
diff --git a/tools/binman/README b/tools/binman/README
index b64dedf2ebc..04ed2b799c8 100644
--- a/tools/binman/README
+++ b/tools/binman/README
@@ -723,6 +723,12 @@  If you need to specify a particular device-tree compiler to use, you can define
 the DTC environment variable. This can be useful when the system dtc is too
 old.
 
+To enable a full backtrace and other debugging features in binman, pass
+BINMAN_DEBUG=1 to your build:
+
+   make sandbox_defconfig
+   make BINMAN_DEBUG=1
+
 
 History / Credits
 -----------------