Message ID | 20181105100112.21490-3-peng.fan@nxp.com |
---|---|
State | Accepted |
Delegated to: | Stefano Babic |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="HAf4P1GA"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42pSj928HJz9sCQ for <incoming@patchwork.ozlabs.org>; Mon, 5 Nov 2018 20:55:25 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id CB7BDC22657; Mon, 5 Nov 2018 09:54:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id D0707C221BC; Mon, 5 Nov 2018 09:53:38 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id D542DC22655; Mon, 5 Nov 2018 09:53:33 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80057.outbound.protection.outlook.com [40.107.8.57]) by lists.denx.de (Postfix) with ESMTPS id E9A80C22453 for <u-boot@lists.denx.de>; Mon, 5 Nov 2018 09:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dBg1dgk854pojjd/0Dph098wWRDMhv5XSp+pm0UuzZE=; b=HAf4P1GAsGseL6UX41eudIDdaWpB1B6PBv5QJF4v/NlT5MhxLfz7fAYyW+510NA3w6FlvtRXDMg3gNjXsyjI0bxHVLFZigOL2i1RDFeFm/IV1R3aF6pP+DoV0UfVYpsSgUzk+aZ/mWOSFBoJdpSmE1e3c3ewAkT6LXtX5tAhOA8= Received: from AM0PR04MB4481.eurprd04.prod.outlook.com (52.135.148.143) by AM0PR04MB4308.eurprd04.prod.outlook.com (52.134.126.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Mon, 5 Nov 2018 09:53:28 +0000 Received: from AM0PR04MB4481.eurprd04.prod.outlook.com ([fe80::2cc2:9269:b873:f270]) by AM0PR04MB4481.eurprd04.prod.outlook.com ([fe80::2cc2:9269:b873:f270%3]) with mapi id 15.20.1294.032; Mon, 5 Nov 2018 09:53:28 +0000 From: Peng Fan <peng.fan@nxp.com> To: "sbabic@denx.de" <sbabic@denx.de> Thread-Topic: [PATCH V2 3/4] tools: imx8image: fix coverity CID 184233 Thread-Index: AQHUdO1nY7LMaFyx/0exqE6krkX16A== Date: Mon, 5 Nov 2018 09:53:28 +0000 Message-ID: <20181105100112.21490-3-peng.fan@nxp.com> References: <20181105100112.21490-1-peng.fan@nxp.com> In-Reply-To: <20181105100112.21490-1-peng.fan@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.14.1 x-clientproxiedby: HK0PR01CA0064.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::28) To AM0PR04MB4481.eurprd04.prod.outlook.com (2603:10a6:208:73::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=peng.fan@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [92.121.68.129] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR04MB4308; 6:844nyeVm4U29TmhesKFFrx8uVqACLql2VWbbwYntx8tVlOfZDHGRzKmJ/bL6/iH5TPGxKqIkrJhtTfqjJ82K0n7GXz6GtuVsEjdV9ojMGqFuqwc4qA8vkr6EGUEtWz2FdG46Es5mQpnrrJcwvZCgtpC89nTHB23M4lYH8gy7GWWTNKnTRPzmyP2ENCNVkaIFeIW5ayf01Ney3BCbRbi9zBQrXC0jS4ZQfvO7FoxXdb5D9+NTOIAfSIk+L2JDergPTxz8j94Zu+njhQOYpwIM1YTcRLqM4JZxV9E5PGFETPKtuclQ6S//+BSFFvUJ9DpATCAht9sQLTfmccItZimgNakYoPWkx9uI9jTGuhBK5tirzjX7C7d0su2LEd6jmpkoxzhcVswRR8eIncsUlEx8A11sXyaBkLUFsHxJUBfHvi01KphpIxLjKco6fyfQUpcjGA14R0xklqHak98MF5sbCA==; 5:uy/KdExkTwj7h1QhvmAU6QcQfwuAVwkkfigGNMCzIgy6YLcsZgo+KcNfcP1Aqgdkoz8smwh9wUI788URURqrcuInEpXpjtVPKXKHhGqat/MNBQvsM+q+ug2gLDCvCE1cZ4Pj1mt5AQWkLY/6eS5fEjfHWclnHUlTpT5Y6k71GH0=; 7:TcdR0clLRCZx4lmbiirCHf0htNZ+OeMar4bcuf+KDFD+GQFb2alMGbmlXNfI3ieQm5dra4kzC1F4OSEADkrpL+fX1xY16wDCe9wGIb3u3esUkH1BXt3mbf/Wo5VJZgW2xcHCPVNaVi9ajvo62h+83w== x-ms-office365-filtering-correlation-id: a9aa967d-d351-47f7-ca6d-08d643048971 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB4308; x-ms-traffictypediagnostic: AM0PR04MB4308: x-microsoft-antispam-prvs: <AM0PR04MB4308FC8ED7222E54D204ACE388CA0@AM0PR04MB4308.eurprd04.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:AM0PR04MB4308; BCL:0; PCL:0; RULEID:; SRVR:AM0PR04MB4308; x-forefront-prvs: 08476BC6EF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(346002)(376002)(366004)(136003)(199004)(189003)(305945005)(7736002)(5640700003)(6512007)(316002)(6436002)(5660300001)(2900100001)(2351001)(14454004)(54906003)(53936002)(14444005)(6916009)(256004)(36756003)(97736004)(2501003)(4326008)(71190400001)(105586002)(71200400001)(6486002)(99286004)(106356001)(2906002)(52116002)(186003)(26005)(386003)(6506007)(76176011)(1076002)(102836004)(66066001)(86362001)(11346002)(25786009)(478600001)(68736007)(8936002)(446003)(44832011)(8676002)(2616005)(6116002)(486006)(81156014)(3846002)(50226002)(1730700003)(81166006)(476003)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB4308; H:AM0PR04MB4481.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 4DUzWMTyKViha0Oq+Ce7oNf/IxEXHAuxG8g1DYPFxDv6qVaDP0nAOH2mlGxFQ5dt9ZONeDWiOmhiJYMh8jyWRSs9njuymSlYH6UznuXXoo5+VZYksr+6sbgx6knISK2do93Z+FcyAshvdub899iHVqSGlSwPPMtfYzNa2I6UvD48d84bZOZaX5O3QpcKGjfGXuW0+GcWBVboJk+xI3qMFS+Omh2gWc71DiKPX99BfO4bT+TaoBRr67RHHMoNC+BPPe1ns4yO4KadNfG5mE0EJX4Xo53b93A8Ef1DmnILH3ssSZxkZHXReXXUrHKt28qhX3CpLDcmls2SIhgg8kkYJUGeQwk/+boq1RBwwoVtGmI= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9aa967d-d351-47f7-ca6d-08d643048971 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2018 09:53:28.8483 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4308 Cc: Fabio Estevam <fabio.estevam@nxp.com>, "u-boot@lists.denx.de" <u-boot@lists.denx.de>, dl-linux-imx <linux-imx@nxp.com> Subject: [U-Boot] [PATCH V2 3/4] tools: imx8image: fix coverity CID 184233 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <http://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> |
Series |
[U-Boot,V2,1/4] tools: imx8image: check lseek return value
|
expand
|
diff --git a/tools/imx8image.c b/tools/imx8image.c index 019b875773..ac89c821c9 100644 --- a/tools/imx8image.c +++ b/tools/imx8image.c @@ -812,6 +812,10 @@ static int build_container(soc_type_t soc, uint32_t sector_size, case SCFW: case DATA: case MSG_BLOCK: + if (container < 0) { + fprintf(stderr, "No container found\n"); + exit(EXIT_FAILURE); + } check_file(&sbuf, img_sp->filename); tmp_filename = img_sp->filename; set_image_array_entry(&imx_header.fhdr[container], @@ -825,6 +829,10 @@ static int build_container(soc_type_t soc, uint32_t sector_size, break; case SECO: + if (container < 0) { + fprintf(stderr, "No container found\n"); + exit(EXIT_FAILURE); + } check_file(&sbuf, img_sp->filename); tmp_filename = img_sp->filename; set_image_array_entry(&imx_header.fhdr[container],
Fix: CID 184233: (NEGATIVE_RETURNS) Using variable "container" as an index to array "imx_header.fhdr". Reported-by: Coverity Signed-off-by: Peng Fan <peng.fan@nxp.com> --- tools/imx8image.c | 8 ++++++++ 1 file changed, 8 insertions(+)