From patchwork Fri Nov 2 15:03:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 992354 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XuqlMWB1"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42mlkT4RK1zB4WZ for ; Sat, 3 Nov 2018 02:05:37 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 362B4C2258A; Fri, 2 Nov 2018 15:04:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 64130C22584; Fri, 2 Nov 2018 15:03:45 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id B1E6BC22561; Fri, 2 Nov 2018 15:03:43 +0000 (UTC) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by lists.denx.de (Postfix) with ESMTPS id 91146C22535 for ; Fri, 2 Nov 2018 15:03:42 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id s10-v6so2250079wmc.5 for ; Fri, 02 Nov 2018 08:03:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NizNQdiB2uSqLLa/Inqeeu5NFsnXxunJ++M1I21I+TE=; b=XuqlMWB1xAPhsbgxnaGaB560XYdKYyqaTXow6nequBswqWmEuhi2rwCQPomUnbYSnJ 2QZy9RoEcXPRzzCcaELzVJ08msSMZ+8vQrw4/+mhzmOHVz1F7ciJ9FumIglLSDhLj0Ij QMicK17tkyBKTOgSzqwoK+6bsKLBSehwV2SFpDYHAQKpWEptAelkHlItV9e3GL8H5sEs IpwaRYkfUzNZUuWyOk1J8nK29/zA4Z5zVJZX2U5DuahGjcyIfQPYG8getMQA8FRrmI50 5WRZsGeiI3ZCweYwGEn2fS7HUsxtKns3WyEeti9JjC89Zk678m2/cfyu7IOOjyRmtCJw 2/tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NizNQdiB2uSqLLa/Inqeeu5NFsnXxunJ++M1I21I+TE=; b=eUeJOhzM6+/6664GIoqxGr8JXUswZf4v2lVPY9m0Kiten3CoaOwPkZ0eAjdWO2EyXj EEpjkYVK6emS+xPuIy+NOw3b/m10nuMKl4mFEkmxyl+qOa0LwzB3uRnwHBuQw7cfn2SD Ph8mJpb2htDCIePQnlkH9YTEb4vQNIoswQV9xhlEW41TpaHxW6HN96MQxA+AL6yKEMNA imxcu6dcCcPXyWVYcQTYzMl/8hOHMUFWhl35QaI0GKfWBVALJKXB0UPWg6kMEOUhO2dz I1AUrXugU7Yhxn02QoDPME8CDkqboM4gkDGNn6hDdr7h3z4DukppRADY0I9zkqBDWvXb fYDg== X-Gm-Message-State: AGRZ1gKLVs/knGHeTq6Aw+9rscw2sbtJB1RjZJJirS+aMcLmqW2ifqBD zkyzjUp49tMdP8KRonhQqlu86Roa X-Google-Smtp-Source: AJdET5dE+9Nbnhx7U+FPy2rNJDFCkhMoiNPcYpbtN1pULsCnuerDvwtg8uJfac6ss2coT/zzHTbGvA== X-Received: by 2002:a1c:2846:: with SMTP id o67-v6mr72756wmo.60.1541171021780; Fri, 02 Nov 2018 08:03:41 -0700 (PDT) Received: from kurokawa.lan (ip-86-49-110-70.net.upcbroadband.cz. [86.49.110.70]) by smtp.gmail.com with ESMTPSA id l67-v6sm60125880wma.20.2018.11.02.08.03.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Nov 2018 08:03:40 -0700 (PDT) From: Marek Vasut X-Google-Original-From: Marek Vasut To: u-boot@lists.denx.de Date: Fri, 2 Nov 2018 16:03:17 +0100 Message-Id: <20181102150328.21972-2-marek.vasut+renesas@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181102150328.21972-1-marek.vasut+renesas@gmail.com> References: <20181102150328.21972-1-marek.vasut+renesas@gmail.com> Cc: Marek Vasut Subject: [U-Boot] [PATCH V3 02/13] mmc: tmio: Improve error handling X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Properly handle return values and abort operations when they are non-zero. This is a minor improvement, which fixes two remaining unchecked return values. Signed-off-by: Marek Vasut Cc: Masahiro Yamada --- V2: No change V3: No change --- drivers/mmc/tmio-common.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/tmio-common.c b/drivers/mmc/tmio-common.c index 5f927c6150..f1ce019db5 100644 --- a/drivers/mmc/tmio-common.c +++ b/drivers/mmc/tmio-common.c @@ -498,6 +498,8 @@ int tmio_sd_send_cmd(struct udevice *dev, struct mmc_cmd *cmd, ret = tmio_sd_dma_xfer(dev, data); else ret = tmio_sd_pio_xfer(dev, data); + if (ret) + return ret; ret = tmio_sd_wait_for_irq(dev, TMIO_SD_INFO1, TMIO_SD_INFO1_CMP); @@ -505,9 +507,8 @@ int tmio_sd_send_cmd(struct udevice *dev, struct mmc_cmd *cmd, return ret; } - tmio_sd_wait_for_irq(dev, TMIO_SD_INFO2, TMIO_SD_INFO2_SCLKDIVEN); - - return ret; + return tmio_sd_wait_for_irq(dev, TMIO_SD_INFO2, + TMIO_SD_INFO2_SCLKDIVEN); } static int tmio_sd_set_bus_width(struct tmio_sd_priv *priv,