| Message ID | 20181025084242.3191-1-peng.fan@nxp.com |
|---|---|
| State | Accepted |
| Commit | 3c28576bb0f0990d699fd330089412e620706941 |
| Headers | show |
| Series | [U-Boot] arm: dts: imx8qxp: fix build warining | expand |
Hi Peng, On Thu, Oct 25, 2018 at 5:37 AM Peng Fan <peng.fan@nxp.com> wrote: > > Fix below build warning. > > arch/arm/dts/fsl-imx8qxp-mek.dtb: Warning (avoid_unnecessary_addr_size): > /regulators: unnecessary #address-cells/#size-cells without "ranges" > or child "reg" property > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > arch/arm/dts/fsl-imx8qxp-mek.dts | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/dts/fsl-imx8qxp-mek.dts b/arch/arm/dts/fsl-imx8qxp-mek.dts > index 09ea3b4a3a..c14e1845a1 100644 > --- a/arch/arm/dts/fsl-imx8qxp-mek.dts > +++ b/arch/arm/dts/fsl-imx8qxp-mek.dts > @@ -18,8 +18,6 @@ > > regulators { > compatible = "simple-bus"; > - #address-cells = <1>; > - #size-cells = <0>; The correct fix would be to move the regulators outside simple-bus. I will send a follow up patch.
> -----Original Message----- > From: Fabio Estevam [mailto:festevam@gmail.com] > Sent: 2018年10月26日 8:41 > To: Peng Fan <peng.fan@nxp.com> > Cc: Stefano Babic <sbabic@denx.de>; U-Boot-Denx <u-boot@lists.denx.de> > Subject: Re: [U-Boot] [PATCH] arm: dts: imx8qxp: fix build warining > > Hi Peng, > > On Thu, Oct 25, 2018 at 5:37 AM Peng Fan <peng.fan@nxp.com> wrote: > > > > Fix below build warning. > > > > arch/arm/dts/fsl-imx8qxp-mek.dtb: Warning (avoid_unnecessary_addr_size): > > /regulators: unnecessary #address-cells/#size-cells without "ranges" > > or child "reg" property > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > arch/arm/dts/fsl-imx8qxp-mek.dts | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/arch/arm/dts/fsl-imx8qxp-mek.dts > b/arch/arm/dts/fsl-imx8qxp-mek.dts > > index 09ea3b4a3a..c14e1845a1 100644 > > --- a/arch/arm/dts/fsl-imx8qxp-mek.dts > > +++ b/arch/arm/dts/fsl-imx8qxp-mek.dts > > @@ -18,8 +18,6 @@ > > > > regulators { > > compatible = "simple-bus"; > > - #address-cells = <1>; > > - #size-cells = <0>; > > The correct fix would be to move the regulators outside simple-bus. > > I will send a follow up patch. Thanks, please go ahead submit a patch fix. Thanks, Peng.
diff --git a/arch/arm/dts/fsl-imx8qxp-mek.dts b/arch/arm/dts/fsl-imx8qxp-mek.dts index 09ea3b4a3a..c14e1845a1 100644 --- a/arch/arm/dts/fsl-imx8qxp-mek.dts +++ b/arch/arm/dts/fsl-imx8qxp-mek.dts @@ -18,8 +18,6 @@ regulators { compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; reg_usdhc2_vmmc: usdhc2-vmmc { compatible = "regulator-fixed";
Fix below build warning. arch/arm/dts/fsl-imx8qxp-mek.dtb: Warning (avoid_unnecessary_addr_size): /regulators: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property Signed-off-by: Peng Fan <peng.fan@nxp.com> --- arch/arm/dts/fsl-imx8qxp-mek.dts | 2 -- 1 file changed, 2 deletions(-)