From patchwork Tue Oct 2 03:12:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 977608 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=chromium.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42PPZ317Mbz9s55 for ; Tue, 2 Oct 2018 13:21:15 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id CAEC1C22022; Tue, 2 Oct 2018 03:16:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id B2339C21FDC; Tue, 2 Oct 2018 03:16:19 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id D45FAC21FCD; Tue, 2 Oct 2018 03:14:22 +0000 (UTC) Received: from mail-ua1-f74.google.com (mail-ua1-f74.google.com [209.85.222.74]) by lists.denx.de (Postfix) with ESMTPS id 88280C21FCB for ; Tue, 2 Oct 2018 03:14:18 +0000 (UTC) Received: by mail-ua1-f74.google.com with SMTP id h26so232730uao.3 for ; Mon, 01 Oct 2018 20:14:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=w0Sru8nFTBMV+2y7Pw6Ia+CwklfIt5QN/sV/x8n4tgk=; b=LpRMZ+GC1VjwD2fHddXttI/i1soOgxc6ufqKcsAL+4PCrZ6fPjXvPotxDwEW1xy2jb YKtgARNdmFIyz/5WTHzeYqbE0/t4pVitn0METypg88aE19C1S7aT74p7A2SQndtA+siv SD68JbYolCOl2mXC+R5Hw6j8IF+BRkUK/ldC+ICYHmlPFoPpThda6xF/jN46UDZS+2er 8JObjoZiVp9pfE9HEyRzqMdIvE7QgGL2j/VCSmqxjUPq4KYMpV8+WRDx45vpAx13dfOY jW2xQNX+ymQVPrsiTd6CixBX6fg51zz0FE5me9B6HovJqbLW/zHjvIhlGX1os3xt4S6E JlEg== X-Gm-Message-State: ABuFfoiboKxOzmBJ9nrAEg2BPvj5cnEd65IWHrXKzvj62hW76gDxuyqf zSimCyHPjALWVMNyV6cvdwVcXRE= X-Google-Smtp-Source: ACcGV601QcIsZwv10XHV0U6d89vXz5frEVOt4Sei9murPYJIS3IzugaPF8s++/fnYYS8Ck/AIeTuaFs= X-Received: by 2002:ab0:6552:: with SMTP id x18-v6mr13704183uap.22.1538450057647; Mon, 01 Oct 2018 20:14:17 -0700 (PDT) Date: Mon, 1 Oct 2018 21:12:39 -0600 In-Reply-To: <20181002031247.93384-1-sjg@chromium.org> Message-Id: <20181002031247.93384-10-sjg@chromium.org> Mime-Version: 1.0 References: <20181002031247.93384-1-sjg@chromium.org> X-Mailer: git-send-email 2.19.0.605.g01d371f741-goog From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Stephen Warren , Alexander Graf Subject: [U-Boot] [PATCH v2 09/17] test: Tidy up comments and variable name X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The 'result' variable counts the number of failures in running the tests. Rename it to 'failures' to make this more obvious. Also tidy up a few comments. Signed-off-by: Simon Glass Signed-off-by: Simon Glass --- Changes in v2: None test/run | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/test/run b/test/run index d9901ae9f72..d64581ab140 100755 --- a/test/run +++ b/test/run @@ -9,10 +9,10 @@ run_test() { echo -n "$1: " shift "$@" - [ $? -ne 0 ] && result=$((result+1)) + [ $? -ne 0 ] && failures=$((failures+1)) } -result=0 +failures=0 # Run all tests that the standard sandbox build can support run_test "sandbox" ./test/py/test.py --bd sandbox --build @@ -21,7 +21,10 @@ run_test "sandbox" ./test/py/test.py --bd sandbox --build run_test "sandbox_spl" ./test/py/test.py --bd sandbox_spl --build \ -k test_ofplatdata.py -# Run tests for the flat DT version of sandbox +# Run tests for the flat-device-tree version of sandbox. This is a special +# build which does not enable CONFIG_OF_LIVE for the live device tree, so we can +# check that functionality is the same. The standard sandbox build (above) uses +# CONFIG_OF_LIVE. run_test "sandbox_flattree" ./test/py/test.py --bd sandbox_flattree --build # Set up a path to dtc (device-tree compiler) and libfdt.py, a library it @@ -33,6 +36,7 @@ export DTC=${DTC_DIR}/dtc run_test "binman" ./tools/binman/binman -t run_test "patman" ./tools/patman/patman --test run_test "buildman" ./tools/buildman/buildman -t +run_test "fdt" ./tools/dtoc/test_fdt -t run_test "dtoc" ./tools/dtoc/dtoc -t # This needs you to set up Python test coverage tools. @@ -42,7 +46,7 @@ run_test "binman code coverage" ./tools/binman/binman -T run_test "dtoc code coverage" ./tools/dtoc/dtoc -T run_test "fdt code coverage" ./tools/dtoc/test_fdt -T -if [ $result == 0 ]; then +if [ $failures == 0 ]; then echo "Tests passed!" else echo "Tests FAILED"