From patchwork Thu Aug 23 03:01:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kever Yang X-Patchwork-Id: 961143 X-Patchwork-Delegate: philipp.tomsich@theobroma-systems.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="T0gSh24w"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 41wq1n4sJ2z9s3Z for ; Thu, 23 Aug 2018 13:01:33 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 529D4C21ED5; Thu, 23 Aug 2018 03:01:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 8C239C21DA6; Thu, 23 Aug 2018 03:01:27 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id ECA09C21DA6; Thu, 23 Aug 2018 03:01:25 +0000 (UTC) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by lists.denx.de (Postfix) with ESMTPS id 23098C21D8E for ; Thu, 23 Aug 2018 03:01:25 +0000 (UTC) Received: by mail-pf1-f172.google.com with SMTP id h79-v6so1054359pfk.8 for ; Wed, 22 Aug 2018 20:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=TYO25sDypBmU6OWrq+1jjYH7gyiajwBqS1HqdOraCl8=; b=T0gSh24wmzjgole9r+5rfxzbnDNoHR6HrgHfJbTCABDLvjluJCSxO9p3HI8e3EVMtb Jf3LAdwL3WTHwbr5wwcr9WKjiKwyThGW2VY3NsI/VqpXQdkBlDJgsLXig5A+CXLFFAfG ua0nVLjapkLJpWpXoW6tz2g2WaMI19SMsFqjWvKr09sfFhVSoaMOZviDuJaf3UXB3RM3 U39RJtKN4DtFrC/xDpHaBENY1XRv0SKIEHefcpWGWdm07mHsjzsV6BN97j5iNf97LdIt U7tKreEH+IvDJeLctbABhpiz/UdEaQYrwVueMPoTynY+2g+7I1QIr0jZNPPd+7HhQTEc qcSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=TYO25sDypBmU6OWrq+1jjYH7gyiajwBqS1HqdOraCl8=; b=qF9pjnS41wAgf09WAq3PvE3H2lkF5vUXlGts4IaWpVwCKwXFdnoPOwyGiTx7FgZRDk JTmrbg9t73EWljEpGQzxXyqT54hgiqyJCuqe81B/uwRFt+xxQuSUNBNxLHamH8TRwiHe PTQuMlw9wjPm11psH7YGihV2Vc6jZxRfX2os5u0MwbcfG/5LNGjJo4nSXPLxhyeeFgKm vYxNueNiHnuSSXlrqPSKXOPkVEDF4qkp9P3LS6g2c2xxfACx/ari1AULVOZYxOqJqb+l ZiipGcIehG9m+1rHIiCYdyi2tujWg+cW3Y/g9C1lxI5MqRv8xoUQGg+6IMwNkwE+Ih9V mv1w== X-Gm-Message-State: AOUpUlESsWFOZhKlSYMq+08kLpV6nyd2nKRMjidz3J1wgYjM3YPU7nPh bMPvoJWqRBhyJ+Vxh5lYbZFBjvER X-Google-Smtp-Source: AA+uWPwVuoh2wsHjXJGLZYaACwJUS1IHbhmk/hFOOjuZtlo30PjPX3/GqA0+do3n4Eej9BqPoxiaJA== X-Received: by 2002:a63:7557:: with SMTP id f23-v6mr18391987pgn.135.1534993283102; Wed, 22 Aug 2018 20:01:23 -0700 (PDT) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id g184-v6sm4164705pgc.22.2018.08.22.20.01.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Aug 2018 20:01:21 -0700 (PDT) From: Kever Yang To: u-boot@lists.denx.de Date: Thu, 23 Aug 2018 11:01:08 +0800 Message-Id: <20180823030108.18805-1-kever.yang@rock-chips.com> X-Mailer: git-send-email 2.18.0 Subject: [U-Boot] [RESENT PATCH] rockchip: make_fit_atf: fix warning unit_address_vs_reg X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Patch fix warning: /builddir/BUILD/u-boot-2018.05-rc2/"arch/arm/mach-rockchip/make_fit_atf.py" \ arch/arm/dts/rk3399-firefly.dtb > u-boot.its ./tools/mkimage -f u-boot.its -E u-boot.itb >/dev/null && cat /dev/null u-boot.itb.tmp: Warning (unit_address_vs_reg): Node /images/uboot@1 has a unit name, but no reg property u-boot.itb.tmp: Warning (unit_address_vs_reg): Node /images/atf@1 has a unit name, but no reg property u-boot.itb.tmp: Warning (unit_address_vs_reg): Node /images/atf@2 has a unit name, but no reg property u-boot.itb.tmp: Warning (unit_address_vs_reg): Node /images/atf@3 has a unit name, but no reg property u-boot.itb.tmp: Warning (unit_address_vs_reg): Node /images/fdt@1 has a unit name, but no reg property u-boot.itb.tmp: Warning (unit_address_vs_reg): Node /configurations/config@1 has a unit name, but no reg property make[1]: Leaving directory '/builddir/BUILD/u-boot-2018.05-rc2/builds/firefly-rk3399' Reported-by: Peter Robinson Signed-off-by: Kever Yang Tested-by: Peter Robinson Reviewed-by: Philipp Tomsich Acked-by: Philipp Tomsich --- arch/arm/mach-rockchip/make_fit_atf.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-rockchip/make_fit_atf.py b/arch/arm/mach-rockchip/make_fit_atf.py index 6b3d9201c9..62b9caee34 100755 --- a/arch/arm/mach-rockchip/make_fit_atf.py +++ b/arch/arm/mach-rockchip/make_fit_atf.py @@ -34,7 +34,7 @@ DT_HEADER="""// SPDX-License-Identifier: GPL-2.0+ OR X11 #address-cells = <1>; images { - uboot@1 { + uboot { description = "U-Boot (64-bit)"; data = /incbin/("u-boot-nodtb.bin"); type = "standalone"; @@ -58,7 +58,7 @@ def append_atf_node(file, atf_index, phy_addr): Append ATF DT node to input FIT dts file. """ data = 'bl31_0x%08x.bin' % phy_addr - print >> file, '\t\tatf@%d {' % atf_index + print >> file, '\t\tatf_%d {' % atf_index print >> file, '\t\t\tdescription = \"ARM Trusted Firmware\";' print >> file, '\t\t\tdata = /incbin/("%s");' % data print >> file, '\t\t\ttype = "firmware";' @@ -78,7 +78,7 @@ def append_fdt_node(file, dtbs): cnt = 1 for dtb in dtbs: dtname = os.path.basename(dtb) - print >> file, '\t\tfdt@%d {' % cnt + print >> file, '\t\tfdt_%d {' % cnt print >> file, '\t\t\tdescription = "%s";' % dtname print >> file, '\t\t\tdata = /incbin/("%s");' % dtb print >> file, '\t\t\ttype = "flat_dt";' @@ -88,17 +88,17 @@ def append_fdt_node(file, dtbs): cnt = cnt + 1 def append_conf_section(file, cnt, dtname, atf_cnt): - print >> file, '\t\tconfig@%d {' % cnt + print >> file, '\t\tconfig_%d {' % cnt print >> file, '\t\t\tdescription = "%s";' % dtname - print >> file, '\t\t\tfirmware = "atf@1";' - print >> file, '\t\t\tloadables = "uboot@1",', + print >> file, '\t\t\tfirmware = "atf_1";' + print >> file, '\t\t\tloadables = "uboot",', for i in range(1, atf_cnt): - print >> file, '"atf@%d"' % (i+1), + print >> file, '"atf_%d"' % (i+1), if i != (atf_cnt - 1): print >> file, ',', else: print >> file, ';' - print >> file, '\t\t\tfdt = "fdt@1";' + print >> file, '\t\t\tfdt = "fdt_1";' print >> file, '\t\t};' print >> file, '' @@ -108,7 +108,7 @@ def append_conf_node(file, dtbs, atf_cnt): """ cnt = 1 print >> file, '\tconfigurations {' - print >> file, '\t\tdefault = "config@1";' + print >> file, '\t\tdefault = "config_1";' for dtb in dtbs: dtname = os.path.basename(dtb) append_conf_section(file, cnt, dtname, atf_cnt)