From patchwork Sat Jul 21 16:40:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 947397 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 41XtmB73Ysz9s3Z for ; Sun, 22 Jul 2018 02:40:41 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 51863C21E13; Sat, 21 Jul 2018 16:40:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 17367C21D65; Sat, 21 Jul 2018 16:40:29 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id CF66BC21D65; Sat, 21 Jul 2018 16:40:27 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by lists.denx.de (Postfix) with ESMTPS id 4E29AC21C29 for ; Sat, 21 Jul 2018 16:40:27 +0000 (UTC) Received: from LPT2.fritz.box ([88.152.14.153]) by mail.gmx.com (mrgmx102 [212.227.17.174]) with ESMTPSA (Nemesis) id 0MZOan-1fSHn214U1-00LE7C; Sat, 21 Jul 2018 18:40:25 +0200 From: Heinrich Schuchardt To: Tom Rini Date: Sat, 21 Jul 2018 18:40:20 +0200 Message-Id: <20180721164020.26150-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.18.0 X-Provags-ID: V03:K1:Za0pAIYDSOPgnYt9jDp6R1Y9kSg9zBIHiIwI6yBnYVcxdKazCXd FA0DMWLbFog0rkDDWoIJ6N9BzzR1wU+qIGG5FlXjJ9BotazJNbX/4LsvR+VBEa7PxMRb6h4 tW687Ubf2rwdQROKRo2Ym4HB6przyPU/Pb2T/CBs8+BsGvVGAZpadnNwbShX3B4cyB7J77K qHVSTgHCfVWCdAybgfq+Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:fUOLgwnP2SI=:mhaW2u/SNbneaY2LhhTADl vhZImq7EIoU1cM//A6WXRyKRVcfMTGCBM49P/mTau+/bhRvSpfJSW09BJhNfgxEck+mtjHh31 0EBJLVdzDPWSPWWQZIKt85/oBV/MNZ9JC4ye9LC3lUJuo+beSJhmj5gBDktRUCdG1nRoW8eZ6 zMF1Hm6dstiBMgWEUYl62g+3twOMBxQlvaDDxXk6lkZ99pOOXwUI78PNKhIdWqgFDL/lVICtR +BY8KNQtijyZdzhY0UjOiurb88ME8oEDmQ+dLl367dE4sqfJKnAqZKhnw1Au/OvonF7yQfPYh cNoxRF9DqDh3i6100puIl/bJMFmBpj5grKLO415c73QqUo2jBSCL0WpGO0c5XKJId1fOuWThS rK8fC/ILovwb/N9n4G1UtMaR5pbb+c+QndrPEe68OWSJktkcWike65R08msh6nxN6UzQ1ckSk L15D3HJdL0OUK9NwX8n4Txjg7AMqzVRWXbBENEJlOpWqKxhcWE2ojjIUT6PSL/O6XR+odg/pg Oxc74PYjOdRPHFsBX0UrzW2rfkMvAn6BevkE1uUehuhW3jqS6iyrZPbQAfTT3xa/8lZzmePB4 jnDuzNaoMCqAyGx9F9DwM7F3vQiMzuC2wX2HG5sZQrQDfal2gRPAUBmqvqUxA0j8MCexnW77r lc8l4TBMDVG5RGXaDqGwcGFTeE6T0SHgkmBshOxK836A96Pudt0pxH+KGVaALt7LE7Gy5MxpY X4+UUMlq6j0OXUCLolJ8g31dvK7qOnR9KO1Q+IzC4oJBDmKML23GWKMNWMc= Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [U-Boot] [PATCH 1/1] drivers: rtc: correctly set week day for mc146818 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The driver sets the weekday incorrectly when called by the 'date set' command. Sunday is 1, Saturday is 7 unlike in U-Boot (see data sheet https://www.nxp.com/docs/en/data-sheet/MC146818.pdf, table 3). Signed-off-by: Heinrich Schuchardt --- drivers/rtc/mc146818.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/mc146818.c b/drivers/rtc/mc146818.c index 744c0f4d75..b98c39d821 100644 --- a/drivers/rtc/mc146818.c +++ b/drivers/rtc/mc146818.c @@ -143,7 +143,8 @@ static int mc146818_set(struct rtc_time *tmp) mc146818_write8(RTC_YEAR, bin2bcd(tmp->tm_year % 100)); mc146818_write8(RTC_MONTH, bin2bcd(tmp->tm_mon)); - mc146818_write8(RTC_DAY_OF_WEEK, bin2bcd(tmp->tm_wday)); + /* Sunday = 1, Saturday = 7 */ + mc146818_write8(RTC_DAY_OF_WEEK, bin2bcd(tmp->tm_wday + 1)); mc146818_write8(RTC_DATE_OF_MONTH, bin2bcd(tmp->tm_mday)); mc146818_write8(RTC_HOURS, bin2bcd(tmp->tm_hour)); mc146818_write8(RTC_MINUTES, bin2bcd(tmp->tm_min));